All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Khem Raj" <raj.khem@gmail.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 1/4] initscripts: use quotes for shell variable comparision
Date: Thu, 17 Dec 2020 19:53:59 -0800	[thread overview]
Message-ID: <CAMKF1sqVk6wgp9KeZm58arYYH-4UfUmLffeC6mdU=03ekZo6Yg@mail.gmail.com> (raw)
In-Reply-To: <CAJ86T=U04Ny3=sS+oJ=PJ-HfE6de+q176+UMgEguS5qcJqBWKw@mail.gmail.com>

On Thu, Dec 17, 2020 at 4:02 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>
> On Thu, Dec 17, 2020 at 3:54 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Thu, Dec 17, 2020 at 3:51 PM Andre McCurdy <armccurdy@gmail.com> wrote:
> > >
> > > On Thu, Dec 17, 2020 at 2:54 PM Khem Raj <raj.khem@gmail.com> wrote:
> > > >
> > > > Helps to execute it with busybox shell
> > >
> > > How does it help? Adding quotes would help if $rootcheck is an empty
> > > string, but that's not specific to busybox.
> > >
> > > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > > ---
> > > >  meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh b/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh
> > > > index 02f0351fcb..a63e71b780 100755
> > > > --- a/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh
> > > > +++ b/meta/recipes-core/initscripts/initscripts-1.0/checkroot.sh
> > > > @@ -74,7 +74,7 @@ test "$VERBOSE" != no && echo "Activating swap"
> > > >  #
> > > >  # Check the root filesystem.
> > > >  #
> > > > -if test -f /fastboot || test $rootcheck = no
> > > > +if test -f /fastboot || test "$rootcheck" = "no"
> > > >  then
> > > >    test $rootcheck = yes && echo "Fast boot, no filesystem check"
> > >
> > > Doesn't this instance need to be quoted too?
> >
> > yes infact there are more cleanup to follow, this series just fixed
> > default boot errors on reference images.
>
> Adding quotes around a variable should probably be done consistently,
> so maybe it makes sense to hold off on this one until you've finished
> the cleanup?

it doesn't matter, I would be creating per package patches.

      reply	other threads:[~2020-12-18  3:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 22:54 [PATCH 1/4] initscripts: use quotes for shell variable comparision Khem Raj
2020-12-17 22:54 ` [PATCH 2/4] busybox: Install /etc/default/rcS when used as init system Khem Raj
2020-12-17 22:54 ` [PATCH 3/4] busybox: Run mdev as daemon Khem Raj
2020-12-17 23:59   ` [OE-core] " Andre McCurdy
2020-12-18  2:45     ` Christopher Larson
2020-12-18  3:52     ` Khem Raj
2020-12-18  6:07       ` Andre McCurdy
2020-12-18 16:33         ` Khem Raj
2020-12-17 22:54 ` [PATCH 4/4] initscripts: Use initctl on sysvinit only Khem Raj
2020-12-18 18:29   ` [OE-core] " Sinan Kaya
2020-12-18 18:46     ` Khem Raj
2020-12-18 19:18       ` Sinan Kaya
2020-12-19  1:56         ` Khem Raj
2020-12-18 18:49   ` Peter Kjellerstedt
2020-12-17 23:51 ` [OE-core] [PATCH 1/4] initscripts: use quotes for shell variable comparision Andre McCurdy
2020-12-17 23:53   ` Khem Raj
2020-12-18  0:02     ` Andre McCurdy
2020-12-18  3:53       ` Khem Raj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMKF1sqVk6wgp9KeZm58arYYH-4UfUmLffeC6mdU=03ekZo6Yg@mail.gmail.com' \
    --to=raj.khem@gmail.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.