From: "Khem Raj" <raj.khem@gmail.com>
To: Zig Globulin <zig@zigsystem.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-gnome][PATCH] libuvc: add recipe
Date: Wed, 30 Sep 2020 20:20:30 -0700 [thread overview]
Message-ID: <CAMKF1sqZMZVBh+E2e9-Zy6uY-bD_f2mG=JBO2bbupoMEgRvoGg@mail.gmail.com> (raw)
In-Reply-To: <20200930232008.1342160-1-zig@zigsystem.com>
[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]
Thanks for submitting the patch please add it to relevant packagegroup as
well in packagegroup-meta-gnome.bb
On Wed, Sep 30, 2020 at 4:20 PM Zig Globulin <zig@zigsystem.com> wrote:
> Signed-off-by: Zig Globulin <zig@zigsystem.com>
>
> ---
>
> meta-multimedia/recipes-multimedia/libuvc/libuvc.bb | 13 +++++++++++++
>
> 1 file changed, 13 insertions(+)
>
> create mode 100644 meta-multimedia/recipes-multimedia/libuvc/libuvc.bb
>
>
>
> diff --git a/meta-multimedia/recipes-multimedia/libuvc/libuvc.bb
> b/meta-multimedia/recipes-multimedia/libuvc/libuvc.bb
>
> new file mode 100644
>
> index 000000000..27cc17bc6
>
> --- /dev/null
>
> +++ b/meta-multimedia/recipes-multimedia/libuvc/libuvc.bb
>
> @@ -0,0 +1,13 @@
>
> +SUMMARY = "library for USB video devices built atop libusb"
>
> +HOMEPAGE = "https://github.com/libuvc/libuvc.git"
>
> +LICENSE = "BSD"
It would be better to state which variant of BSD
>
>
> +LIC_FILES_CHKSUM =
> "file://LICENSE.txt;md5=2f1963e0bb88c93463af750daf9ba0c2"
>
> +DEPENDS = "libusb jpeg"
>
> +
>
> +SRC_URI = "git://github.com/libuvc/libuvc.git"
>
> +SRCREV = "ad6c72a4e390367f0d2be81aac00cfc0b6680d74"
>
> +PV = "v0.0.6+git${SRCPV}"
It’s perhaps better to call the recipe libuvc_0.0.6.bb and remove setting
PV here provided you are building at the same commit as 0.0.6
>
> +
>
> +S = "${WORKDIR}/git"
>
> +
>
> +inherit cmake
>
> --
>
> 2.28.0
>
>
>
>
>
>
>
>
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 3051 bytes --]
next prev parent reply other threads:[~2020-10-01 3:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 23:20 [meta-gnome][PATCH] libuvc: add recipe zig
2020-10-01 3:20 ` Khem Raj [this message]
2020-10-01 15:09 ` [oe] " tom king
2020-10-01 15:12 ` Martin Jansa
2020-10-04 8:05 ` [meta-multimedia][PATCH] " Zig Globulin
2020-10-05 1:15 ` [oe] " Khem Raj
2020-10-05 6:21 ` Zig Globulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMKF1sqZMZVBh+E2e9-Zy6uY-bD_f2mG=JBO2bbupoMEgRvoGg@mail.gmail.com' \
--to=raj.khem@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=zig@zigsystem.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.