From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 89583E00E85; Thu, 10 May 2018 18:07:09 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (raj.khem[at]gmail.com) * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [74.125.83.52 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-pg0-f52.google.com (mail-pg0-f52.google.com [74.125.83.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0DD79E00831 for ; Thu, 10 May 2018 18:07:08 -0700 (PDT) Received: by mail-pg0-f52.google.com with SMTP id p9-v6so1696097pgc.9 for ; Thu, 10 May 2018 18:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Kpi+VzVbIS5elwCJ7JZREvkKovz/45egtL/9/V7jdZU=; b=coYnPZ8iiU9bONZvsXMoGx01rNO/723fI17td4K0pMwDyPNNqSBRLw2D/R1+m6Qyhr GkQuj7BjjORPwNB/kb+3hZuYuFdebBi/uBmWt8efWuxVLGb0RwE9sh0sa9Oe7ctC4Zgp ev/UwtEM8ps5d15eTE+RnUTuLpp51KU0C1YFy9swYX8LRNdzWQHYCW7GyCqPtAbEkCAW bV3r/xCATdjf4+r2o+il/P9hD0uCDkOmWQGKvcucQ1jw3WFeF808DuuiEULwo7C/VIHf hDtQCFQ7K5vgjqdMhkRcvSIC8NN0lT3SHAQfPPLLfFlVpsK7dWx/eyJV8g90oMacCLco prZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Kpi+VzVbIS5elwCJ7JZREvkKovz/45egtL/9/V7jdZU=; b=O4cMD2Ia74chKO49n+SH55OwDZ/PRYhncPEZyoAn2mnfhS2Uz4LUP6ltT2Cwi3eCkM iOnBSynWzWPAdeYsmbRCIpXS/bTM2Tf3SUU8omrhmDIFeX2CImBTht/tXDsyu2yzhIdc PyJVreMoK5hOTMVNCotrT/uwryKVleS6o/MxUY7iIAs5wmy1+sQBrXADm0LHVfZTcPjp M8VenDP/5xWy0BJdx0qeGMzut7h+AGwVIRG6mwUEWPJ0jX9rBBxZh09OE4ddUSA5ouLn obVWWYZXrEtfmtEvZM8UiLpCjo4aPkfaMiDnIdBoEwsLmU6ZhJww+Lee3X8mvva8GZXd JCZA== X-Gm-Message-State: ALKqPwedYSr5ysaLK02wg39+tEMq/1cZ6Tr11KN33ATVNnCk3EpG9oAC KSI6jIIAwz0IO5rw2zWjKfkbmZj358tuUZVqQDg= X-Google-Smtp-Source: AB8JxZo0jE2hlLLqsRxQVH9MTZw/Qk7vJi6MJvc9OlIXtLIQzl91ccMr4J8ASyF650SFTlZWfxdNXXf8l4ps5oUl5iw= X-Received: by 2002:a62:74b:: with SMTP id b72-v6mr3373517pfd.133.1526000828028; Thu, 10 May 2018 18:07:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.139.145 with HTTP; Thu, 10 May 2018 18:06:37 -0700 (PDT) In-Reply-To: References: <8d962430-ac63-5e97-fd32-2c0464c62acb@gmail.com> <20180510191145.GA1954@jama> <20180510214325.GC1954@jama> <20180510220735.GD1954@jama> <20180510225017.GE1954@jama> From: Khem Raj Date: Thu, 10 May 2018 18:06:37 -0700 Message-ID: To: Andre McCurdy Cc: Yocto Project , Patches and discussions about the oe-core layer , openembedded-devel Subject: Re: [OE-core] [RFT] GCC 8.1 X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 01:07:09 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, May 10, 2018 at 6:00 PM, Andre McCurdy wrote: > On Thu, May 10, 2018 at 5:55 PM, Khem Raj wrote: >> On Thu, May 10, 2018 at 4:11 PM, Andre McCurdy wrote: >>> On Thu, May 10, 2018 at 3:50 PM, Martin Jansa wrote: >>>> On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: >>>>> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa wrote: >>>>> > see >>>>> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html >>>>> >>>>> Removing -fno-omit-frame-pointer isn't the same as adding >>>>> -fomit-frame-pointer. Frame pointers may get enabled depending on the >>>>> optimisation level etc (ie not only by -fno-omit-frame-pointer). >>>> >>>> Should I send v2 adding -fomit-frame-pointer instead of removing >>>> -fno-omit-frame-pointer? >>>> >>>> The v1 fixes the issue for me with default config + DEBUG_BUILD. >>> >>> The v1 patch isn't wrong, it's just incomplete (the problem could come >>> back if someone changes optimisation level or switches gcc to clang, >>> etc). >>> >>> My choice would be a v2 patch which adds -fomit-frame-pointer to >>> CFLAGS unconditionally for all ARM builds when Thumb is enabled. That >>> should fix the problem for all optimisation levels etc and avoids >>> building the main strace binary differently depending on whether or >>> not ptest is enabled. >> >> explicitly adding this option is a poor choice especially for debug >> builds where we should >> let the -On level decide and not explicitly ask for either >> enable/disable frame-pointers >> that will also make it compiler proof. > > Of course, we should let the compiler decide whenever it's possible to do so. > > Unfortunately there are cases like this one where frame pointers clash > with inline assembler and we need to over-rule the compiler's choice. Here we are adding -fno-omit-frame-pointer via global opt flags that is the issue where we have fallouts from default O options I agree we should teach this to build system and help the compiler From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41]) by mail.openembedded.org (Postfix) with ESMTP id 5A33A75424; Fri, 11 May 2018 01:07:06 +0000 (UTC) Received: by mail-pg0-f41.google.com with SMTP id l2-v6so1698980pgc.7; Thu, 10 May 2018 18:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Kpi+VzVbIS5elwCJ7JZREvkKovz/45egtL/9/V7jdZU=; b=coYnPZ8iiU9bONZvsXMoGx01rNO/723fI17td4K0pMwDyPNNqSBRLw2D/R1+m6Qyhr GkQuj7BjjORPwNB/kb+3hZuYuFdebBi/uBmWt8efWuxVLGb0RwE9sh0sa9Oe7ctC4Zgp ev/UwtEM8ps5d15eTE+RnUTuLpp51KU0C1YFy9swYX8LRNdzWQHYCW7GyCqPtAbEkCAW bV3r/xCATdjf4+r2o+il/P9hD0uCDkOmWQGKvcucQ1jw3WFeF808DuuiEULwo7C/VIHf hDtQCFQ7K5vgjqdMhkRcvSIC8NN0lT3SHAQfPPLLfFlVpsK7dWx/eyJV8g90oMacCLco prZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Kpi+VzVbIS5elwCJ7JZREvkKovz/45egtL/9/V7jdZU=; b=oBos5iv4ujSVewgTBQBy9Je3Va+DIXSh14H6kDwA/TzqH7j8SVRnvNjZl0h7tugS6T 5ijNtmd01x8h895P1EIObka7jzx5atwLgVrhXkFbdOxoIP8ZazEGeici/dm5Vkh2Sp3Y 9e6cGv4NL9MUxcNo1uuQi9P0IaZP4pcVCaiuthJZKvyZFx60bqo8SO1iVMtBc51RX6DR 9KQtclSsTkX4jPUuGp537aOFtnvEsJXCwmUOd0LT/wCoZfiACprEKU/McKLsSZ4ZaJDl LqtiMDgayZTRSJD+tNWVa0rlgcDrNFNmn1Efc6M1rH8zSn71sfIyf9jMCsMdwvH5rYi0 BYIg== X-Gm-Message-State: ALKqPwdh10l/40IlBlvvf/fxkZDWXF56F1i2eZiF4hIiQgaSengwpPh2 7IhGwGm8jgNcoJxcBH/TnA6dutSoFFsW/KrD1Zk= X-Google-Smtp-Source: AB8JxZo0jE2hlLLqsRxQVH9MTZw/Qk7vJi6MJvc9OlIXtLIQzl91ccMr4J8ASyF650SFTlZWfxdNXXf8l4ps5oUl5iw= X-Received: by 2002:a62:74b:: with SMTP id b72-v6mr3373517pfd.133.1526000828028; Thu, 10 May 2018 18:07:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.236.139.145 with HTTP; Thu, 10 May 2018 18:06:37 -0700 (PDT) In-Reply-To: References: <8d962430-ac63-5e97-fd32-2c0464c62acb@gmail.com> <20180510191145.GA1954@jama> <20180510214325.GC1954@jama> <20180510220735.GD1954@jama> <20180510225017.GE1954@jama> From: Khem Raj Date: Thu, 10 May 2018 18:06:37 -0700 Message-ID: To: Andre McCurdy Cc: Yocto Project , Patches and discussions about the oe-core layer , openembedded-devel Subject: Re: [RFT] GCC 8.1 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 01:07:07 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, May 10, 2018 at 6:00 PM, Andre McCurdy wrote: > On Thu, May 10, 2018 at 5:55 PM, Khem Raj wrote: >> On Thu, May 10, 2018 at 4:11 PM, Andre McCurdy wrote: >>> On Thu, May 10, 2018 at 3:50 PM, Martin Jansa wrote: >>>> On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: >>>>> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa wrote: >>>>> > see >>>>> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html >>>>> >>>>> Removing -fno-omit-frame-pointer isn't the same as adding >>>>> -fomit-frame-pointer. Frame pointers may get enabled depending on the >>>>> optimisation level etc (ie not only by -fno-omit-frame-pointer). >>>> >>>> Should I send v2 adding -fomit-frame-pointer instead of removing >>>> -fno-omit-frame-pointer? >>>> >>>> The v1 fixes the issue for me with default config + DEBUG_BUILD. >>> >>> The v1 patch isn't wrong, it's just incomplete (the problem could come >>> back if someone changes optimisation level or switches gcc to clang, >>> etc). >>> >>> My choice would be a v2 patch which adds -fomit-frame-pointer to >>> CFLAGS unconditionally for all ARM builds when Thumb is enabled. That >>> should fix the problem for all optimisation levels etc and avoids >>> building the main strace binary differently depending on whether or >>> not ptest is enabled. >> >> explicitly adding this option is a poor choice especially for debug >> builds where we should >> let the -On level decide and not explicitly ask for either >> enable/disable frame-pointers >> that will also make it compiler proof. > > Of course, we should let the compiler decide whenever it's possible to do so. > > Unfortunately there are cases like this one where frame pointers clash > with inline assembler and we need to over-rule the compiler's choice. Here we are adding -fno-omit-frame-pointer via global opt flags that is the issue where we have fallouts from default O options I agree we should teach this to build system and help the compiler