From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E154C433F5 for ; Thu, 27 Jan 2022 21:01:58 +0000 (UTC) Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by mx.groups.io with SMTP id smtpd.web09.3839.1643317317157443114 for ; Thu, 27 Jan 2022 13:01:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YJps2Eit; spf=pass (domain: gmail.com, ip: 209.85.222.178, mailfrom: raj.khem@gmail.com) Received: by mail-qk1-f178.google.com with SMTP id 200so3813904qki.2 for ; Thu, 27 Jan 2022 13:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JiCIeNxUSN2JGxgoJ4qnfDzYc+SrMaLx0jCAx3JXukU=; b=YJps2Eit/p+SsI+SYwxeJEyZu9VEsUoq/K+HE2MU3s7ocywy1R7LM0wHdVqYuz7nkO FLvfI1TQ7sHtJI6oDCPNtQ2Z58c2/z8WqJTLKbPs93W08tV+hr7HDxebWBUIxeqCAg1B qIwm7EsvgQZV64/GhPhTIKC3vNSfEPgqScipA+BYnjUEkzAwvPZnKD5hH77gtPexs0vM RomEt9STRT05HsxaYWYsyft/+bRCW9b9MckU/ckQNDDWuVHBsmfYfbOh5WKOVYQMJVzH htplD5VL+Li2zMf53bv+hNnMsKCnLY2O2FeRq9w3SzNkHd0YVrXZ/VlwVUextfJILACI EncA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JiCIeNxUSN2JGxgoJ4qnfDzYc+SrMaLx0jCAx3JXukU=; b=YblbV815QwDFTnDsQ/r9fW1sgCSLr4afSJXAyZHBBLMO2LaFwUEEmTl9BAwZpiu3Xe DHjZS9K+pH990jwUYoakYSmmAaNet3Y217Lwpq3B6cemL+ShqKqO/Z3bi00IWLR8tAyW fgKtIMq6MKvXP2B7w43d2Jd9lL1gzFxXKGo85OGQfWC3qo46NDI7PnL96cI91K0c84VA er7cmUct3KQ5U+oIR4oIGKo8Bawm5Eg0nHRj4Jzc+slkQ8KMKX0ky1AdcpfunFQIeQ+E 4ySNbK1fZ3kOBUOOfjpVlL6nZw8ATP4YNbmi0cUTAT30sDSa54ZONmP+UqVRCOn9VSdp 5WVA== X-Gm-Message-State: AOAM530WbNfpMWT3ZPreS3b3cOTZ6lBgX4H374mWXzj+cMTcsTJ/tMsV F+5dJQQNtfWHZrVanLVgmJY3Efw0HnozMWdwx5U= X-Google-Smtp-Source: ABdhPJyk/ssz5gWqiF8D/wpUQNYH+83BYyTYVQ0lfb9OUpTCX0NN3/f6ZEytoMcoqciWu7NuzJqh42NGgm+4lKUUmzQ= X-Received: by 2002:a37:6493:: with SMTP id y141mr3876588qkb.180.1643317316141; Thu, 27 Jan 2022 13:01:56 -0800 (PST) MIME-Version: 1.0 References: <20220127102005.3050843-1-alex@linutronix.de> <20220127102005.3050843-11-alex@linutronix.de> <16CE388D38E12D03.16917@lists.openembedded.org> In-Reply-To: From: Khem Raj Date: Thu, 27 Jan 2022 13:01:45 -0800 Message-ID: Subject: Re: [OE-core] [PATCH 11/17] zstd: update 1.5.0 -> 1.5.2 To: Alexander Kanavin Cc: Alexander Kanavin , Joshua Watt , Patches and discussions about the oe-core layer Content-Type: multipart/alternative; boundary="000000000000e1c58605d696a0e8" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 27 Jan 2022 21:01:58 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/161057 --000000000000e1c58605d696a0e8 Content-Type: text/plain; charset="UTF-8" On Thu, Jan 27, 2022 at 12:10 PM Alexander Kanavin wrote: > I think zstd changelog for 1.5.1 settles the issue: > > https://github.com/facebook/zstd/releases/tag/v1.5.1 > Yeah indeed thanks > > Alex > > On Thu, 27 Jan 2022 at 20:51, Alexander Kanavin via lists.openembedded.org > wrote: > >> On Thu, 27 Jan 2022 at 19:56, Khem Raj wrote: >> >>> quick look shows that size of zstd package reduces quite a bit, I wonder >>> why >>> >>> -4720 KiB zstd >>> +2932 KiB zstd >>> >>> small is ofcourse better, but I wonder what could reduce it so much >>> between 1.5.0 and 1.5.2 >>> >> >> buildhistory-diff does not reveal anything fishy: >> >> alex@nereus:~/development/poky/build-64-alt$ buildhistory-diff >> Changes to packages/core2-64-poky-linux/zstd (sysroot): >> /usr/lib/libzstd.so.1 changed symlink target from libzstd.so.1.5.0 to >> libzstd.so.1.5.2 >> /usr/lib/libzstd.so changed symlink target from libzstd.so.1.5.0 to >> libzstd.so.1.5.2 >> /usr/lib/libzstd.so.1.5.0 moved to /usr/lib/libzstd.so.1.5.2 >> packages/core2-64-poky-linux/zstd/zstd-dbg: PKGSIZE changed from 23736192 >> to 16994448 (-28%) >> packages/core2-64-poky-linux/zstd/zstd-src: PKGSIZE changed from 2741079 >> to 3050284 (+11%) >> packages/core2-64-poky-linux/zstd/zstd-staticdev: PKGSIZE changed from >> 9332966 to 6596796 (-29%) >> packages/core2-64-poky-linux/zstd/zstd: PKGSIZE changed from 3279119 to >> 2407719 (-27%) >> packages/core2-64-poky-linux/zstd/zstd: FILELIST: removed >> "/usr/lib/libzstd.so.1.5.0", added "/usr/lib/libzstd.so.1.5.2" >> Changes to packages/x86_64-linux/zstd-native (sysroot): >> /usr/lib/libzstd.so.1 changed symlink target from libzstd.so.1.5.0 to >> libzstd.so.1.5.2 >> /usr/lib/libzstd.so changed symlink target from libzstd.so.1.5.0 to >> libzstd.so.1.5.2 >> /usr/lib/libzstd.so.1.5.0 moved to /usr/lib/libzstd.so.1.5.2 >> >> Alex >> >> >> >> >>> >>> On Thu, Jan 27, 2022 at 2:20 AM Alexander Kanavin >>> wrote: >>> > >>> > Drop patches merged upstream. >>> > >>> > Signed-off-by: Alexander Kanavin >>> > --- >>> > ...rt-all-wildcard-file-list-expansions.patch | 81 -------- >>> > .../zstd/zstd/0001-MinGW-Build-Fixes.patch | 193 ------------------ >>> > .../zstd/{zstd_1.5.0.bb => zstd_1.5.2.bb} | 7 +- >>> > 3 files changed, 2 insertions(+), 279 deletions(-) >>> > delete mode 100644 >>> meta/recipes-extended/zstd/zstd/0001-Makefile-sort-all-wildcard-file-list-expansions.patch >>> > delete mode 100644 >>> meta/recipes-extended/zstd/zstd/0001-MinGW-Build-Fixes.patch >>> > rename meta/recipes-extended/zstd/{zstd_1.5.0.bb => zstd_1.5.2.bb} >>> (86%) >>> > >>> > diff --git >>> a/meta/recipes-extended/zstd/zstd/0001-Makefile-sort-all-wildcard-file-list-expansions.patch >>> b/meta/recipes-extended/zstd/zstd/0001-Makefile-sort-all-wildcard-file-list-expansions.patch >>> > deleted file mode 100644 >>> > index 3d23648f5b..0000000000 >>> > --- >>> a/meta/recipes-extended/zstd/zstd/0001-Makefile-sort-all-wildcard-file-list-expansions.patch >>> > +++ /dev/null >>> > @@ -1,81 +0,0 @@ >>> > -From 77c7963c7a0f1c455f20520d5c7b1ec9b17a44fb Mon Sep 17 00:00:00 2001 >>> > -From: Alexander Kanavin >>> > -Date: Wed, 23 Dec 2020 19:14:32 +0100 >>> > -Subject: [PATCH] Makefile: sort all wildcard file list expansions >>> > - >>> > -Otherwise the order is non-deterministic and breaks >>> > -reproducible builds. >>> > - >>> > -Upstream-Status: Submitted [ >>> https://github.com/facebook/zstd/pull/2895] >>> > -Signed-off-by: Alexander Kanavin >>> > - >>> > ---- >>> > - programs/Makefile | 10 +++++----- >>> > - tests/Makefile | 4 ++-- >>> > - tests/fuzz/Makefile | 2 +- >>> > - 3 files changed, 8 insertions(+), 8 deletions(-) >>> > - >>> > -diff --git a/programs/Makefile b/programs/Makefile >>> > -index 599fb02f..2c416467 100644 >>> > ---- a/programs/Makefile >>> > -+++ b/programs/Makefile >>> > -@@ -74,11 +74,11 @@ ZSTDLEGACY_DIR := $(ZSTDDIR)/legacy >>> > - >>> > - vpath %.c $(ZSTDLIB_COMMON) $(ZSTDLIB_COMPRESS) >>> $(ZSTDLIB_DECOMPRESS) $(ZDICT_DIR) $(ZSTDLEGACY_DIR) >>> > - >>> > --ZSTDLIB_COMMON_C := $(wildcard $(ZSTDLIB_COMMON)/*.c) >>> > --ZSTDLIB_COMPRESS_C := $(wildcard $(ZSTDLIB_COMPRESS)/*.c) >>> > --ZSTDLIB_DECOMPRESS_C := $(wildcard $(ZSTDLIB_DECOMPRESS)/*.c) >>> > -+ZSTDLIB_COMMON_C := $(sort $(wildcard $(ZSTDLIB_COMMON)/*.c)) >>> > -+ZSTDLIB_COMPRESS_C := $(sort $(wildcard $(ZSTDLIB_COMPRESS)/*.c)) >>> > -+ZSTDLIB_DECOMPRESS_C := $(sort $(wildcard $(ZSTDLIB_DECOMPRESS)/*.c)) >>> > - ZSTDLIB_CORE_SRC := $(ZSTDLIB_DECOMPRESS_C) $(ZSTDLIB_COMMON_C) >>> $(ZSTDLIB_COMPRESS_C) >>> > --ZDICT_SRC := $(wildcard $(ZDICT_DIR)/*.c) >>> > -+ZDICT_SRC := $(sort $(wildcard $(ZDICT_DIR)/*.c)) >>> > - >>> > - ZSTD_LEGACY_SUPPORT ?= 5 >>> > - ZSTDLEGACY_SRC := >>> > -@@ -93,7 +93,7 @@ ZSTDLIB_FULL_SRC = $(sort $(ZSTDLIB_CORE_SRC) >>> $(ZSTDLEGACY_SRC) $(ZDICT_SRC)) >>> > - ZSTDLIB_LOCAL_SRC = $(notdir $(ZSTDLIB_FULL_SRC)) >>> > - ZSTDLIB_LOCAL_OBJ := $(ZSTDLIB_LOCAL_SRC:.c=.o) >>> > - >>> > --ZSTD_CLI_SRC := $(wildcard *.c) >>> > -+ZSTD_CLI_SRC := $(sort $(wildcard *.c)) >>> > - ZSTD_CLI_OBJ := $(ZSTD_CLI_SRC:.c=.o) >>> > - >>> > - ZSTD_ALL_SRC = $(ZSTDLIB_LOCAL_SRC) $(ZSTD_CLI_SRC) >>> > -diff --git a/tests/Makefile b/tests/Makefile >>> > -index 85553007..b71cdba8 100644 >>> > ---- a/tests/Makefile >>> > -+++ b/tests/Makefile >>> > -@@ -49,7 +49,7 @@ ZSTDDECOMP_FILES := $(ZSTDDIR)/decompress/*.c >>> > - ZSTD_FILES := $(ZSTDDECOMP_FILES) $(ZSTDCOMMON_FILES) >>> $(ZSTDCOMP_FILES) >>> > - ZDICT_FILES := $(ZSTDDIR)/dictBuilder/*.c >>> > - >>> > --ZSTD_F1 := $(wildcard $(ZSTD_FILES)) >>> > -+ZSTD_F1 := $(sort $(wildcard $(ZSTD_FILES))) >>> > - ZSTD_OBJ1 := $(subst $(ZSTDDIR)/common/,zstdm_,$(ZSTD_F1)) >>> > - ZSTD_OBJ2 := $(subst $(ZSTDDIR)/compress/,zstdc_,$(ZSTD_OBJ1)) >>> > - ZSTD_OBJ3 := $(subst $(ZSTDDIR)/decompress/,zstdd_,$(ZSTD_OBJ2)) >>> > -@@ -202,7 +202,7 @@ bigdict: $(ZSTDMT_OBJECTS) $(PRGDIR)/datagen.c >>> bigdict.c >>> > - invalidDictionaries : $(ZSTD_OBJECTS) invalidDictionaries.c >>> > - >>> > - legacy : CPPFLAGS += -I$(ZSTDDIR)/legacy -DZSTD_LEGACY_SUPPORT=4 >>> > --legacy : $(ZSTD_FILES) $(wildcard $(ZSTDDIR)/legacy/*.c) legacy.c >>> > -+legacy : $(ZSTD_FILES) $(sort $(wildcard $(ZSTDDIR)/legacy/*.c)) >>> legacy.c >>> > - >>> > - decodecorpus : LDLIBS += -lm >>> > - decodecorpus : $(filter-out zstdc_zstd_compress.o, $(ZSTD_OBJECTS)) >>> $(ZDICT_FILES) $(PRGDIR)/util.c $(PRGDIR)/timefn.c decodecorpus.c >>> > -diff --git a/tests/fuzz/Makefile b/tests/fuzz/Makefile >>> > -index ccb574b7..b1cb2935 100644 >>> > ---- a/tests/fuzz/Makefile >>> > -+++ b/tests/fuzz/Makefile >>> > -@@ -62,7 +62,7 @@ FUZZ_SRC := \ >>> > - $(ZSTDCOMP_SRC) \ >>> > - $(ZSTDDICT_SRC) \ >>> > - $(ZSTDLEGACY_SRC) >>> > --FUZZ_SRC := $(wildcard $(FUZZ_SRC)) >>> > -+FUZZ_SRC := $(sort $(wildcard $(FUZZ_SRC))) >>> > - >>> > - FUZZ_D_OBJ1 := $(subst $(ZSTDDIR)/common/,d_lib_common_,$(FUZZ_SRC)) >>> > - FUZZ_D_OBJ2 := $(subst >>> $(ZSTDDIR)/compress/,d_lib_compress_,$(FUZZ_D_OBJ1)) >>> > diff --git >>> a/meta/recipes-extended/zstd/zstd/0001-MinGW-Build-Fixes.patch >>> b/meta/recipes-extended/zstd/zstd/0001-MinGW-Build-Fixes.patch >>> > deleted file mode 100644 >>> > index a0e00dca03..0000000000 >>> > --- a/meta/recipes-extended/zstd/zstd/0001-MinGW-Build-Fixes.patch >>> > +++ /dev/null >>> > @@ -1,193 +0,0 @@ >>> > -From ab9a34c92eec815ef214470c927ddbe2e950e7e5 Mon Sep 17 00:00:00 2001 >>> > -From: Joshua Watt >>> > -Date: Wed, 26 May 2021 09:15:40 -0500 >>> > -Subject: [PATCH] MinGW Build Fixes >>> > - >>> > -Fixes building on MinGW by >>> > - 1) Exporting the OS variable so that it is visible to sub-make >>> > - invocations >>> > - 2) Fixing the extension handling so that make correctly identifies >>> when >>> > - targets need to be rebuilt. Without the correct handling, make >>> would >>> > - rebuild the executable targets when running `make install` because >>> > - it couldn't find them with the correct extension. >>> > - >>> > -Upstream-Status: Submitted [ >>> https://github.com/facebook/zstd/pull/2685] >>> > -Signed-off-by: Joshua Watt >>> > ---- >>> > - Makefile | 1 + >>> > - programs/Makefile | 74 >>> +++++++++++++++++++++++------------------------ >>> > - 2 files changed, 38 insertions(+), 37 deletions(-) >>> > - >>> > -diff --git a/Makefile b/Makefile >>> > -index c1908f0a..f9ce9504 100644 >>> > ---- a/Makefile >>> > -+++ b/Makefile >>> > -@@ -29,6 +29,7 @@ VOID = /dev/null >>> > - # fail on other tested distros (ubuntu, debian) even >>> > - # without manually specifying the TARGET_SYSTEM. >>> > - TARGET_SYSTEM ?= $(OS) >>> > -+export OS >>> > - >>> > - ifneq (,$(filter Windows%,$(TARGET_SYSTEM))) >>> > - EXT =.exe >>> > -diff --git a/programs/Makefile b/programs/Makefile >>> > -index 599fb02f..79b45c83 100644 >>> > ---- a/programs/Makefile >>> > -+++ b/programs/Makefile >>> > -@@ -209,37 +209,37 @@ SET_CACHE_DIRECTORY = \ >>> > - >>> > - >>> > - .PHONY: all >>> > --all: zstd >>> > -+all: zstd$(EXT) >>> > - >>> > - .PHONY: allVariants >>> > --allVariants: zstd zstd-compress zstd-decompress zstd-small >>> zstd-nolegacy zstd-dictBuilder >>> > -+allVariants: zstd$(EXT) zstd-compress$(EXT) zstd-decompress$(EXT) >>> zstd-small$(EXT) zstd-nolegacy$(EXT) zstd-dictBuilder$(EXT) >>> > - >>> > - .PHONY: zstd # must always be run >>> > --zstd : CPPFLAGS += $(THREAD_CPP) $(ZLIBCPP) $(LZMACPP) $(LZ4CPP) >>> > --zstd : LDFLAGS += $(THREAD_LD) $(DEBUGFLAGS_LD) >>> > --zstd : LDLIBS += $(ZLIBLD) $(LZMALD) $(LZ4LD) >>> > --zstd : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) >>> > -+zstd$(EXT) : CPPFLAGS += $(THREAD_CPP) $(ZLIBCPP) $(LZMACPP) >>> $(LZ4CPP) >>> > -+zstd$(EXT) : LDFLAGS += $(THREAD_LD) $(DEBUGFLAGS_LD) >>> > -+zstd$(EXT) : LDLIBS += $(ZLIBLD) $(LZMALD) $(LZ4LD) >>> > -+zstd$(EXT) : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) >>> > - ifneq (,$(filter Windows%,$(OS))) >>> > --zstd : $(RES_FILE) >>> > -+zstd$(EXT) : $(RES_FILE) >>> > - endif >>> > - >>> > - ifndef BUILD_DIR >>> > - # generate BUILD_DIR from flags >>> > - >>> > --zstd: >>> > -+zstd$(EXT): >>> > - $(SET_CACHE_DIRECTORY) >>> > - >>> > - else >>> > - # BUILD_DIR is defined >>> > - >>> > - ZSTD_OBJ := $(addprefix $(BUILD_DIR)/, $(ZSTD_ALL_OBJ)) >>> > --$(BUILD_DIR)/zstd : $(ZSTD_OBJ) >>> > -+$(BUILD_DIR)/zstd$(EXT) : $(ZSTD_OBJ) >>> > - @echo "$(THREAD_MSG)" >>> > - @echo "$(ZLIB_MSG)" >>> > - @echo "$(LZMA_MSG)" >>> > - @echo "$(LZ4_MSG)" >>> > - @echo LINK $@ >>> > -- $(CC) $(FLAGS) $^ $(LDLIBS) -o $@$(EXT) >>> > -+ $(CC) $(FLAGS) $^ $(LDLIBS) -o $@ >>> > - >>> > - ifeq ($(HAVE_HASH),1) >>> > - SRCBIN_HASH = $(shell cat $(BUILD_DIR)/zstd 2> $(VOID) | $(HASH) | >>> cut -f 1 -d " ") >>> > -@@ -249,7 +249,7 @@ else >>> > - BIN_ISDIFFERENT = 1 >>> > - endif >>> > - >>> > --zstd : $(BUILD_DIR)/zstd >>> > -+zstd$(EXT) : $(BUILD_DIR)/zstd$(EXT) >>> > - if [ $(BIN_ISDIFFERENT) -eq 1 ]; then \ >>> > - cp -f $< $@; \ >>> > - echo zstd build completed; \ >>> > -@@ -263,46 +263,46 @@ endif # BUILD_DIR >>> > - .PHONY: zstd-release >>> > - zstd-release: DEBUGFLAGS := -DBACKTRACE_ENABLE=0 >>> > - zstd-release: DEBUGFLAGS_LD := >>> > --zstd-release: zstd >>> > -+zstd-release: zstd$(EXT) >>> > - >>> > --zstd32 : CPPFLAGS += $(THREAD_CPP) >>> > --zstd32 : LDFLAGS += $(THREAD_LD) >>> > --zstd32 : CPPFLAGS += -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) >>> > -+zstd32$(EXT) : CPPFLAGS += $(THREAD_CPP) >>> > -+zstd32$(EXT) : LDFLAGS += $(THREAD_LD) >>> > -+zstd32$(EXT) : CPPFLAGS += >>> -DZSTD_LEGACY_SUPPORT=$(ZSTD_LEGACY_SUPPORT) >>> > - ifneq (,$(filter Windows%,$(OS))) >>> > --zstd32 : $(RES32_FILE) >>> > -+zstd32$(EXT) : $(RES32_FILE) >>> > - endif >>> > --zstd32 : $(ZSTDLIB_FULL_SRC) $(ZSTD_CLI_SRC) >>> > -- $(CC) -m32 $(FLAGS) $^ -o $@$(EXT) >>> > -+zstd32$(EXT) : $(ZSTDLIB_FULL_SRC) $(ZSTD_CLI_SRC) >>> > -+ $(CC) -m32 $(FLAGS) $^ -o $@ >>> > - >>> > - ## zstd-nolegacy: same scope as zstd, with just support of legacy >>> formats removed >>> > --zstd-nolegacy : LDFLAGS += $(THREAD_LD) $(ZLIBLD) $(LZMALD) $(LZ4LD) >>> $(DEBUGFLAGS_LD) >>> > --zstd-nolegacy : $(ZSTDLIB_CORE_SRC) $(ZDICT_SRC) $(ZSTD_CLI_OBJ) >>> > -- $(CC) $(FLAGS) $^ -o $@$(EXT) $(LDFLAGS) >>> > -+zstd-nolegacy$(EXT) : LDFLAGS += $(THREAD_LD) $(ZLIBLD) $(LZMALD) >>> $(LZ4LD) $(DEBUGFLAGS_LD) >>> > -+zstd-nolegacy$(EXT) : $(ZSTDLIB_CORE_SRC) $(ZDICT_SRC) >>> $(ZSTD_CLI_OBJ) >>> > -+ $(CC) $(FLAGS) $^ -o $@ $(LDFLAGS) >>> > - >>> > - .PHONY: zstd-nomt >>> > - zstd-nomt : THREAD_CPP := >>> > - zstd-nomt : THREAD_LD := >>> > - zstd-nomt : THREAD_MSG := - multi-threading disabled >>> > --zstd-nomt : zstd >>> > -+zstd-nomt : zstd$(EXT) >>> > - >>> > - .PHONY: zstd-nogz >>> > - zstd-nogz : ZLIBCPP := >>> > - zstd-nogz : ZLIBLD := >>> > - zstd-nogz : ZLIB_MSG := - gzip support is disabled >>> > --zstd-nogz : zstd >>> > -+zstd-nogz : zstd$(EXT) >>> > - >>> > - .PHONY: zstd-noxz >>> > - zstd-noxz : LZMACPP := >>> > - zstd-noxz : LZMALD := >>> > - zstd-noxz : LZMA_MSG := - xz/lzma support is disabled >>> > --zstd-noxz : zstd >>> > -+zstd-noxz : zstd$(EXT) >>> > - >>> > - ## zstd-dll: zstd executable linked to dynamic library libzstd (must >>> have same version) >>> > - .PHONY: zstd-dll >>> > - zstd-dll : LDFLAGS+= -L$(ZSTDDIR) >>> > - zstd-dll : LDLIBS += -lzstd >>> > - zstd-dll : ZSTDLIB_LOCAL_SRC = xxhash.c >>> > --zstd-dll : zstd >>> > -+zstd-dll : zstd$(EXT) >>> > - >>> > - >>> > - ## zstd-pgo: zstd executable optimized with PGO. >>> > -@@ -321,23 +321,23 @@ zstd-pgo : >>> > - $(MAKE) zstd MOREFLAGS=-fprofile-use >>> > - >>> > - ## zstd-small: minimal target, supporting only zstd compression and >>> decompression. no bench. no legacy. no other format. >>> > --zstd-small: CFLAGS = -Os -s >>> > --zstd-frugal zstd-small: $(ZSTDLIB_CORE_SRC) zstdcli.c util.c >>> timefn.c fileio.c >>> > -- $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZSTD_NOTRACE $^ >>> -o $@$(EXT) >>> > -+zstd-small$(EXT): CFLAGS = -Os -s >>> > -+zstd-frugal$(EXT) zstd-small$(EXT): $(ZSTDLIB_CORE_SRC) zstdcli.c >>> util.c timefn.c fileio.c >>> > -+ $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZSTD_NOTRACE $^ >>> -o $@ >>> > - >>> > --zstd-decompress: $(ZSTDLIB_COMMON_C) $(ZSTDLIB_DECOMPRESS_C) >>> zstdcli.c util.c timefn.c fileio.c >>> > -- $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZSTD_NOCOMPRESS >>> -DZSTD_NOTRACE $^ -o $@$(EXT) >>> > -+zstd-decompress$(EXT): $(ZSTDLIB_COMMON_C) $(ZSTDLIB_DECOMPRESS_C) >>> zstdcli.c util.c timefn.c fileio.c >>> > -+ $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZSTD_NOCOMPRESS >>> -DZSTD_NOTRACE $^ -o $@ >>> > - >>> > --zstd-compress: $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) zstdcli.c >>> util.c timefn.c fileio.c >>> > -- $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT >>> -DZSTD_NODECOMPRESS -DZSTD_NOTRACE $^ -o $@$(EXT) >>> > -+zstd-compress$(EXT): $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) >>> zstdcli.c util.c timefn.c fileio.c >>> > -+ $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT >>> -DZSTD_NODECOMPRESS -DZSTD_NOTRACE $^ -o $@ >>> > - >>> > - ## zstd-dictBuilder: executable supporting dictionary creation and >>> compression (only) >>> > --zstd-dictBuilder: CPPFLAGS += -DZSTD_NOBENCH -DZSTD_NODECOMPRESS >>> -DZSTD_NOTRACE >>> > --zstd-dictBuilder: $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) >>> $(ZDICT_SRC) zstdcli.c util.c timefn.c fileio.c dibio.c >>> > -- $(CC) $(FLAGS) $^ -o $@$(EXT) >>> > -+zstd-dictBuilder$(EXT): CPPFLAGS += -DZSTD_NOBENCH >>> -DZSTD_NODECOMPRESS -DZSTD_NOTRACE >>> > -+zstd-dictBuilder$(EXT): $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) >>> $(ZDICT_SRC) zstdcli.c util.c timefn.c fileio.c dibio.c >>> > -+ $(CC) $(FLAGS) $^ -o $@ >>> > - >>> > --zstdmt: zstd >>> > -- ln -sf zstd zstdmt >>> > -+zstdmt$(EXT): zstd$(EXT) >>> > -+ ln -sf zstd$(EXT) zstdmt$(EXT) >>> > - >>> > - .PHONY: generate_res >>> > - generate_res: $(RES64_FILE) $(RES32_FILE) >>> > --- >>> > -2.31.1 >>> > - >>> > diff --git a/meta/recipes-extended/zstd/zstd_1.5.0.bb >>> b/meta/recipes-extended/zstd/zstd_1.5.2.bb >>> > similarity index 86% >>> > rename from meta/recipes-extended/zstd/zstd_1.5.0.bb >>> > rename to meta/recipes-extended/zstd/zstd_1.5.2.bb >>> > index 51305d0562..71f439ef57 100644 >>> > --- a/meta/recipes-extended/zstd/zstd_1.5.0.bb >>> > +++ b/meta/recipes-extended/zstd/zstd_1.5.2.bb >>> > @@ -9,12 +9,9 @@ LICENSE = "BSD-3-Clause & GPLv2" >>> > LIC_FILES_CHKSUM = >>> "file://LICENSE;md5=c7f0b161edbe52f5f345a3d1311d0b32 \ >>> > >>> file://COPYING;md5=39bba7d2cf0ba1036f2a6e2be52fe3f0" >>> > >>> > -SRC_URI = "git:// >>> github.com/facebook/zstd.git;branch=release;protocol=https \ >>> > - >>> file://0001-Makefile-sort-all-wildcard-file-list-expansions.patch \ >>> > - file://0001-MinGW-Build-Fixes.patch \ >>> > - " >>> > +SRC_URI = "git:// >>> github.com/facebook/zstd.git;branch=release;protocol=https" >>> > >>> > -SRCREV = "a488ba114ec17ea1054b9057c26a046fc122b3b6" >>> > +SRCREV = "e47e674cd09583ff0503f0f6defd6d23d8b718d3" >>> > UPSTREAM_CHECK_GITTAGREGEX = "v(?P\d+(\.\d+)+)" >>> > >>> > CVE_PRODUCT = "zstandard" >>> > -- >>> > 2.20.1 >>> > >>> > >>> > >>> > >>> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> > View/Reply Online (#161053): >> https://lists.openembedded.org/g/openembedded-core/message/161053 >> Mute This Topic: https://lists.openembedded.org/mt/88718362/1686489 >> Group Owner: openembedded-core+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ >> alex.kanavin@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >> --000000000000e1c58605d696a0e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jan 27, 2022 at 12:10 PM Alexander Kanavin <alex.kanavin@gmail.com> wrote:=
I think zstd= changelog for 1.5.1 settles the issue:


Yeah indeed

=C2=A0thanks=C2=A0

Alex
<= /div>

On Thu, 27 Jan 2022 at 20:51, Alexander Kanavin via lists.openembedded.org <al= ex.kanavin=3Dgmail.com@lists.openembedded.org> wrote:
On Thu, 27 Jan 2022 at 19:56= , Khem Raj <raj.= khem@gmail.com> wrote:
quick look shows that size of zstd package reduces quite a bi= t, I wonder why

=C2=A0 -4720=C2=A0 =C2=A0KiB zstd
=C2=A0 +2932=C2=A0 =C2=A0KiB zstd

small is ofcourse better, but I wonder what could reduce it so much
between 1.5.0 and 1.5.2

buildhistory-di= ff does not reveal anything fishy:

alex@nereus:~/d= evelopment/poky/build-64-alt$ buildhistory-diff
Changes to packages/core= 2-64-poky-linux/zstd (sysroot):
=C2=A0 /usr/lib/libzstd.so.1 changed sym= link target from libzstd.so.1.5.0 to libzstd.so.1.5.2
=C2=A0 /usr/lib/li= bzstd.so changed symlink target from libzstd.so.1.5.0 to libzstd.so.1.5.2=C2=A0 /usr/lib/libzstd.so.1.5.0 moved to /usr/lib/libzstd.so.1.5.2
pa= ckages/core2-64-poky-linux/zstd/zstd-dbg: PKGSIZE changed from 23736192 to = 16994448 (-28%)
packages/core2-64-poky-linux/zstd/zstd-src: PKGSIZE chan= ged from 2741079 to 3050284 (+11%)
packages/core2-64-poky-linux/zstd/zst= d-staticdev: PKGSIZE changed from 9332966 to 6596796 (-29%)
packages/cor= e2-64-poky-linux/zstd/zstd: PKGSIZE changed from 3279119 to 2407719 (-27%)<= br>packages/core2-64-poky-linux/zstd/zstd: FILELIST: removed "/usr/lib= /libzstd.so.1.5.0", added "/usr/lib/libzstd.so.1.5.2"
Cha= nges to packages/x86_64-linux/zstd-native (sysroot):
=C2=A0 /usr/lib/lib= zstd.so.1 changed symlink target from libzstd.so.1.5.0 to libzstd.so.1.5.2<= br>=C2=A0 /usr/lib/libzstd.so changed symlink target from libzstd.so.1.5.0 = to libzstd.so.1.5.2
=C2=A0 /usr/lib/libzstd.so.1.5.0 moved to /usr/lib/l= ibzstd.so.1.5.2

Alex

=
=C2=A0
=
On Thu, Jan 27, 2022 at 2:20 AM Alexander Kanavin
<alex.kanavi= n@gmail.com> wrote:
>
> Drop patches merged upstream.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>=C2=A0 ...rt-all-wildcard-file-list-expansions.patch |=C2=A0 81 -------= -
>=C2=A0 .../zstd/zstd/0001-MinGW-Build-Fixes.patch=C2=A0 =C2=A0 | 193 --= ----------------
>=C2=A0 .../zstd/{zstd_1.5.0.bb =3D> zstd_1.5.2.bb}=C2=A0 =C2=A0 =C2=A0= |=C2=A0 =C2=A07 +-
>=C2=A0 3 files changed, 2 insertions(+), 279 deletions(-)
>=C2=A0 delete mode 100644 meta/recipes-extended/zstd/zstd/0001-Makefile= -sort-all-wildcard-file-list-expansions.patch
>=C2=A0 delete mode 100644 meta/recipes-extended/zstd/zstd/0001-MinGW-Bu= ild-Fixes.patch
>=C2=A0 rename meta/recipes-extended/zstd/{zstd_1.5.0.bb =3D> zstd_1.5.2.b= b} (86%)
>
> diff --git a/meta/recipes-extended/zstd/zstd/0001-Makefile-sort-all-wi= ldcard-file-list-expansions.patch b/meta/recipes-extended/zstd/zstd/0001-Ma= kefile-sort-all-wildcard-file-list-expansions.patch
> deleted file mode 100644
> index 3d23648f5b..0000000000
> --- a/meta/recipes-extended/zstd/zstd/0001-Makefile-sort-all-wildcard-= file-list-expansions.patch
> +++ /dev/null
> @@ -1,81 +0,0 @@
> -From 77c7963c7a0f1c455f20520d5c7b1ec9b17a44fb Mon Sep 17 00:00:00 200= 1
> -From: Alexander Kanavin <alex.kanavin@gmail.com>
> -Date: Wed, 23 Dec 2020 19:14:32 +0100
> -Subject: [PATCH] Makefile: sort all wildcard file list expansions
> -
> -Otherwise the order is non-deterministic and breaks
> -reproducible builds.
> -
> -Upstream-Status: Submitted [https://github.com/faceb= ook/zstd/pull/2895]
> -Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> -
> ----
> - programs/Makefile=C2=A0 =C2=A0| 10 +++++-----
> - tests/Makefile=C2=A0 =C2=A0 =C2=A0 |=C2=A0 4 ++--
> - tests/fuzz/Makefile |=C2=A0 2 +-
> - 3 files changed, 8 insertions(+), 8 deletions(-)
> -
> -diff --git a/programs/Makefile b/programs/Makefile
> -index 599fb02f..2c416467 100644
> ---- a/programs/Makefile
> -+++ b/programs/Makefile
> -@@ -74,11 +74,11 @@ ZSTDLEGACY_DIR :=3D $(ZSTDDIR)/legacy
> -
> - vpath %.c $(ZSTDLIB_COMMON) $(ZSTDLIB_COMPRESS) $(ZSTDLIB_DECOMPRESS= ) $(ZDICT_DIR) $(ZSTDLEGACY_DIR)
> -
> --ZSTDLIB_COMMON_C :=3D $(wildcard $(ZSTDLIB_COMMON)/*.c)
> --ZSTDLIB_COMPRESS_C :=3D $(wildcard $(ZSTDLIB_COMPRESS)/*.c)
> --ZSTDLIB_DECOMPRESS_C :=3D $(wildcard $(ZSTDLIB_DECOMPRESS)/*.c)
> -+ZSTDLIB_COMMON_C :=3D $(sort $(wildcard $(ZSTDLIB_COMMON)/*.c))
> -+ZSTDLIB_COMPRESS_C :=3D $(sort $(wildcard $(ZSTDLIB_COMPRESS)/*.c))<= br> > -+ZSTDLIB_DECOMPRESS_C :=3D $(sort $(wildcard $(ZSTDLIB_DECOMPRESS)/*.= c))
> - ZSTDLIB_CORE_SRC :=3D $(ZSTDLIB_DECOMPRESS_C) $(ZSTDLIB_COMMON_C) $(= ZSTDLIB_COMPRESS_C)
> --ZDICT_SRC :=3D $(wildcard $(ZDICT_DIR)/*.c)
> -+ZDICT_SRC :=3D $(sort $(wildcard $(ZDICT_DIR)/*.c))
> -
> - ZSTD_LEGACY_SUPPORT ?=3D 5
> - ZSTDLEGACY_SRC :=3D
> -@@ -93,7 +93,7 @@ ZSTDLIB_FULL_SRC =3D $(sort $(ZSTDLIB_CORE_SRC) $(Z= STDLEGACY_SRC) $(ZDICT_SRC))
> - ZSTDLIB_LOCAL_SRC =3D $(notdir $(ZSTDLIB_FULL_SRC))
> - ZSTDLIB_LOCAL_OBJ :=3D $(ZSTDLIB_LOCAL_SRC:.c=3D.o)
> -
> --ZSTD_CLI_SRC :=3D $(wildcard *.c)
> -+ZSTD_CLI_SRC :=3D $(sort $(wildcard *.c))
> - ZSTD_CLI_OBJ :=3D $(ZSTD_CLI_SRC:.c=3D.o)
> -
> - ZSTD_ALL_SRC =3D $(ZSTDLIB_LOCAL_SRC) $(ZSTD_CLI_SRC)
> -diff --git a/tests/Makefile b/tests/Makefile
> -index 85553007..b71cdba8 100644
> ---- a/tests/Makefile
> -+++ b/tests/Makefile
> -@@ -49,7 +49,7 @@ ZSTDDECOMP_FILES :=3D $(ZSTDDIR)/decompress/*.c
> - ZSTD_FILES=C2=A0 :=3D $(ZSTDDECOMP_FILES) $(ZSTDCOMMON_FILES) $(ZSTD= COMP_FILES)
> - ZDICT_FILES :=3D $(ZSTDDIR)/dictBuilder/*.c
> -
> --ZSTD_F1 :=3D $(wildcard $(ZSTD_FILES))
> -+ZSTD_F1 :=3D $(sort $(wildcard $(ZSTD_FILES)))
> - ZSTD_OBJ1 :=3D $(subst $(ZSTDDIR)/common/,zstdm_,$(ZSTD_F1))
> - ZSTD_OBJ2 :=3D $(subst $(ZSTDDIR)/compress/,zstdc_,$(ZSTD_OBJ1))
> - ZSTD_OBJ3 :=3D $(subst $(ZSTDDIR)/decompress/,zstdd_,$(ZSTD_OBJ2)) > -@@ -202,7 +202,7 @@ bigdict: $(ZSTDMT_OBJECTS) $(PRGDIR)/datagen.c bi= gdict.c
> - invalidDictionaries : $(ZSTD_OBJECTS) invalidDictionaries.c
> -
> - legacy : CPPFLAGS +=3D -I$(ZSTDDIR)/legacy -DZSTD_LEGACY_SUPPORT=3D4=
> --legacy : $(ZSTD_FILES) $(wildcard $(ZSTDDIR)/legacy/*.c) legacy.c > -+legacy : $(ZSTD_FILES) $(sort $(wildcard $(ZSTDDIR)/legacy/*.c)) leg= acy.c
> -
> - decodecorpus : LDLIBS +=3D -lm
> - decodecorpus : $(filter-out zstdc_zstd_compress.o, $(ZSTD_OBJECTS)) = $(ZDICT_FILES) $(PRGDIR)/util.c $(PRGDIR)/timefn.c decodecorpus.c
> -diff --git a/tests/fuzz/Makefile b/tests/fuzz/Makefile
> -index ccb574b7..b1cb2935 100644
> ---- a/tests/fuzz/Makefile
> -+++ b/tests/fuzz/Makefile
> -@@ -62,7 +62,7 @@ FUZZ_SRC=C2=A0 =C2=A0 =C2=A0 =C2=A0:=3D \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0$(ZSTDCOMP_SRC) \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0$(ZSTDDICT_SRC) \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0$(ZSTDLEGACY_SRC)
> --FUZZ_SRC :=3D $(wildcard $(FUZZ_SRC))
> -+FUZZ_SRC :=3D $(sort $(wildcard $(FUZZ_SRC)))
> -
> - FUZZ_D_OBJ1 :=3D $(subst $(ZSTDDIR)/common/,d_lib_common_,$(FUZZ_SRC= ))
> - FUZZ_D_OBJ2 :=3D $(subst $(ZSTDDIR)/compress/,d_lib_compress_,$(FUZZ= _D_OBJ1))
> diff --git a/meta/recipes-extended/zstd/zstd/0001-MinGW-Build-Fixes.pa= tch b/meta/recipes-extended/zstd/zstd/0001-MinGW-Build-Fixes.patch
> deleted file mode 100644
> index a0e00dca03..0000000000
> --- a/meta/recipes-extended/zstd/zstd/0001-MinGW-Build-Fixes.patch
> +++ /dev/null
> @@ -1,193 +0,0 @@
> -From ab9a34c92eec815ef214470c927ddbe2e950e7e5 Mon Sep 17 00:00:00 200= 1
> -From: Joshua Watt <JPEWhacker@gmail.com>
> -Date: Wed, 26 May 2021 09:15:40 -0500
> -Subject: [PATCH] MinGW Build Fixes
> -
> -Fixes building on MinGW by
> - 1) Exporting the OS variable so that it is visible to sub-make
> -=C2=A0 =C2=A0 invocations
> - 2) Fixing the extension handling so that make correctly identifies w= hen
> -=C2=A0 =C2=A0 targets need to be rebuilt. Without the correct handlin= g, make would
> -=C2=A0 =C2=A0 rebuild the executable targets when running `make insta= ll` because
> -=C2=A0 =C2=A0 it couldn't find them with the correct extension. > -
> -Upstream-Status: Submitted [https://github.com/faceb= ook/zstd/pull/2685]
> -Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ----
> - Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 1 +
> - programs/Makefile | 74 +++++++++++++++++++++++----------------------= --
> - 2 files changed, 38 insertions(+), 37 deletions(-)
> -
> -diff --git a/Makefile b/Makefile
> -index c1908f0a..f9ce9504 100644
> ---- a/Makefile
> -+++ b/Makefile
> -@@ -29,6 +29,7 @@ VOID =3D /dev/null
> - # fail on other tested distros (ubuntu, debian) even
> - # without manually specifying the TARGET_SYSTEM.
> - TARGET_SYSTEM ?=3D $(OS)
> -+export OS
> -
> - ifneq (,$(filter Windows%,$(TARGET_SYSTEM)))
> -=C2=A0 =C2=A0EXT =3D.exe
> -diff --git a/programs/Makefile b/programs/Makefile
> -index 599fb02f..79b45c83 100644
> ---- a/programs/Makefile
> -+++ b/programs/Makefile
> -@@ -209,37 +209,37 @@ SET_CACHE_DIRECTORY =3D \
> -
> -
> - .PHONY: all
> --all: zstd
> -+all: zstd$(EXT)
> -
> - .PHONY: allVariants
> --allVariants: zstd zstd-compress zstd-decompress zstd-small zstd-nole= gacy zstd-dictBuilder
> -+allVariants: zstd$(EXT) zstd-compress$(EXT) zstd-decompress$(EXT) zs= td-small$(EXT) zstd-nolegacy$(EXT) zstd-dictBuilder$(EXT)
> -
> - .PHONY: zstd=C2=A0 # must always be run
> --zstd : CPPFLAGS +=3D $(THREAD_CPP) $(ZLIBCPP) $(LZMACPP) $(LZ4CPP) > --zstd : LDFLAGS +=3D $(THREAD_LD) $(DEBUGFLAGS_LD)
> --zstd : LDLIBS +=3D $(ZLIBLD) $(LZMALD) $(LZ4LD)
> --zstd : CPPFLAGS +=3D -DZSTD_LEGACY_SUPPORT=3D$(ZSTD_LEGACY_SUPPORT)<= br> > -+zstd$(EXT) : CPPFLAGS +=3D $(THREAD_CPP) $(ZLIBCPP) $(LZMACPP) $(LZ4= CPP)
> -+zstd$(EXT) : LDFLAGS +=3D $(THREAD_LD) $(DEBUGFLAGS_LD)
> -+zstd$(EXT) : LDLIBS +=3D $(ZLIBLD) $(LZMALD) $(LZ4LD)
> -+zstd$(EXT) : CPPFLAGS +=3D -DZSTD_LEGACY_SUPPORT=3D$(ZSTD_LEGACY_SUP= PORT)
> - ifneq (,$(filter Windows%,$(OS)))
> --zstd : $(RES_FILE)
> -+zstd$(EXT) : $(RES_FILE)
> - endif
> -
> - ifndef BUILD_DIR
> - # generate BUILD_DIR from flags
> -
> --zstd:
> -+zstd$(EXT):
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0$(SET_CACHE_DIRECTORY)
> -
> - else
> - # BUILD_DIR is defined
> -
> - ZSTD_OBJ :=3D $(addprefix $(BUILD_DIR)/, $(ZSTD_ALL_OBJ))
> --$(BUILD_DIR)/zstd : $(ZSTD_OBJ)
> -+$(BUILD_DIR)/zstd$(EXT) : $(ZSTD_OBJ)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0@echo "$(THREAD_MSG)"
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0@echo "$(ZLIB_MSG)"
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0@echo "$(LZMA_MSG)"
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0@echo "$(LZ4_MSG)"
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0@echo LINK $@
> --=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) $^ $(LDLIBS) -o $@$(EXT)
> -+=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) $^ $(LDLIBS) -o $@
> -
> - ifeq ($(HAVE_HASH),1)
> - SRCBIN_HASH =3D $(shell cat $(BUILD_DIR)/zstd 2> $(VOID) | $(HASH= ) | cut -f 1 -d " ")
> -@@ -249,7 +249,7 @@ else
> - BIN_ISDIFFERENT =3D 1
> - endif
> -
> --zstd : $(BUILD_DIR)/zstd
> -+zstd$(EXT) : $(BUILD_DIR)/zstd$(EXT)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0if [ $(BIN_ISDIFFERENT) -eq 1 ]; then \ > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cp -f $< $@= ; \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0echo zstd buil= d completed; \
> -@@ -263,46 +263,46 @@ endif=C2=A0 # BUILD_DIR
> - .PHONY: zstd-release
> - zstd-release: DEBUGFLAGS :=3D -DBACKTRACE_ENABLE=3D0
> - zstd-release: DEBUGFLAGS_LD :=3D
> --zstd-release: zstd
> -+zstd-release: zstd$(EXT)
> -
> --zstd32 : CPPFLAGS +=3D $(THREAD_CPP)
> --zstd32 : LDFLAGS=C2=A0 +=3D $(THREAD_LD)
> --zstd32 : CPPFLAGS +=3D -DZSTD_LEGACY_SUPPORT=3D$(ZSTD_LEGACY_SUPPORT= )
> -+zstd32$(EXT) : CPPFLAGS +=3D $(THREAD_CPP)
> -+zstd32$(EXT) : LDFLAGS=C2=A0 +=3D $(THREAD_LD)
> -+zstd32$(EXT) : CPPFLAGS +=3D -DZSTD_LEGACY_SUPPORT=3D$(ZSTD_LEGACY_S= UPPORT)
> - ifneq (,$(filter Windows%,$(OS)))
> --zstd32 : $(RES32_FILE)
> -+zstd32$(EXT) : $(RES32_FILE)
> - endif
> --zstd32 : $(ZSTDLIB_FULL_SRC) $(ZSTD_CLI_SRC)
> --=C2=A0 =C2=A0 =C2=A0 $(CC) -m32 $(FLAGS) $^ -o $@$(EXT)
> -+zstd32$(EXT) : $(ZSTDLIB_FULL_SRC) $(ZSTD_CLI_SRC)
> -+=C2=A0 =C2=A0 =C2=A0 $(CC) -m32 $(FLAGS) $^ -o $@
> -
> - ## zstd-nolegacy: same scope as zstd, with just support of legacy fo= rmats removed
> --zstd-nolegacy : LDFLAGS +=3D $(THREAD_LD) $(ZLIBLD) $(LZMALD) $(LZ4L= D) $(DEBUGFLAGS_LD)
> --zstd-nolegacy : $(ZSTDLIB_CORE_SRC) $(ZDICT_SRC) $(ZSTD_CLI_OBJ)
> --=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) $^ -o $@$(EXT) $(LDFLAGS)
> -+zstd-nolegacy$(EXT) : LDFLAGS +=3D $(THREAD_LD) $(ZLIBLD) $(LZMALD) = $(LZ4LD) $(DEBUGFLAGS_LD)
> -+zstd-nolegacy$(EXT) : $(ZSTDLIB_CORE_SRC) $(ZDICT_SRC) $(ZSTD_CLI_OB= J)
> -+=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) $^ -o $@ $(LDFLAGS)
> -
> - .PHONY: zstd-nomt
> - zstd-nomt : THREAD_CPP :=3D
> - zstd-nomt : THREAD_LD=C2=A0 :=3D
> - zstd-nomt : THREAD_MSG :=3D - multi-threading disabled
> --zstd-nomt : zstd
> -+zstd-nomt : zstd$(EXT)
> -
> - .PHONY: zstd-nogz
> - zstd-nogz : ZLIBCPP :=3D
> - zstd-nogz : ZLIBLD=C2=A0 :=3D
> - zstd-nogz : ZLIB_MSG :=3D - gzip support is disabled
> --zstd-nogz : zstd
> -+zstd-nogz : zstd$(EXT)
> -
> - .PHONY: zstd-noxz
> - zstd-noxz : LZMACPP :=3D
> - zstd-noxz : LZMALD=C2=A0 :=3D
> - zstd-noxz : LZMA_MSG :=3D - xz/lzma support is disabled
> --zstd-noxz : zstd
> -+zstd-noxz : zstd$(EXT)
> -
> - ## zstd-dll: zstd executable linked to dynamic library libzstd (must= have same version)
> - .PHONY: zstd-dll
> - zstd-dll : LDFLAGS+=3D -L$(ZSTDDIR)
> - zstd-dll : LDLIBS +=3D -lzstd
> - zstd-dll : ZSTDLIB_LOCAL_SRC =3D xxhash.c
> --zstd-dll : zstd
> -+zstd-dll : zstd$(EXT)
> -
> -
> - ## zstd-pgo: zstd executable optimized with PGO.
> -@@ -321,23 +321,23 @@ zstd-pgo :
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0$(MAKE) zstd MOREFLAGS=3D-fprofile-use
> -
> - ## zstd-small: minimal target, supporting only zstd compression and = decompression. no bench. no legacy. no other format.
> --zstd-small: CFLAGS =3D -Os -s
> --zstd-frugal zstd-small: $(ZSTDLIB_CORE_SRC) zstdcli.c util.c timefn.= c fileio.c
> --=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZ= STD_NOTRACE $^ -o $@$(EXT)
> -+zstd-small$(EXT): CFLAGS =3D -Os -s
> -+zstd-frugal$(EXT) zstd-small$(EXT): $(ZSTDLIB_CORE_SRC) zstdcli.c ut= il.c timefn.c fileio.c
> -+=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZ= STD_NOTRACE $^ -o $@
> -
> --zstd-decompress: $(ZSTDLIB_COMMON_C) $(ZSTDLIB_DECOMPRESS_C) zstdcli= .c util.c timefn.c fileio.c
> --=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZ= STD_NOCOMPRESS -DZSTD_NOTRACE $^ -o $@$(EXT)
> -+zstd-decompress$(EXT): $(ZSTDLIB_COMMON_C) $(ZSTDLIB_DECOMPRESS_C) z= stdcli.c util.c timefn.c fileio.c
> -+=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZ= STD_NOCOMPRESS -DZSTD_NOTRACE $^ -o $@
> -
> --zstd-compress: $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) zstdcli.c u= til.c timefn.c fileio.c
> --=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZ= STD_NODECOMPRESS -DZSTD_NOTRACE $^ -o $@$(EXT)
> -+zstd-compress$(EXT): $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) zstdc= li.c util.c timefn.c fileio.c
> -+=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) -DZSTD_NOBENCH -DZSTD_NODICT -DZ= STD_NODECOMPRESS -DZSTD_NOTRACE $^ -o $@
> -
> - ## zstd-dictBuilder: executable supporting dictionary creation and c= ompression (only)
> --zstd-dictBuilder: CPPFLAGS +=3D -DZSTD_NOBENCH -DZSTD_NODECOMPRESS -= DZSTD_NOTRACE
> --zstd-dictBuilder: $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) $(ZDICT_= SRC) zstdcli.c util.c timefn.c fileio.c dibio.c
> --=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) $^ -o $@$(EXT)
> -+zstd-dictBuilder$(EXT): CPPFLAGS +=3D -DZSTD_NOBENCH -DZSTD_NODECOMP= RESS -DZSTD_NOTRACE
> -+zstd-dictBuilder$(EXT): $(ZSTDLIB_COMMON_C) $(ZSTDLIB_COMPRESS_C) $(= ZDICT_SRC) zstdcli.c util.c timefn.c fileio.c dibio.c
> -+=C2=A0 =C2=A0 =C2=A0 $(CC) $(FLAGS) $^ -o $@
> -
> --zstdmt: zstd
> --=C2=A0 =C2=A0 =C2=A0 ln -sf zstd zstdmt
> -+zstdmt$(EXT): zstd$(EXT)
> -+=C2=A0 =C2=A0 =C2=A0 ln -sf zstd$(EXT) zstdmt$(EXT)
> -
> - .PHONY: generate_res
> - generate_res: $(RES64_FILE) $(RES32_FILE)
> ---
> -2.31.1
> -
> diff --git a/meta/recipes-extended/zstd/zstd_1.5.0.bb b/meta/recipes-ex= tended/zstd/zstd_1.5.2.bb
> similarity index 86%
> rename from meta/recipes-extended/zstd/zstd_1.5.0.bb
> rename to meta/recipes-extended/zstd/zstd_1.5.2.bb
> index 51305d0562..71f439ef57 100644
> --- a/meta/recipes-extended/zstd/zstd_1.5.0.bb
> +++ b/meta/recipes-extended/zstd/zstd_1.5.2.bb
> @@ -9,12 +9,9 @@ LICENSE =3D "BSD-3-Clause & GPLv2"
>=C2=A0 LIC_FILES_CHKSUM =3D "file://LICENSE;md5=3Dc7f0b161edbe52f5= f345a3d1311d0b32 \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 file://COPYING;md5=3D39bba7d2cf0ba1036f2a6e2be52fe3f0"
>
> -SRC_URI =3D "git://g= ithub.com/facebook/zstd.git;branch=3Drelease;protocol=3Dhttps \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0file://0001-Makefile-sort-al= l-wildcard-file-list-expansions.patch \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0file://0001-MinGW-Build-Fixe= s.patch \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"
> +SRC_URI =3D "git://g= ithub.com/facebook/zstd.git;branch=3Drelease;protocol=3Dhttps"
>
> -SRCREV =3D "a488ba114ec17ea1054b9057c26a046fc122b3b6"
> +SRCREV =3D "e47e674cd09583ff0503f0f6defd6d23d8b718d3"
>=C2=A0 UPSTREAM_CHECK_GITTAGREGEX =3D "v(?P<pver>\d+(\.\d+)+= )"
>
>=C2=A0 CVE_PRODUCT =3D "zstandard"
> --
> 2.20.1
>
>
>
>

-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-
Links: You receive all messages sent to this group.
<= div class=3D"gmail_quote">
View/Reply Online (#161053): https:= //lists.openembedded.org/g/openembedded-core/message/161053
Mute This Topic: https://lists.openembedded.org/mt= /88718362/1686489
Group Owner: openembedded-core+owner@lists.openembedded.org<= br> Unsubscribe: https://lists.openembedded.org/= g/openembedded-core/unsub [alex.kanavin@gmail.com]
-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-

--000000000000e1c58605d696a0e8--