Re: [OE-core] [PATCH] valgrind: Enable network for ptest builds

[Khem Raj <raj.khem@gmail.com>]

On Thu, Jan 13, 2022 at 9:46 AM Konrad Weihmann <kweihmann@outlook.com> wrote:
>
> My understanding is to add
>
> --nonet
>
> to XMLLINT_FLAGS = --noblanks --noout --xinclude --postvalid --noent
>
> in docs/Makefile.in
>
> and we should be good - haven't tried it yet but it should do the trick

right, good suggestion but it did not work originally thats why this patch.

>
> On 13.01.22 18:39, Alexander Kanavin wrote:
> > Why wasn't this exposed by AB testing? And can there be a better
> > solution (e.g. skip the validation step), since this would still break
> > on hosts without internet.
> >
> > Alex
> >
> > On Thu, 13 Jan 2022 at 18:36, Khem Raj <raj.khem@gmail.com
> > <mailto:raj.khem@gmail.com>> wrote:
> >
> >     do_compile_ptest_base uses xmllint which accesses internet for
> >     validating DTD
> >
> >     Signed-off-by: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>>
> >     ---
> >       meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
> >     <http://valgrind_3.18.1.bb> | 5 +++++
> >       1 file changed, 5 insertions(+)
> >
> >     diff --git a/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
> >     <http://valgrind_3.18.1.bb>
> >     b/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
> >     <http://valgrind_3.18.1.bb>
> >     index 7837034f92e..5ebcae467fa 100644
> >     --- a/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
> >     <http://valgrind_3.18.1.bb>
> >     +++ b/meta/recipes-devtools/valgrind/valgrind_3.18.1.bb
> >     <http://valgrind_3.18.1.bb>
> >     @@ -98,6 +98,11 @@ CACHED_CONFIGUREVARS +=
> >     "ac_cv_path_PERL='/usr/bin/env perl'"
> >       # which fixes build path issue in DWARF.
> >       SELECTED_OPTIMIZATION = "${DEBUG_FLAGS}"
> >
> >     +# This is needed because xmllint needs access to network to
> >     +# validate DTD 4.3 onwards it uses --dtdvalid
> >     http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd
> >     <http://www.oasis-open.org/docbook/xml/4.3/docbookx.dtd>
> >     +# to xmllint, allow it to access internet
> >     +do_compile_ptest_base[network] = "1"
> >     +
> >       do_configure:prepend () {
> >           rm -rf ${S}/config.h
> >           sed -i -e 's:$(abs_top_builddir):$(pkglibdir)/ptest:g'
> >     ${S}/none/tests/Makefile.am
> >     --
> >     2.34.1
> >
> >
> >
> >
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#160527): https://lists.openembedded.org/g/openembedded-core/message/160527
> > Mute This Topic: https://lists.openembedded.org/mt/88401996/3647476
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kweihmann@outlook.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >