From: Khem Raj <raj.khem@gmail.com>
To: Gianfranco Costamagna <costamagna.gianfranco@gmail.com>
Cc: Gianfranco Costamagna <locutusofborg@debian.org>,
Gianfranco Costamagna <costamagnagianfranco@yahoo.it>,
openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH 2/2] boinc-client: cosmetic changes, such as unifying tabs VS spaces and adding cosmetic newlines
Date: Sat, 25 Jan 2020 08:01:48 -0800 [thread overview]
Message-ID: <CAMKF1srY9dVvaeYLxTFqoXBCb8-UkgO4b6oo3_Fzi-Wvs4LSdA@mail.gmail.com> (raw)
In-Reply-To: <20200125144043.18259-2-costamagnagianfranco@yahoo.it>
On Sat, Jan 25, 2020 at 6:41 AM Gianfranco Costamagna
<costamagna.gianfranco@gmail.com> wrote:
>
patch is fine but commit message summary line is too big, usually we like
summary line ( perhaps < 80 char>
Details summary
see https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Patch Headers and Commit Messages section.
> Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
> Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org>
> ---
> meta-oe/recipes-extended/boinc/boinc-client_7.16.bb | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-extended/boinc/boinc-client_7.16.bb b/meta-oe/recipes-extended/boinc/boinc-client_7.16.bb
> index 0780993db..c52828018 100644
> --- a/meta-oe/recipes-extended/boinc/boinc-client_7.16.bb
> +++ b/meta-oe/recipes-extended/boinc/boinc-client_7.16.bb
> @@ -73,15 +73,16 @@ do_compile_prepend () {
> sed -i -e 's|^sys_lib_dlsearch_path_spec=.*|sys_lib_dlsearch_path_spec=""|g' ${B}/${TARGET_SYS}-libtool
> sed -i -e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' ${B}/${TARGET_SYS}-libtool
> }
> +
> do_install_append() {
> if [ -e ${D}${nonarch_libdir}/systemd/system/boinc-client.service ]; then
> - install -d ${D}${systemd_system_unitdir}
> + install -d ${D}${systemd_system_unitdir}
> mv \
> ${D}${nonarch_libdir}/systemd/system/boinc-client.service \
> ${D}${systemd_system_unitdir}/boinc-client.service
> rmdir --ignore-fail-on-non-empty ${D}${nonarch_libdir}/systemd/system \
> - ${D}${nonarch_libdir}/systemd \
> - ${D}${nonarch_libdir}
> + ${D}${nonarch_libdir}/systemd \
> + ${D}${nonarch_libdir}
> fi
> }
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
prev parent reply other threads:[~2020-01-25 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 14:40 [meta-oe][PATCH 1/2] boinc: update recipe to version 7.16.4 Gianfranco Costamagna
2020-01-25 14:40 ` [meta-oe][PATCH 2/2] boinc-client: cosmetic changes, such as unifying tabs VS spaces and adding cosmetic newlines Gianfranco Costamagna
2020-01-25 16:01 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMKF1srY9dVvaeYLxTFqoXBCb8-UkgO4b6oo3_Fzi-Wvs4LSdA@mail.gmail.com \
--to=raj.khem@gmail.com \
--cc=costamagna.gianfranco@gmail.com \
--cc=costamagnagianfranco@yahoo.it \
--cc=locutusofborg@debian.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.