From: Khem Raj <raj.khem@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] gnutls: rationalise libunistring arguments
Date: Fri, 27 Jul 2018 03:24:06 -0700 [thread overview]
Message-ID: <CAMKF1srcpA0wowvnELw4JSsePBF8V7YtkBkwLMOCyFojenL09w@mail.gmail.com> (raw)
In-Reply-To: <20180723115124.27548-2-ross.burton@intel.com>
On Mon, Jul 23, 2018 at 4:51 AM Ross Burton <ross.burton@intel.com> wrote:
>
> No need to pass --without-libunistring-prefix, and it looks a lot like we're
> trying to disable it.
>
This sneaked in and I did not notice it in the series, but its going
to cause regression
on build machines who installed libunistring on host. Its also because
gnuts is using
non standard AC macro called AC_LIB_HAVE_LINKFLAGS to detect this
library and it seems to be confusing cross builds.
This commit is essentially reverting
http://git.openembedded.org/openembedded-core/commit/?id=ee0b0da237c1661f43e27e26e0ab24b7d8ed174f
which was added to fix the above case. This should be reverted.
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-support/gnutls/gnutls.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
> index 98ec8d9667b..b62a137e595 100644
> --- a/meta/recipes-support/gnutls/gnutls.inc
> +++ b/meta/recipes-support/gnutls/gnutls.inc
> @@ -41,7 +41,6 @@ EXTRA_OECONF = " \
> --enable-local-libopts \
> --enable-openssl-compatibility \
> --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
> - --without-libunistring-prefix \
> "
>
> LDFLAGS_append_libc-musl = " -largp"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2018-07-27 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 11:51 [PATCH 1/3] libidn2: add new version Ross Burton
2018-07-23 11:51 ` [PATCH 2/3] gnutls: rationalise libunistring arguments Ross Burton
2018-07-27 10:24 ` Khem Raj [this message]
2018-07-23 11:51 ` [PATCH 3/3] gnutls: fix libidn dependencies Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMKF1srcpA0wowvnELw4JSsePBF8V7YtkBkwLMOCyFojenL09w@mail.gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.