Re: [meta-gnome][PATCHv2 1/2] sysprof: add a recipe from oe-core

[Khem Raj <raj.khem@gmail.com>]

with distros with systemd I am seeing this error

ERROR: sysprof-3.34.1-r0 do_package: SYSTEMD_SERVICE_sysprof value
sysprof2.service does not exist


On Wed, Jan 15, 2020 at 7:33 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Wed, Jan 15, 2020 at 7:02 AM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > I have to draw the line here: fixing issues with a non-standard compiler is on you.
> >
>
> I wondered why gcc can not find it, perhaps -Wshadow is not enabled,
> it's fine I do not expect either. It was merely for future reference
> if someone stumbles on this issue
>
> > Alex
> >
> > On Wed, 15 Jan 2020 at 15:37, Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> there is another failure seen with clang
> >>
> >> http://errors.yoctoproject.org/Errors/Details/306619/
> >>
> >> variable environ should perhaps be renamed to avoid clash with system
> >> headers definition
> >>
> >> On Tue, Jan 14, 2020 at 4:01 AM Alexander Kanavin
> >> <alex.kanavin@gmail.com> wrote:
> >> >
> >> > Thanks, I've just sent a patch for this.
> >> >
> >> > Alex
> >> >
> >> > On Tue, 14 Jan 2020 at 01:37, Khem Raj <raj.khem@gmail.com> wrote:
> >> >>
> >> >> On 1/13/20 11:01 AM, Martin Jansa wrote:
> >> >> > From: Alexander Kanavin <alex.kanavin@gmail.com>
> >> >> >
> >> >> > Latest version (3.34) of sysprof have a hard dependency on polkit,
> >> >> > which in turn requires mozjs, which pulls in a number of other
> >> >> > meta-oe packages including python2. This makes it difficult
> >> >> > to keep sysprof in oe-core, so for the time being it is moved to
> >> >> > meta-oe.
> >> >>
> >> >>
> >> >> it fails to build for arm
> >> >> https://errors.yoctoproject.org/Errors/Details/306463/
> >> >> https://errors.yoctoproject.org/Errors/Details/306361/
> >> >>
> >> >> >
> >> >> > Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> >> >> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> >> > ---
> >> >> >   ...thing-in-help-as-it-requires-itstool.patch | 27 ++++++++++++++++
> >> >> >   .../files/define-NT_GNU_BUILD_ID.patch        | 22 +++++++++++++
> >> >> >   .../recipes-kernel/sysprof/sysprof_3.32.0.bb  | 32 +++++++++++++++++++
> >> >> >   3 files changed, 81 insertions(+)
> >> >> >   create mode 100644 meta-gnome/recipes-kernel/sysprof/files/0001-Do-not-build-anything-in-help-as-it-requires-itstool.patch
> >> >> >   create mode 100644 meta-gnome/recipes-kernel/sysprof/files/define-NT_GNU_BUILD_ID.patch
> >> >> >   create mode 100644 meta-gnome/recipes-kernel/sysprof/sysprof_3.32.0.bb
> >> >> >
> >> >> > diff --git a/meta-gnome/recipes-kernel/sysprof/files/0001-Do-not-build-anything-in-help-as-it-requires-itstool.patch b/meta-gnome/recipes-kernel/sysprof/files/0001-Do-not-build-anything-in-help-as-it-requires-itstool.patch
> >> >> > new file mode 100644
> >> >> > index 0000000000..ade51cf864
> >> >> > --- /dev/null
> >> >> > +++ b/meta-gnome/recipes-kernel/sysprof/files/0001-Do-not-build-anything-in-help-as-it-requires-itstool.patch
> >> >> > @@ -0,0 +1,27 @@
> >> >> > +From d332b480257aa98b63d39c3c94896a111536f937 Mon Sep 17 00:00:00 2001
> >> >> > +From: Alexander Kanavin <alex.kanavin@gmail.com>
> >> >> > +Date: Wed, 23 Aug 2017 18:38:26 +0300
> >> >> > +Subject: [PATCH 2/2] Do not build anything in help/ as it requires itstool.
> >> >> > +
> >> >> > +Upstream-Status: Inappropriate [oe-core specific]
> >> >> > +Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> >> >> > +
> >> >> > +---
> >> >> > + meson.build | 1 -
> >> >> > + 1 file changed, 1 deletion(-)
> >> >> > +
> >> >> > +diff --git a/meson.build b/meson.build
> >> >> > +index 3986273..ae2f65e 100644
> >> >> > +--- a/meson.build
> >> >> > ++++ b/meson.build
> >> >> > +@@ -164,7 +164,6 @@ subdir('tools')
> >> >> > + subdir('tests')
> >> >> > +
> >> >> > + subdir('data')
> >> >> > +-subdir('help')
> >> >> > + subdir('po')
> >> >> > +
> >> >> > + meson.add_install_script('build-aux/meson/post_install.sh')
> >> >> > +--
> >> >> > +2.7.4
> >> >> > +
> >> >> > diff --git a/meta-gnome/recipes-kernel/sysprof/files/define-NT_GNU_BUILD_ID.patch b/meta-gnome/recipes-kernel/sysprof/files/define-NT_GNU_BUILD_ID.patch
> >> >> > new file mode 100644
> >> >> > index 0000000000..f75ddad43a
> >> >> > --- /dev/null
> >> >> > +++ b/meta-gnome/recipes-kernel/sysprof/files/define-NT_GNU_BUILD_ID.patch
> >> >> > @@ -0,0 +1,22 @@
> >> >> > +On uclibc elf.h does not have GNU extentions but we need this define
> >> >> > +so we define it locally if its not getting it from elf.h
> >> >> > +
> >> >> > +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> >> > +
> >> >> > +Upstream-Status: Pending
> >> >> > +
> >> >> > +Index: git/elfparser.h
> >> >> > +===================================================================
> >> >> > +--- git.orig/lib/util/elfparser.h    2011-07-16 18:57:41.000000000 -0700
> >> >> > ++++ git/lib/util/elfparser.h 2011-07-16 20:28:54.733829895 -0700
> >> >> > +@@ -17,6 +17,10 @@
> >> >> > +  */
> >> >> > + #include <glib.h>
> >> >> > +
> >> >> > ++#ifndef NT_GNU_BUILD_ID
> >> >> > ++#define NT_GNU_BUILD_ID 3
> >> >> > ++#endif
> >> >> > ++
> >> >> > + typedef struct ElfSym ElfSym;
> >> >> > + typedef struct ElfParser ElfParser;
> >> >> > +
> >> >> > diff --git a/meta-gnome/recipes-kernel/sysprof/sysprof_3.32.0.bb b/meta-gnome/recipes-kernel/sysprof/sysprof_3.32.0.bb
> >> >> > new file mode 100644
> >> >> > index 0000000000..b92933806c
> >> >> > --- /dev/null
> >> >> > +++ b/meta-gnome/recipes-kernel/sysprof/sysprof_3.32.0.bb
> >> >> > @@ -0,0 +1,32 @@
> >> >> > +SUMMARY = "System-wide Performance Profiler for Linux"
> >> >> > +HOMEPAGE = "http://www.sysprof.com"
> >> >> > +LICENSE = "GPLv3+"
> >> >> > +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
> >> >> > +                    file://src/sp-application.c;endline=17;md5=40e55577ef122c88fe20052acda64875"
> >> >> > +
> >> >> > +GNOMEBASEBUILDCLASS = "meson"
> >> >> > +inherit gnomebase gettext systemd upstream-version-is-even gsettings
> >> >> > +
> >> >> > +DEPENDS = "glib-2.0 libxml2-native glib-2.0-native"
> >> >> > +
> >> >> > +SRC_URI[archive.md5sum] = "d1fa9ad216419d722770ca36713ad3af"
> >> >> > +SRC_URI[archive.sha256sum] = "fc22a69e468701c5ec9036e960c6273afa1ed6a89df1f889fed49417add5554d"
> >> >> > +SRC_URI += " \
> >> >> > +           file://define-NT_GNU_BUILD_ID.patch \
> >> >> > +           file://0001-Do-not-build-anything-in-help-as-it-requires-itstool.patch \
> >> >> > +           "
> >> >> > +
> >> >> > +PACKAGECONFIG ?= "${@bb.utils.contains_any('DISTRO_FEATURES', '${GTK3DISTROFEATURES}', 'gtk', '', d)}"
> >> >> > +PACKAGECONFIG[gtk] = "-Denable_gtk=true,-Denable_gtk=false,gtk+3"
> >> >> > +PACKAGECONFIG[sysprofd] = "-Dwith_sysprofd=bundled,-Dwith_sysprofd=none,polkit"
> >> >> > +
> >> >> > +SOLIBS = ".so"
> >> >> > +FILES_SOLIBSDEV = ""
> >> >> > +
> >> >> > +SYSTEMD_SERVICE_${PN} = "${@bb.utils.contains('PACKAGECONFIG', 'sysprofd', 'sysprof2.service', '', d)}"
> >> >> > +
> >> >> > +FILES_${PN} += " \
> >> >> > +               ${datadir}/dbus-1/system-services \
> >> >> > +               ${datadir}/dbus-1/system.d \
> >> >> > +               ${datadir}/metainfo \
> >> >> > +               "
> >> >> >
> >> >>
> >> >> --
> >> >> _______________________________________________
> >> >> Openembedded-devel mailing list
> >> >> Openembedded-devel@lists.openembedded.org
> >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel