From: Khem Raj <raj.khem@gmail.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] swuashfs-tools: Enable on musl
Date: Fri, 14 Feb 2020 06:42:12 -0800 [thread overview]
Message-ID: <CAMKF1srgk=M8AV2oeyyvYTJGUffS3P7+W0U6VqGZ3GYFfXau6Q@mail.gmail.com> (raw)
In-Reply-To: <20200214143525.GA31591@localhost>
On Fri, Feb 14, 2020 at 6:35 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Thu, Feb 13, 2020 at 11:03:52PM -0800, Khem Raj wrote:
> > Upstream has a patch [1] to fix musl builds, Prior to this it would not
> > build on musl due to missing GNU extentions for fnmatch
> >
> > [1] https://github.com/plougher/squashfs-tools/commit/4280e74de14070869787a9166242f9ce2dafd82e
> >...
>
> I did already remove a similar bogus squashfs-tools change from OE,
> with similar FNM_EXTMATCH "fixes" in ifupdown and elfutils
> also resulting in the expected runtime misbehaviour.
>
I think it would be better to use gnulib implementation for these
packages you point out
and those patches will be upstream worthy and make them portable
as well.
At least it is calling out bad elements.
> I am not a fan of this musl way of fixing build failures by turning them
> into runtime breakages.
next prev parent reply other threads:[~2020-02-14 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 7:03 [PATCH] swuashfs-tools: Enable on musl Khem Raj
2020-02-14 14:35 ` Adrian Bunk
2020-02-14 14:42 ` Khem Raj [this message]
2020-02-14 15:50 ` Adrian Bunk
2020-02-14 14:49 ` Robert P. J. Day
2020-02-14 15:37 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMKF1srgk=M8AV2oeyyvYTJGUffS3P7+W0U6VqGZ3GYFfXau6Q@mail.gmail.com' \
--to=raj.khem@gmail.com \
--cc=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.