[PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Mike Crowe]

bitbake.conf currently contains:

EXTRA_OEMAKE = "-e MAKEFLAGS="

Back in November[1] I submitted a patch that allowed this default
value to be overridden without affecting anything else that was
appended to it. I received feedback that the default value was no
longer useful and that it would be good to get rid of it.

So, this patch series fixes the two recipes that still appear to be
relying on the previous default and then makes the default
EXTRA_OEMAKE = "". After these changes core-image-sato builds
successfully for me (although I have not run it.)

Mike.

[1] http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112393.html

[PATCH 1/3] openssl: Explicitly set EXTRA_OEMAKE as required

[Mike Crowe]

The openssl recipe currently relies on EXTRA_OEMAKE having been set to
"-e MAKEFLAGS=" in bitbake.conf to operate. It is necessary to make this
explicit so that the default in bitbake.conf can be changed.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
 meta/recipes-connectivity/openssl/openssl.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-connectivity/openssl/openssl.inc b/meta/recipes-connectivity/openssl/openssl.inc
index 44e2eb4..bc4a2ec 100644
--- a/meta/recipes-connectivity/openssl/openssl.inc
+++ b/meta/recipes-connectivity/openssl/openssl.inc
@@ -32,6 +32,7 @@ CFLAG_mtx-2 := "${@'${CFLAG}'.replace('-O2', '')}"
 export DIRS = "crypto ssl apps"
 export EX_LIBS = "-lgcc -ldl"
 export AS = "${CC} -c"
+EXTRA_OEMAKE = "-e MAKEFLAGS="
 
 inherit pkgconfig siteinfo multilib_header ptest
 
-- 
2.1.4

[PATCH 2/3] pciutils: Explicitly set EXTRA_OEMAKE as required

[Mike Crowe]

The openssl recipe currently relies on EXTRA_OEMAKE having been set to
"-e MAKEFLAGS=" in bitbake.conf to operate. It is necessary to make this
explicit so that the default in bitbake.conf can be changed.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
 meta/recipes-bsp/pciutils/pciutils_3.4.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/pciutils/pciutils_3.4.1.bb b/meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
index 794419a..33be525 100644
--- a/meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
+++ b/meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
@@ -38,7 +38,7 @@ export SBINDIR = "${sbindir}"
 export SHAREDIR = "${datadir}"
 export MANDIR = "${mandir}"
 
-EXTRA_OEMAKE += "${PCI_CONF_FLAG}"
+EXTRA_OEMAKE = "-e MAKEFLAGS= ${PCI_CONF_FLAG}"
 
 # The configure script breaks if the HOST variable is set
 HOST[unexport] = "1"
-- 
2.1.4

[PATCH 3/3] bitbake.conf: Remove unhelpful default value for EXTRA_OEMAKE

[Mike Crowe]

Setting EXTRA_OEMAKE to "-e MAKEFLAGS=" by default is a historical
accident and many classes (e.g. autotools.bbclass, module.bbclass) and
recipes have to override this default in order to work with sensible
build systems.

Now that openssl and pciutils have been fixed to set EXTRA_OEMAKE
explicitly it is possible to set EXTRA_OEMAKE = "".

Signed-off-by: Mike Crowe <mac@mcrowe.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 1a2f420..a32d293 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -474,7 +474,7 @@ export BUILD_STRIP = "${BUILD_PREFIX}strip"
 export BUILD_NM = "${BUILD_PREFIX}nm"
 
 export MAKE = "make"
-EXTRA_OEMAKE = "-e MAKEFLAGS="
+EXTRA_OEMAKE = ""
 EXTRA_OECONF = ""
 export LC_ALL = "C"
 
-- 
2.1.4

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Richard Purdie]

On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> bitbake.conf currently contains:
> 
> EXTRA_OEMAKE = "-e MAKEFLAGS="
> 
> Back in November[1] I submitted a patch that allowed this default
> value to be overridden without affecting anything else that was
> appended to it. I received feedback that the default value was no
> longer useful and that it would be good to get rid of it.
> 
> So, this patch series fixes the two recipes that still appear to be
> relying on the previous default and then makes the default
> EXTRA_OEMAKE = "". After these changes core-image-sato builds
> successfully for me (although I have not run it.)
> 
> Mike.
> 
> [1] http://lists.openembedded.org/pipermail/openembedded-core/2015-No
> vember/112393.html

This is a pretty major change and we likely need a bit more of an idea
of impact.

Which architectures did you test? Often, x86 is a bad choice here and
we'd need something cross (arm/mips/ppc) to ensure it really is doing
the right things. We also need to assess a bit more than just sato. We
can run this up on the autobuilder and see what happens.

A post to the architecture list is probably needed so everyone knows
this is happening (or at least being considered).

I do worry how much of meta-oe may be affected by this. 

Martin: Any opinion on this?

Cheers,

Richard

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]

On Tue, Feb 02, 2016 at 04:01:14PM +0000, Richard Purdie wrote:
> On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> > bitbake.conf currently contains:
> > 
> > EXTRA_OEMAKE = "-e MAKEFLAGS="
> > 
> > Back in November[1] I submitted a patch that allowed this default
> > value to be overridden without affecting anything else that was
> > appended to it. I received feedback that the default value was no
> > longer useful and that it would be good to get rid of it.
> > 
> > So, this patch series fixes the two recipes that still appear to be
> > relying on the previous default and then makes the default
> > EXTRA_OEMAKE = "". After these changes core-image-sato builds
> > successfully for me (although I have not run it.)
> > 
> > Mike.
> > 
> > [1] http://lists.openembedded.org/pipermail/openembedded-core/2015-No
> > vember/112393.html
> 
> This is a pretty major change and we likely need a bit more of an idea
> of impact.
> 
> Which architectures did you test? Often, x86 is a bad choice here and
> we'd need something cross (arm/mips/ppc) to ensure it really is doing
> the right things. We also need to assess a bit more than just sato. We
> can run this up on the autobuilder and see what happens.
> 
> A post to the architecture list is probably needed so everyone knows
> this is happening (or at least being considered).
> 
> I do worry how much of meta-oe may be affected by this. 
> 
> Martin: Any opinion on this?

I can give it a shot in next rounds of jenkins builds, but the state is
already quite bad, so it will be hard to spot new issues.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Mike Crowe]

On Tuesday 02 February 2016 at 16:01:14 +0000, Richard Purdie wrote:
> On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> > bitbake.conf currently contains:
> > 
> > EXTRA_OEMAKE = "-e MAKEFLAGS="
> > 
> > Back in November[1] I submitted a patch that allowed this default
> > value to be overridden without affecting anything else that was
> > appended to it. I received feedback that the default value was no
> > longer useful and that it would be good to get rid of it.
> > 
> > So, this patch series fixes the two recipes that still appear to be
> > relying on the previous default and then makes the default
> > EXTRA_OEMAKE = "". After these changes core-image-sato builds
> > successfully for me (although I have not run it.)
> > 
> > Mike.
> > 
> > [1] http://lists.openembedded.org/pipermail/openembedded-core/2015-No
> > vember/112393.html
> 
> This is a pretty major change and we likely need a bit more of an idea
> of impact.

I agree.

> Which architectures did you test? Often, x86 is a bad choice here and
> we'd need something cross (arm/mips/ppc) to ensure it really is doing
> the right things. We also need to assess a bit more than just sato. We
> can run this up on the autobuilder and see what happens.

I've compile-tested qemux86 and qemuarm for core-image-sato. qemumips is
building now.

We've been running with the previous version of the patch with our code for
a while but now I look more closely that solution didn't have anywhere near
as wide an impact so I'll switch us over to using these patches. That will
runtime-test a few real mips and arm targets (and even x86 and x86-64 to a
limited extent) but only with our customised set of packages.

> A post to the architecture list is probably needed so everyone knows
> this is happening (or at least being considered).

I'll do that once I've finished this round of testing. Would it be best to
just post a general overview or the complete patch series?

> I do worry how much of meta-oe may be affected by this.

We don't use meta-oe. I could have a look at trying some builds over the
weekend. Luckily any breakage will be easy to fix, but that doesn't really
help if hundreds of packages are affected!

Thanks.

Mike.

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Richard Purdie]

On Tue, 2016-02-02 at 21:04 +0000, Mike Crowe wrote:
> On Tuesday 02 February 2016 at 16:01:14 +0000, Richard Purdie wrote:
> > On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> > > bitbake.conf currently contains:
> > > 
> > > EXTRA_OEMAKE = "-e MAKEFLAGS="
> > > 
> > > Back in November[1] I submitted a patch that allowed this default
> > > value to be overridden without affecting anything else that was
> > > appended to it. I received feedback that the default value was no
> > > longer useful and that it would be good to get rid of it.
> > > 
> > > So, this patch series fixes the two recipes that still appear to
> > > be
> > > relying on the previous default and then makes the default
> > > EXTRA_OEMAKE = "". After these changes core-image-sato builds
> > > successfully for me (although I have not run it.)
> > > 
> > > Mike.
> > > 
> > > [1] 
> > > http://lists.openembedded.org/pipermail/openembedded-core/2015-No
> > > vember/112393.html
> > 
> > This is a pretty major change and we likely need a bit more of an
> > idea
> > of impact.
> 
> I agree.
> 
> > Which architectures did you test? Often, x86 is a bad choice here
> > and
> > we'd need something cross (arm/mips/ppc) to ensure it really is
> > doing
> > the right things. We also need to assess a bit more than just sato.
> > We
> > can run this up on the autobuilder and see what happens.
> 
> I've compile-tested qemux86 and qemuarm for core-image-sato. qemumips
> is
> building now.
> 
> We've been running with the previous version of the patch with our
> code for
> a while but now I look more closely that solution didn't have
> anywhere near
> as wide an impact so I'll switch us over to using these patches. That
> will
> runtime-test a few real mips and arm targets (and even x86 and x86-64
> to a
> limited extent) but only with our customised set of packages.

Thanks. Please do mention what tests have passed/failed just so I can
build some idea of the risk of the patch and decide if/as/when the
right time to merge it is.

> > A post to the architecture list is probably needed so everyone
> > knows
> > this is happening (or at least being considered).
> 
> I'll do that once I've finished this round of testing. Would it be
> best to
> just post a general overview or the complete patch series?

The general overview and main patch is fine. I will likely merge any
fixups like the two in this series as they become available since they
don't have an adverse affect as far as I can tell.

> > I do worry how much of meta-oe may be affected by this.
> 
> We don't use meta-oe. I could have a look at trying some builds over
> the
> weekend. Luckily any breakage will be easy to fix, but that doesn't
> really
> help if hundreds of packages are affected!

Right, I really just need an idea of whether its going to cause
problems and a rough idea of scale. I will run this on the Yocto
Project autobuilder but we're pushed for bandwidth at the moment so it
may not be until the weekend.

Cheers,

Richard

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Mike Crowe]

On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> > > > [snip] Set EXTRA_OEMAKE = "" in bitbake.conf

On Tuesday 02 February 2016 at 16:01:14 +0000, Richard Purdie wrote:
> > > Which architectures did you test? Often, x86 is a bad choice here and
> > > we'd need something cross (arm/mips/ppc) to ensure it really is doing
> > > the right things. We also need to assess a bit more than just sato.
> > > We can run this up on the autobuilder and see what happens.

On Tue, 2016-02-02 at 21:04 +0000, Mike Crowe wrote:
> > I've compile-tested qemux86 and qemuarm for core-image-sato. qemumips
> > is building now.

Since then I've collected enough patches to make "bitbake world" build
successfully for qemux86, qemuarm, qemuppc and qemumips. qemux86-64 is
building now. The recipes that needed fixing to explicitly set
EXTRA_OEMAKE = "-e MAKEFLAGS=" were:

  meta/recipes-bsp/apmd/apmd_3.2.2-15.bb
  meta/recipes-bsp/libacpi/libacpi_0.2.bb
  meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
  meta/recipes-connectivity/openssl/openssl.inc
  meta/recipes-devtools/dmidecode/dmidecode_3.0.bb
  meta/recipes-devtools/fdisk/gptfdisk_1.0.1.bb
  meta/recipes-devtools/perl/perl-native_5.22.1.bb
  meta/recipes-devtools/perl/perl_5.22.1.bb
  meta/recipes-extended/ed/ed_1.9.bb
  meta/recipes-extended/iputils/iputils_s20151218.bb
  meta/recipes-extended/pigz/pigz.inc
  meta/recipes-extended/stat/stat_3.3.bb
  meta/recipes-extended/sysklogd/sysklogd.inc
  meta/recipes-extended/unzip/unzip_6.0.bb
  meta/recipes-gnome/gtk-theme-torturer/gtk-theme-torturer_git.bb
  meta/recipes-support/ptest-runner/ptest-runner_2.0.bb

I will submit patches for these shortly.

> > We've been running with the previous version of the patch with our code
> > for a while but now I look more closely that solution didn't have
> > anywhere near as wide an impact so I'll switch us over to using these
> > patches. That will runtime-test a few real mips and arm targets (and
> > even x86 and x86-64 to a limited extent) but only with our customised
> > set of packages.

On Tuesday 02 February 2016 at 22:41:25 +0000, Richard Purdie wrote:
> Thanks. Please do mention what tests have passed/failed just so I can
> build some idea of the risk of the patch and decide if/as/when the
> right time to merge it is.

I've not yet done any more runtime tests. I hope to get the change into our
tree tonight so everything gets rebuilt with it over the weekend and I can
test next week.

> > > A post to the architecture list is probably needed so everyone knows
> > > this is happening (or at least being considered).

I hope to send such a post later today.

Mike.

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Khem Raj]

On Fri, Feb 5, 2016 at 9:32 AM, Mike Crowe <mac@mcrowe.com> wrote:
> On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
>> > > > [snip] Set EXTRA_OEMAKE = "" in bitbake.conf
>
> On Tuesday 02 February 2016 at 16:01:14 +0000, Richard Purdie wrote:
>> > > Which architectures did you test? Often, x86 is a bad choice here and
>> > > we'd need something cross (arm/mips/ppc) to ensure it really is doing
>> > > the right things. We also need to assess a bit more than just sato.
>> > > We can run this up on the autobuilder and see what happens.
>
> On Tue, 2016-02-02 at 21:04 +0000, Mike Crowe wrote:
>> > I've compile-tested qemux86 and qemuarm for core-image-sato. qemumips
>> > is building now.
>
> Since then I've collected enough patches to make "bitbake world" build
> successfully for qemux86, qemuarm, qemuppc and qemumips. qemux86-64 is
> building now. The recipes that needed fixing to explicitly set
> EXTRA_OEMAKE = "-e MAKEFLAGS=" were:
>
>   meta/recipes-bsp/apmd/apmd_3.2.2-15.bb
>   meta/recipes-bsp/libacpi/libacpi_0.2.bb
>   meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
>   meta/recipes-connectivity/openssl/openssl.inc
>   meta/recipes-devtools/dmidecode/dmidecode_3.0.bb
>   meta/recipes-devtools/fdisk/gptfdisk_1.0.1.bb
>   meta/recipes-devtools/perl/perl-native_5.22.1.bb
>   meta/recipes-devtools/perl/perl_5.22.1.bb
>   meta/recipes-extended/ed/ed_1.9.bb
>   meta/recipes-extended/iputils/iputils_s20151218.bb
>   meta/recipes-extended/pigz/pigz.inc
>   meta/recipes-extended/stat/stat_3.3.bb
>   meta/recipes-extended/sysklogd/sysklogd.inc
>   meta/recipes-extended/unzip/unzip_6.0.bb
>   meta/recipes-gnome/gtk-theme-torturer/gtk-theme-torturer_git.bb
>   meta/recipes-support/ptest-runner/ptest-runner_2.0.bb
>
> I will submit patches for these shortly.

then there are other layers besides OE-Core where this will be needed.
so phase it right so it doesnt cause land slide work for other layers

>
>> > We've been running with the previous version of the patch with our code
>> > for a while but now I look more closely that solution didn't have
>> > anywhere near as wide an impact so I'll switch us over to using these
>> > patches. That will runtime-test a few real mips and arm targets (and
>> > even x86 and x86-64 to a limited extent) but only with our customised
>> > set of packages.
>
> On Tuesday 02 February 2016 at 22:41:25 +0000, Richard Purdie wrote:
>> Thanks. Please do mention what tests have passed/failed just so I can
>> build some idea of the risk of the patch and decide if/as/when the
>> right time to merge it is.
>
> I've not yet done any more runtime tests. I hope to get the change into our
> tree tonight so everything gets rebuilt with it over the weekend and I can
> test next week.
>
>> > > A post to the architecture list is probably needed so everyone knows
>> > > this is happening (or at least being considered).
>
> I hope to send such a post later today.
>
> Mike.
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Richard Purdie]

On Fri, 2016-02-05 at 10:22 -0800, Khem Raj wrote:
> On Fri, Feb 5, 2016 at 9:32 AM, Mike Crowe <mac@mcrowe.com> wrote:
> > On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> > On Tue, 2016-02-02 at 21:04 +0000, Mike Crowe wrote:
> > > > I've compile-tested qemux86 and qemuarm for core-image-sato.
> > > > qemumips
> > > > is building now.
> > 
> > Since then I've collected enough patches to make "bitbake world"
> > build
> > successfully for qemux86, qemuarm, qemuppc and qemumips. qemux86-64
> > is
> > building now. The recipes that needed fixing to explicitly set
> > EXTRA_OEMAKE = "-e MAKEFLAGS=" were:
> > 
> >   meta/recipes-bsp/apmd/apmd_3.2.2-15.bb
> >   meta/recipes-bsp/libacpi/libacpi_0.2.bb
> >   meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
> >   meta/recipes-connectivity/openssl/openssl.inc
> >   meta/recipes-devtools/dmidecode/dmidecode_3.0.bb
> >   meta/recipes-devtools/fdisk/gptfdisk_1.0.1.bb
> >   meta/recipes-devtools/perl/perl-native_5.22.1.bb
> >   meta/recipes-devtools/perl/perl_5.22.1.bb
> >   meta/recipes-extended/ed/ed_1.9.bb
> >   meta/recipes-extended/iputils/iputils_s20151218.bb
> >   meta/recipes-extended/pigz/pigz.inc
> >   meta/recipes-extended/stat/stat_3.3.bb
> >   meta/recipes-extended/sysklogd/sysklogd.inc
> >   meta/recipes-extended/unzip/unzip_6.0.bb
> >   meta/recipes-gnome/gtk-theme-torturer/gtk-theme-torturer_git.bb
> >   meta/recipes-support/ptest-runner/ptest-runner_2.0.bb
> > 
> > I will submit patches for these shortly.
> 
> then there are other layers besides OE-Core where this will be
> needed.
> so phase it right so it doesnt cause land slide work for other layers

How do we do that?

Obviously I can merge the above into OE-Core and then there is just the
final bitbake.conf patch. How long do we need to wait for other layers
to sort this out though?

I'm facing this dilemma with a few patches atm...

Cheers,

Richard

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3162 bytes --]

Please send whatever you currently have, so I can test it in my world build
with more layers.

I've already included bitbake.conf change and e.g. pigz-native you listed
here is already failing so I doubt the build with test any reasonable
number of recipes if I let it run like this.

On Fri, Feb 5, 2016 at 6:32 PM, Mike Crowe <mac@mcrowe.com> wrote:

> On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> > > > > [snip] Set EXTRA_OEMAKE = "" in bitbake.conf
>
> On Tuesday 02 February 2016 at 16:01:14 +0000, Richard Purdie wrote:
> > > > Which architectures did you test? Often, x86 is a bad choice here and
> > > > we'd need something cross (arm/mips/ppc) to ensure it really is doing
> > > > the right things. We also need to assess a bit more than just sato.
> > > > We can run this up on the autobuilder and see what happens.
>
> On Tue, 2016-02-02 at 21:04 +0000, Mike Crowe wrote:
> > > I've compile-tested qemux86 and qemuarm for core-image-sato. qemumips
> > > is building now.
>
> Since then I've collected enough patches to make "bitbake world" build
> successfully for qemux86, qemuarm, qemuppc and qemumips. qemux86-64 is
> building now. The recipes that needed fixing to explicitly set
> EXTRA_OEMAKE = "-e MAKEFLAGS=" were:
>
>   meta/recipes-bsp/apmd/apmd_3.2.2-15.bb
>   meta/recipes-bsp/libacpi/libacpi_0.2.bb
>   meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
>   meta/recipes-connectivity/openssl/openssl.inc
>   meta/recipes-devtools/dmidecode/dmidecode_3.0.bb
>   meta/recipes-devtools/fdisk/gptfdisk_1.0.1.bb
>   meta/recipes-devtools/perl/perl-native_5.22.1.bb
>   meta/recipes-devtools/perl/perl_5.22.1.bb
>   meta/recipes-extended/ed/ed_1.9.bb
>   meta/recipes-extended/iputils/iputils_s20151218.bb
>   meta/recipes-extended/pigz/pigz.inc
>   meta/recipes-extended/stat/stat_3.3.bb
>   meta/recipes-extended/sysklogd/sysklogd.inc
>   meta/recipes-extended/unzip/unzip_6.0.bb
>   meta/recipes-gnome/gtk-theme-torturer/gtk-theme-torturer_git.bb
>   meta/recipes-support/ptest-runner/ptest-runner_2.0.bb
>
> I will submit patches for these shortly.
>
> > > We've been running with the previous version of the patch with our code
> > > for a while but now I look more closely that solution didn't have
> > > anywhere near as wide an impact so I'll switch us over to using these
> > > patches. That will runtime-test a few real mips and arm targets (and
> > > even x86 and x86-64 to a limited extent) but only with our customised
> > > set of packages.
>
> On Tuesday 02 February 2016 at 22:41:25 +0000, Richard Purdie wrote:
> > Thanks. Please do mention what tests have passed/failed just so I can
> > build some idea of the risk of the patch and decide if/as/when the
> > right time to merge it is.
>
> I've not yet done any more runtime tests. I hope to get the change into our
> tree tonight so everything gets rebuilt with it over the weekend and I can
> test next week.
>
> > > > A post to the architecture list is probably needed so everyone knows
> > > > this is happening (or at least being considered).
>
> I hope to send such a post later today.
>
> Mike.
>

[-- Attachment #2: Type: text/html, Size: 4952 bytes --]

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Khem Raj]

On Fri, Feb 5, 2016 at 10:31 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2016-02-05 at 10:22 -0800, Khem Raj wrote:
>> On Fri, Feb 5, 2016 at 9:32 AM, Mike Crowe <mac@mcrowe.com> wrote:
>> > On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
>> > On Tue, 2016-02-02 at 21:04 +0000, Mike Crowe wrote:
>> > > > I've compile-tested qemux86 and qemuarm for core-image-sato.
>> > > > qemumips
>> > > > is building now.
>> >
>> > Since then I've collected enough patches to make "bitbake world"
>> > build
>> > successfully for qemux86, qemuarm, qemuppc and qemumips. qemux86-64
>> > is
>> > building now. The recipes that needed fixing to explicitly set
>> > EXTRA_OEMAKE = "-e MAKEFLAGS=" were:
>> >
>> >   meta/recipes-bsp/apmd/apmd_3.2.2-15.bb
>> >   meta/recipes-bsp/libacpi/libacpi_0.2.bb
>> >   meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
>> >   meta/recipes-connectivity/openssl/openssl.inc
>> >   meta/recipes-devtools/dmidecode/dmidecode_3.0.bb
>> >   meta/recipes-devtools/fdisk/gptfdisk_1.0.1.bb
>> >   meta/recipes-devtools/perl/perl-native_5.22.1.bb
>> >   meta/recipes-devtools/perl/perl_5.22.1.bb
>> >   meta/recipes-extended/ed/ed_1.9.bb
>> >   meta/recipes-extended/iputils/iputils_s20151218.bb
>> >   meta/recipes-extended/pigz/pigz.inc
>> >   meta/recipes-extended/stat/stat_3.3.bb
>> >   meta/recipes-extended/sysklogd/sysklogd.inc
>> >   meta/recipes-extended/unzip/unzip_6.0.bb
>> >   meta/recipes-gnome/gtk-theme-torturer/gtk-theme-torturer_git.bb
>> >   meta/recipes-support/ptest-runner/ptest-runner_2.0.bb
>> >
>> > I will submit patches for these shortly.
>>
>> then there are other layers besides OE-Core where this will be
>> needed.
>> so phase it right so it doesnt cause land slide work for other layers
>
> How do we do that?
>
> Obviously I can merge the above into OE-Core and then there is just the
> final bitbake.conf patch. How long do we need to wait for other layers
> to sort this out though?

hard problem, it just makes it longer for adopting a release thats the effect.
the only solution is to fix the issues. Or phase in with backward compatibility
these kind of stuff can be treated like ABI of OE-Core IMO

>
> I'm facing this dilemma with a few patches atm...
>
> Cheers,
>
> Richard
>

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 5601 bytes --]

Last world build with this change included (not the other fixes for
oe-core sent later) shows:


Summary: 30 tasks failed:
  virtual:native:/home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/pigz/pigz_2.3.3.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-core/llvm/llvm3.3_3.3.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-initramfs/recipes-devtools/klibc/klibc_2.0.4.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/unzip/unzip_6.0.bb,
do_package
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-devtools/dmidecode/dmidecode_3.0.bb,
do_package
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/stat/stat_3.3.bb,
do_package
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-multimedia/recipes-mkv/libebml/libebml_1.3.0.bb,
do_compile
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/ed/ed_1.9.bb,
do_package
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/sysklogd/sysklogd_1.5.1.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/invensense_git.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/soci/soci_3.2.2.bb,
do_configure
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb,
do_compile
  virtual:native:/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/libwmf/libwmf_0.2.8.4.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/iptraf/iptraf_3.0.0.bb,
do_compile
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/pigz/pigz_2.3.3.bb,
do_compile
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-bsp/apmd/apmd_3.2.2-15.bb,
do_compile
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-support/ptest-runner/ptest-runner_2.0.bb,
do_package
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/ckermit/ckermit_302.bb,
do_install
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/pngcheck/pngcheck_2.3.0.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-benchmark/nbench-byte/nbench-byte_2.2.3.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb,
do_package
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/serialcheck/serialcheck_1.0.0.bb,
do_package
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-protocols/pptp-linux/pptp-linux_1.7.2.bb,
do_package
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-support/pimd/pimd_2.1.8.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-irc/znc/znc_git.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/rarpd/rarpd_ss981107.bb,
do_package
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/libtinyxml2/libtinyxml2_git.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/mg/mg_20110905.bb,
do_compile
Summary: There were 33 WARNING messages shown.
Summary: There were 65 ERROR messages shown, returning a non-zero exit code.


On Tue, Feb 2, 2016 at 5:17 PM, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Tue, Feb 02, 2016 at 04:01:14PM +0000, Richard Purdie wrote:
> > On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> > > bitbake.conf currently contains:
> > >
> > > EXTRA_OEMAKE = "-e MAKEFLAGS="
> > >
> > > Back in November[1] I submitted a patch that allowed this default
> > > value to be overridden without affecting anything else that was
> > > appended to it. I received feedback that the default value was no
> > > longer useful and that it would be good to get rid of it.
> > >
> > > So, this patch series fixes the two recipes that still appear to be
> > > relying on the previous default and then makes the default
> > > EXTRA_OEMAKE = "". After these changes core-image-sato builds
> > > successfully for me (although I have not run it.)
> > >
> > > Mike.
> > >
> > > [1] http://lists.openembedded.org/pipermail/openembedded-core/2015-No
> > > vember/112393.html
> >
> > This is a pretty major change and we likely need a bit more of an idea
> > of impact.
> >
> > Which architectures did you test? Often, x86 is a bad choice here and
> > we'd need something cross (arm/mips/ppc) to ensure it really is doing
> > the right things. We also need to assess a bit more than just sato. We
> > can run this up on the autobuilder and see what happens.
> >
> > A post to the architecture list is probably needed so everyone knows
> > this is happening (or at least being considered).
> >
> > I do worry how much of meta-oe may be affected by this.
> >
> > Martin: Any opinion on this?
>
> I can give it a shot in next rounds of jenkins builds, but the state is
> already quite bad, so it will be hard to spot new issues.
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>

[-- Attachment #2: Type: text/html, Size: 7907 bytes --]

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Khem Raj]

On Fri, Feb 5, 2016 at 10:31 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2016-02-05 at 10:22 -0800, Khem Raj wrote:
>> On Fri, Feb 5, 2016 at 9:32 AM, Mike Crowe <mac@mcrowe.com> wrote:
>> > On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
>> > On Tue, 2016-02-02 at 21:04 +0000, Mike Crowe wrote:
>> > > > I've compile-tested qemux86 and qemuarm for core-image-sato.
>> > > > qemumips
>> > > > is building now.
>> >
>> > Since then I've collected enough patches to make "bitbake world"
>> > build
>> > successfully for qemux86, qemuarm, qemuppc and qemumips. qemux86-64
>> > is
>> > building now. The recipes that needed fixing to explicitly set
>> > EXTRA_OEMAKE = "-e MAKEFLAGS=" were:
>> >
>> >   meta/recipes-bsp/apmd/apmd_3.2.2-15.bb
>> >   meta/recipes-bsp/libacpi/libacpi_0.2.bb
>> >   meta/recipes-bsp/pciutils/pciutils_3.4.1.bb
>> >   meta/recipes-connectivity/openssl/openssl.inc
>> >   meta/recipes-devtools/dmidecode/dmidecode_3.0.bb
>> >   meta/recipes-devtools/fdisk/gptfdisk_1.0.1.bb
>> >   meta/recipes-devtools/perl/perl-native_5.22.1.bb
>> >   meta/recipes-devtools/perl/perl_5.22.1.bb
>> >   meta/recipes-extended/ed/ed_1.9.bb
>> >   meta/recipes-extended/iputils/iputils_s20151218.bb
>> >   meta/recipes-extended/pigz/pigz.inc
>> >   meta/recipes-extended/stat/stat_3.3.bb
>> >   meta/recipes-extended/sysklogd/sysklogd.inc
>> >   meta/recipes-extended/unzip/unzip_6.0.bb
>> >   meta/recipes-gnome/gtk-theme-torturer/gtk-theme-torturer_git.bb
>> >   meta/recipes-support/ptest-runner/ptest-runner_2.0.bb
>> >
>> > I will submit patches for these shortly.
>>
>> then there are other layers besides OE-Core where this will be
>> needed.
>> so phase it right so it doesnt cause land slide work for other layers
>
> How do we do that?

announce it to cross lists ahead of time so they can test out the features
ofcourse an argument is to be made that they should already be
watching OE-Core changes, however a heads up can only help.

>
> Obviously I can merge the above into OE-Core and then there is just the
> final bitbake.conf patch. How long do we need to wait for other layers
> to sort this out though?
>
> I'm facing this dilemma with a few patches atm...
>
> Cheers,
>
> Richard
>

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Mike Crowe]

On Saturday 06 February 2016 at 18:32:18 +0100, Martin Jansa wrote:
> Last world build with this change included (not the other fixes for
> oe-core sent later) shows:

Thanks for testing. I've been testing some of meta-oe myself today too.

> Summary: 30 tasks failed:
[result reordered to simplify the comments]

> virtual:native:/home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/pigz/pigz_2.3.3.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/unzip/unzip_6.0.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-devtools/dmidecode/dmidecode_3.0.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/stat/stat_3.3.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/ed/ed_1.9.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/sysklogd/sysklogd_1.5.1.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-extended/pigz/pigz_2.3.3.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-bsp/apmd/apmd_3.2.2-15.bb,
> /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-support/ptest-runner/ptest-runner_2.0.bb,

Patches sent on Friday 5th for all of the above.

> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-core/llvm/llvm3.3_3.3.bb,

I've not seen a failure on that one in my testing. It built for qemuarm64 successfully

> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/pngcheck/pngcheck_2.3.0.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/mg/mg_20110905.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/iptraf/iptraf_3.0.0.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/serialcheck/serialcheck_1.0.0.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-multimedia/v4l2apps/yavta_git.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/rarpd/rarpd_ss981107.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/ckermit/ckermit_302.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-benchmark/nbench-byte/nbench-byte_2.2.3.bb,

I found these and have patches ready to submit. Presumably I should send
them to openembedded-devel?

I also found the following failures which appear to be fixed by using the
old value of EXTRA_OEMAKE but they may just be non-deterministic recipes:

 wmiconfig
 system-setup-keyboard

I also ran into a number of other build failures that weren't fixed by
changing EXTRA_OEMAKE, but I suspect that at least some of them were
because I was foolish enough to test with qemuarm64. :)
 
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-initramfs/recipes-devtools/klibc/klibc_2.0.4.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-multimedia/recipes-mkv/libebml/libebml_1.3.0.bb,
> /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/invensense_git.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/soci/soci_3.2.2.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb,
> virtual:native:/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/libwmf/libwmf_0.2.8.4.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-protocols/pptp-linux/pptp-linux_1.7.2.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-support/pimd/pimd_2.1.8.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-irc/znc/znc_git.bb,
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/libtinyxml2/libtinyxml2_git.bb,

I haven't reproduced these because I didn't have those layers enabled. I've
now enabled them all and I'll set another build going.

Thanks!

Mike.

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Mike Crowe]

Further to my previous response, I've tried another build with qemuarm this
time and more layers enabled.

> On Saturday 06 February 2016 at 18:32:18 +0100, Martin Jansa wrote:
> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-multimedia/recipes-mkv/libebml/libebml_1.3.0.bb,
> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-connectivity/vlan/vlan_1.9.bb,
> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-protocols/pptp-linux/pptp-linux_1.7.2.bb,
> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-support/pimd/pimd_2.1.8.bb,

These recipes all appear to require EXTRA_OEMAKE = "-e MAKEFLAGS=". I have
patches ready to post.

I also saw similar failures with vsftpd and vpnc which you didn't see for
some reason. I have patches ready for those too.

> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-initramfs/recipes-devtools/klibc/klibc_2.0.4.bb,
> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/soci/soci_3.2.2.bb,
> > virtual:native:/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/libwmf/libwmf_0.2.8.4.bb,
> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb,
> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-irc/znc/znc_git.bb,

These recipes all compiled successfully for me with EXTRA_OEMAKE = "".
Perhaps they are non-deterministic or they failed for you for other reasons?

> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/libtinyxml2/libtinyxml2_git.bb,

This recipe doesn't appear to call oe_runmake. It failed to compile for me
even after explicitly setting EXTRA_OEMAKE back to "-e MAKEFLAGS=".

> > /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb,

This recipe fails to compile for me too but it doesn't seem to be related
to EXTRA_OEMAKE. I think it can't find the kernel headers it needs which
may be due to an error in my configuration.

> > /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/invensense_git.bb,

I haven't yet tried meta-android.

Thanks.

Mike.

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3110 bytes --]

> I also saw similar failures with vsftpd and vpnc which you didn't see for
some reason. I have patches ready for those too.

Most likely one of their dependencies failed, so it didn't try to compile
them yet (until I apply your patches for oe-core).

> This recipe fails to compile for me too but it doesn't seem to be related
to EXTRA_OEMAKE.

There are many issues not caused by EXTRA_OEMAKE, see previous bitbake
world report (which didn't have your EXTRA_OEMAKE change).
http://lists.openembedded.org/pipermail/openembedded-core/2016-February/116994.html


On Sun, Feb 7, 2016 at 11:07 PM, Mike Crowe <mac@mcrowe.com> wrote:

> Further to my previous response, I've tried another build with qemuarm this
> time and more layers enabled.
>
> > On Saturday 06 February 2016 at 18:32:18 +0100, Martin Jansa wrote:
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-multimedia/recipes-mkv/libebml/
> libebml_1.3.0.bb,
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-connectivity/vlan/
> vlan_1.9.bb,
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-protocols/pptp-linux/
> pptp-linux_1.7.2.bb,
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-support/pimd/
> pimd_2.1.8.bb,
>
> These recipes all appear to require EXTRA_OEMAKE = "-e MAKEFLAGS=". I have
> patches ready to post.
>
> I also saw similar failures with vsftpd and vpnc which you didn't see for
> some reason. I have patches ready for those too.
>
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-initramfs/recipes-devtools/klibc/
> klibc_2.0.4.bb,
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/soci/
> soci_3.2.2.bb,
> > >
> virtual:native:/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/libwmf/
> libwmf_0.2.8.4.bb,
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/cunit/
> cunit_2.1-3.bb,
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-irc/znc/
> znc_git.bb,
>
> These recipes all compiled successfully for me with EXTRA_OEMAKE = "".
> Perhaps they are non-deterministic or they failed for you for other
> reasons?
>
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/libtinyxml2/
> libtinyxml2_git.bb,
>
> This recipe doesn't appear to call oe_runmake. It failed to compile for me
> even after explicitly setting EXTRA_OEMAKE back to "-e MAKEFLAGS=".
>
> > >
> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+
> svn502.bb,
>
> This recipe fails to compile for me too but it doesn't seem to be related
> to EXTRA_OEMAKE. I think it can't find the kernel headers it needs which
> may be due to an error in my configuration.
>
> > >
> /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/
> invensense_git.bb,
>
> I haven't yet tried meta-android.
>
> Thanks.
>
> Mike.
>

[-- Attachment #2: Type: text/html, Size: 5134 bytes --]

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 7625 bytes --]

I've sent complete world report yesterday:
http://lists.openembedded.org/pipermail/openembedded-core/2016-February/117135.html

Now there is new qemuarm build which shows even more issues, because more
recipes were tested after dependencies were fixed:

ummary: 32 tasks failed:
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-core/llvm/llvm3.3_3.3.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-qt5/recipes-qt/qt5/qtbase_git.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-qt5/recipes-qt/qt5/qtbase_git.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-multimedia/ffmpeg/ffmpeg_2.8.5.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-initramfs/recipes-devtools/klibc/klibc_2.0.4.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/wmiconfig/wmiconfig_svn.bb,
do_package
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/mml-widget/gtkmathview_0.8.0.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/efivar/efivar_0.21.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/farsight/libnice_0.0.13.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-browser/recipes-mozilla/firefox/firefox_38.4.0esr.bb,
do_install
  /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/invensense_git.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-daemons/squid/squid_3.5.7.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-support/curlpp/curlpp_0.7.3.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/system-setup-keyboard/system-setup-keyboard_0.8.8.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-gnome/recipes-gnome/themes/gnome-themes_2.32.1.bb,
do_install
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-multimedia/recipes-mkv/libmatroska/libmatroska_1.4.1.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-gnome/recipes-extended/gtk-theme-torturer/gtk-theme-torturer_git.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-support/dovecot/dovecot_2.2.21.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-graphics/tesseract/tesseract_3.02.02.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.4.bb,
do_install
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/cunit/cunit_2.1-3.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-connectivity/snort/snort_2.9.7.5.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-smartphone/meta-shr/recipes-shr/3rdparty/atd-over-fso_0.70.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-filesystems/recipes-filesystems/yaffs2/yaffs2-utils_git.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-graphics/wayland/wayland-fits_git.bb,
do_compile
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-irc/znc/znc_git.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-core/fakeroot/fakeroot_1.18.4.bb,
do_package_qa
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/xerces-c/xerces-c_3.1.2.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-xfce/recipes-bindings/vala/xfce4-vala_4.10.3.bb,
do_configure
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/mpich/mpich_3.1.1.bb,
do_populate_sysroot
  /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/libtinyxml2/libtinyxml2_git.bb,
do_compile
Summary: There were 32 WARNING messages shown.
Summary: There were 116 ERROR messages shown, returning a non-zero exit code.


On Mon, Feb 8, 2016 at 1:07 AM, Martin Jansa <martin.jansa@gmail.com> wrote:

> > I also saw similar failures with vsftpd and vpnc which you didn't see
> for
> some reason. I have patches ready for those too.
>
> Most likely one of their dependencies failed, so it didn't try to compile
> them yet (until I apply your patches for oe-core).
>
> > This recipe fails to compile for me too but it doesn't seem to be
> related
> to EXTRA_OEMAKE.
>
> There are many issues not caused by EXTRA_OEMAKE, see previous bitbake
> world report (which didn't have your EXTRA_OEMAKE change).
>
> http://lists.openembedded.org/pipermail/openembedded-core/2016-February/116994.html
>
>
> On Sun, Feb 7, 2016 at 11:07 PM, Mike Crowe <mac@mcrowe.com> wrote:
>
>> Further to my previous response, I've tried another build with qemuarm
>> this
>> time and more layers enabled.
>>
>> > On Saturday 06 February 2016 at 18:32:18 +0100, Martin Jansa wrote:
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-multimedia/recipes-mkv/libebml/
>> libebml_1.3.0.bb,
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-connectivity/vlan/
>> vlan_1.9.bb,
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-protocols/pptp-linux/
>> pptp-linux_1.7.2.bb,
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-support/pimd/
>> pimd_2.1.8.bb,
>>
>> These recipes all appear to require EXTRA_OEMAKE = "-e MAKEFLAGS=". I have
>> patches ready to post.
>>
>> I also saw similar failures with vsftpd and vpnc which you didn't see for
>> some reason. I have patches ready for those too.
>>
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-initramfs/recipes-devtools/klibc/
>> klibc_2.0.4.bb,
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/soci/
>> soci_3.2.2.bb,
>> > >
>> virtual:native:/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/libwmf/
>> libwmf_0.2.8.4.bb,
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-devtools/cunit/
>> cunit_2.1-3.bb,
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-irc/znc/
>> znc_git.bb,
>>
>> These recipes all compiled successfully for me with EXTRA_OEMAKE = "".
>> Perhaps they are non-deterministic or they failed for you for other
>> reasons?
>>
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-support/libtinyxml2/
>> libtinyxml2_git.bb,
>>
>> This recipe doesn't appear to call oe_runmake. It failed to compile for me
>> even after explicitly setting EXTRA_OEMAKE back to "-e MAKEFLAGS=".
>>
>> > >
>> /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+
>> svn502.bb,
>>
>> This recipe fails to compile for me too but it doesn't seem to be related
>> to EXTRA_OEMAKE. I think it can't find the kernel headers it needs which
>> may be due to an error in my configuration.
>>
>> > >
>> /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/
>> invensense_git.bb,
>>
>> I haven't yet tried meta-android.
>>
>> Thanks.
>>
>> Mike.
>>
>
>

[-- Attachment #2: Type: text/html, Size: 11412 bytes --]

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Mike Crowe]

On Tuesday 09 February 2016 at 11:39:17 +0100, Martin Jansa wrote:
>   /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-multimedia/ffmpeg/ffmpeg_2.8.5.bb,
> do_compile

That one builds successfully for me for qemuarm. Strange.

>   /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/invensense_git.bb,
> do_package_qa

That one seems to be using cmake so I can't immediately see how it could be
affected by changing EXTRA_OEMAKE.

>   /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb,
> do_compile
>   /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-graphics/wayland/wayland-fits_git.bb,
> do_compile

I think these failed for me even without changing EXTRA_OEMAKE but I
need to go back and check.

Thanks for testing. I shall try and reproduce them and see if adding the
old value of EXTRA_OEMAKE to the recipes fixes them.

Mike.

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Andrea Adami]

On Tue, Feb 9, 2016 at 1:30 PM, Mike Crowe <mac@mcrowe.com> wrote:
> On Tuesday 09 February 2016 at 11:39:17 +0100, Martin Jansa wrote:
>>   /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-multimedia/ffmpeg/ffmpeg_2.8.5.bb,
>> do_compile
>
> That one builds successfully for me for qemuarm. Strange.
>
>>   /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/invensense_git.bb,
>> do_package_qa
>
> That one seems to be using cmake so I can't immediately see how it could be
> affected by changing EXTRA_OEMAKE.
>


It is unrelated...
About the do_package_qa, some of them like klibc and invensense come
after commit 47d38d4d86ec6a "insane: add test for -dev packaging
containing real libraries" introducing [dev-elf] fatal error.

Cheers

Andrea

>>   /home/jenkins/oe/world/shr-core/meta-openembedded/meta-networking/recipes-extended/iscsitarget/iscsitarget_1.4.20.3+svn502.bb,
>> do_compile
>>   /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-graphics/wayland/wayland-fits_git.bb,
>> do_compile
>
> I think these failed for me even without changing EXTRA_OEMAKE but I
> need to go back and check.
>
> Thanks for testing. I shall try and reproduce them and see if adding the
> old value of EXTRA_OEMAKE to the recipes fixes them.
>
> Mike.
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 0/3] Remove unhelpful default value of EXTRA_OEMAKE

[Mike Crowe]

On Tuesday 09 February 2016 at 13:51:20 +0100, Andrea Adami wrote:
> On Tue, Feb 9, 2016 at 1:30 PM, Mike Crowe <mac@mcrowe.com> wrote:
> > On Tuesday 09 February 2016 at 11:39:17 +0100, Martin Jansa wrote:
> >>   /home/jenkins/oe/world/shr-core/openembedded-core/meta/recipes-multimedia/ffmpeg/ffmpeg_2.8.5.bb,
> >> do_compile
> >
> > That one builds successfully for me for qemuarm. Strange.
> >
> >>   /home/jenkins/oe/world/shr-core/meta-smartphone/meta-android/recipes-support/invensense/invensense_git.bb,
> >> do_package_qa
> >
> > That one seems to be using cmake so I can't immediately see how it could be
> > affected by changing EXTRA_OEMAKE.
> >
> 
> It is unrelated...
> About the do_package_qa, some of them like klibc and invensense come
> after commit 47d38d4d86ec6a "insane: add test for -dev packaging
> containing real libraries" introducing [dev-elf] fatal error.

Thanks. If I revert that commit then I can compile klibc, dovecot,
fakeroot, llvm3.3 and invensense. The build got a bit further which has let
me fix libmatroska, system-setup-keyboard and wmiconfig.

There's still lots of breakage though that isn't fixed by simply
reinstating the old value of EXTRA_OEMAKE in the affected recipes. :(

So, I think that oe-core is in pretty good shape with EXTRA_OEMAKE="". I've
mainly been building qemuarm recently but I did get clean builds for many
of the other default MACHINEs in bitbake.conf. The only problem I found
since then was the QA warning on hdparm. There weren't any other QA
warnings like that on a completely clean qemuarm build.

meta-oe is in less good shape. I'm going to rebase everything on the latest
master and try again.

Mike.

Re: [PATCH 3/3] bitbake.conf: Remove unhelpful default value for EXTRA_OEMAKE

[Richard Purdie]

On Tue, 2016-02-02 at 14:49 +0000, Mike Crowe wrote:
> Setting EXTRA_OEMAKE to "-e MAKEFLAGS=" by default is a historical
> accident and many classes (e.g. autotools.bbclass, module.bbclass)
> and
> recipes have to override this default in order to work with sensible
> build systems.
> 
> Now that openssl and pciutils have been fixed to set EXTRA_OEMAKE
> explicitly it is possible to set EXTRA_OEMAKE = "".
> 
> Signed-off-by: Mike Crowe <mac@mcrowe.com>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 1a2f420..a32d293 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -474,7 +474,7 @@ export BUILD_STRIP = "${BUILD_PREFIX}strip"
>  export BUILD_NM = "${BUILD_PREFIX}nm"
>  
>  export MAKE = "make"
> -EXTRA_OEMAKE = "-e MAKEFLAGS="
> +EXTRA_OEMAKE = ""
>  EXTRA_OECONF = ""
>  export LC_ALL = "C"

I've merged this.

I just wanted to say thanks for taking this on, it required a bit of
work but is a good improvement and something several people have wanted
to see for a long time!

Cheers,

Richard