From: Alex Henrie <alexhenrie24@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: benjamin.tissoires@redhat.com, jirislaby@gmail.com,
stefan@glasen-hardt.de, ryan@finnie.org,
Johannes Thumshirn <morbidrsa@gmail.com>,
dan@pwienterprises.com, Andreas Krist <andreas.krist@gmail.com>,
rydberg@bitmath.org, Lukas Wunner <lukas@wunner.de>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3] HID: apple: Use country code to detect ISO keyboards
Date: Thu, 8 Jun 2017 09:15:08 -0600 [thread overview]
Message-ID: <CAMMLpeTLcR5w+uECCF2t=OQUo+pGrJdvVSLSZAnqPCLqjB5dyQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1706081402540.30709@cbobk.fhfr.pm>
2017-06-08 6:03 GMT-06:00 Jiri Kosina <jikos@kernel.org>:
> On Fri, 2 Jun 2017, Alex Henrie wrote:
>
>> At least on newer laptops, Apple uses the same USB ID for both ISO and
>> ANSI keyboards. However, they have been good about filling in the
>> bCountryCode field in the HID descriptor on all of their keyboards. A
>> value of 13 indicates an ISO layout and other values indicate various
>> country-specific ANSI layouts.
>>
>> With this patch, users of Apple US keyboards will no longer have to run
>> `echo 0 > /sys/module/hid_apple/parameters/iso_layout` to get a working
>> tilde key.
>>
>> Please test this patch and send feedback if you have a Macbook or an
>> Apple keyboard.
>>
>> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
>
> Applied to for-4.13/apple. Thanks,
Thank you!
-Alex
next prev parent reply other threads:[~2017-06-08 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:28 [PATCH v3] HID: apple: Use country code to detect ISO keyboards Alex Henrie
2017-06-06 7:29 ` Benjamin Tissoires
2017-06-08 12:03 ` Jiri Kosina
2017-06-08 15:15 ` Alex Henrie [this message]
2017-06-17 18:56 ` Lukas Wunner
2017-06-20 11:54 ` Bastien Nocera
2017-06-20 17:18 ` Alex Henrie
2017-06-20 18:00 ` Bastien Nocera
2017-08-05 17:09 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMMLpeTLcR5w+uECCF2t=OQUo+pGrJdvVSLSZAnqPCLqjB5dyQ@mail.gmail.com' \
--to=alexhenrie24@gmail.com \
--cc=andreas.krist@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dan@pwienterprises.com \
--cc=jikos@kernel.org \
--cc=jirislaby@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=morbidrsa@gmail.com \
--cc=ryan@finnie.org \
--cc=rydberg@bitmath.org \
--cc=stefan@glasen-hardt.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.