On Tue, Oct 2, 2018 at 6:43 PM Greg KH <gregkh@linuxfoundation.org> wrote:

> On Tue, Oct 02, 2018 at 03:07:14PM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 2 Oct 2018, Mamta Shukla wrote:
> >
> > >     udelay(unsigned long usec) replaced with usleep_range(unsigned long
> > >     min, unsigned long max) to prevent trigger by interrupt in
> specified
> > >     duration.Also provides better scheduling,power management for
> drivers.
> >
> > Thanks for the patch.  A few picky comments.  In English, it is more
> > readable to put some space after punctuation.  It is also not necessary
> to
> > indent the log message.
> >
> > Also, it would be good to explain how you chose the upper limit.
>
  Thank you for feedback Julia.I will keep in mind all these  while writing
next patch.
  I replaced udelay() with usleep_range to improve the responsiveness. I
considered these values
  to be equivalent for values by udelay(). But as mentioned by Greg , since
this depends on response
  time  of hardware and no exact value can be decided.

>
> It is _required_ to explain this.  This change comes up every so often,
> and I keep rejecting it as no one knows what value to put here that will
> correctly work.  So I recommend just leaving it alone unless you hav the
> hardware and can test this type of change properly.
>
> thanks,
>
> greg k-h
>
 Thank you for feedback Greg. I understood the hardware dependency for this
driver.
 Is it possible to remove this delay ?  This driver needs DMA accessibility
in Linux.
 So if one has to develop PCIe driver for any processor(intel, altera),
there should be
 different driver for each platform.


Thanks,

Mamta Shukla