Re: [Outreachy kernel] [PATCH 3/3] staging: rtl8723bs: os_dep: Shift * to be adjacent to pointer name

[Mamta Shukla <mamtashukla555@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2715 bytes --]

On Fri, Oct 12, 2018 at 4:56 PM Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> >On Fri, 12 Oct 2018, Mamta Shukla wrote:
>
> > Shift * to be adjacent to pointer name to follow Linux coding style.
> >  Issue found with checkpatch.pl
> > ERROR: "foo * bar" should be "foo *bar"
> >
> > Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
> > ACKed-by: Larry Finger <Larry....@lwfinger.net>
>
> >You should put the full email address here.  And it should be Acked-by.
> >
> >This is a v2, so you should say that in the subject line and explain what
> >you changed.  Did Greg already take the others in the series?
>
> >julia
>
>  This was the issue with this patch:
  This patch is somehow corrupted.  Can you fix it up and resend it,
  keeping Larry's ack?

 >thanks,

>greg k-h
 Yes, Greg had already taken the others in the series.
 I  did this patch again to fix it.
 This patch had got corrupted previously.
 I will add the revision and change log.



> > ---
> >  drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > index 243394e..28bfdbd 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> > @@ -528,8 +528,8 @@ static int wpa_set_encryption(struct net_device
> *dev, struct ieee_param *param,
> >       }
> >
> >       if (padapter->securitypriv.dot11AuthAlgrthm ==
> dot11AuthAlgrthm_8021X) { /*  802_1x */
> > -             struct sta_info * psta,*pbcmc_sta;
> > -             struct sta_priv * pstapriv = &padapter->stapriv;
> > +             struct sta_info *psta, *pbcmc_sta;
> > +             struct sta_priv *pstapriv = &padapter->stapriv;
> >
> >               if (check_fwstate(pmlmepriv, WIFI_STATION_STATE |
> WIFI_MP_STATE) == true) { /* sta mode */
> >                       psta = rtw_get_stainfo(pstapriv,
> get_bssid(pmlmepriv));
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/deb7888572fb02d8cbd80fcaf9d9cef69c550d88.1539278377.git.mamtashukla555%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>


-- 
Mamta Shukla
Pune Institute  of Computer Technology
Pune
m: 9158516957
e : mamtashukla555@gmail.com

[-- Attachment #2: Type: text/html, Size: 4654 bytes --]