All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 1/5] AVRCP: use a vtable to simplify PDU parsing/handling
Date: Mon, 12 Sep 2011 11:49:25 -0300	[thread overview]
Message-ID: <CAMOw1v67cXYEWFYQznVR7Gj6zbKodOmQSOr5hZ=4XpXrkq6b_A@mail.gmail.com> (raw)
In-Reply-To: <CABBYNZKx=YWwA3y9LxG1yScByxXS2C9nhgjCpuXtkVVyMEmCjA@mail.gmail.com>

On Mon, Sep 12, 2011 at 11:40 AM, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> Hi Lucas,
>
> On Mon, Sep 12, 2011 at 4:25 PM, Lucas De Marchi
> <lucas.demarchi@profusion.mobi> wrote:
>> It might be my CFLAGS, but aren't you getting warnings of unused
>> parameters since now every handler carries the transaction id?
>
> Nope and Im not sure why checking unused parameter would be a nice
> thing to have, specially dummy callbacks normally ignores some/all the
> parameters.
>

Right, I've just checked the file acinclude.m4 and BlueZ uses
"-Wno-unused-parameter" in its CFLAGS.

It's fine, then.


Lucas De Marchi

      reply	other threads:[~2011-09-12 14:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-12 11:29 [PATCH BlueZ 1/5] AVRCP: use a vtable to simplify PDU parsing/handling Luiz Augusto von Dentz
2011-09-12 11:29 ` [PATCH BlueZ 2/5] AVRCP: rename avrcp_header to avc_header Luiz Augusto von Dentz
2011-09-12 13:10   ` Lucas De Marchi
2011-09-12 13:37     ` Szymon Janc
2011-09-12 14:56       ` Luiz Augusto von Dentz
2011-09-12 15:57         ` Luiz Augusto von Dentz
2011-09-12 14:48     ` Luiz Augusto von Dentz
2011-09-12 11:29 ` [PATCH BlueZ 3/5] AVRCP: rename avrcp_spec_avc_pdu to avrcp_header Luiz Augusto von Dentz
2011-09-12 13:47   ` Lucas De Marchi
2011-09-12 11:29 ` [PATCH BlueZ 4/5] AVRCP: split AVCTP specific code from control.c Luiz Augusto von Dentz
2011-09-12 11:29 ` [PATCH BlueZ 5/5] AVRCP: move handling of vendor dependent PDU from control.c to avrcp.c Luiz Augusto von Dentz
2011-09-12 13:25 ` [PATCH BlueZ 1/5] AVRCP: use a vtable to simplify PDU parsing/handling Lucas De Marchi
2011-09-12 14:40   ` Luiz Augusto von Dentz
2011-09-12 14:49     ` Lucas De Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMOw1v67cXYEWFYQznVR7Gj6zbKodOmQSOr5hZ=4XpXrkq6b_A@mail.gmail.com' \
    --to=lucas.demarchi@profusion.mobi \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.