From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: David Stockwell <dstockwell@frequency-one.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
BlueZ devel list <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 3/3] AVRCP: Corrected metadata: Playing Time
Date: Mon, 22 Aug 2011 11:42:31 -0300 [thread overview]
Message-ID: <CAMOw1v7U3p99h+WA8U-Hp_fb37jZDsv+i--TSKAViyB-stAZ7Q@mail.gmail.com> (raw)
In-Reply-To: <76D0096D2AE844EC9E2A4834E474AE0B@freqoneremote>
Hi David,
On Mon, Aug 22, 2011 at 8:58 AM, David Stockwell
<dstockwell@frequency-one.com> wrote:
> Btw, it looked like this avrcp_handle_get_element_attributes function
> might not be properly checking the amount of actually received data in
> all necessary places before accessing the buffer (i.e. having the risk
> of remotely triggered buffer overflows). Could you please verify this
> and fix it if the issue really exists.
>
> +++++ I will take a look this afternoon and either send a fix, or send a
> note that it looks OK.
As I answered to Johan before seeing your response, it does have this
problem. I have the PDU-continuation pending here in which I fix this.
I'll probably send it by tomorrow. If you are into it and want to send
a fix, I'm ok with that.
regards,
Lucas De Marchi
next prev parent reply other threads:[~2011-08-22 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 22:53 [PATCH 3/3] AVRCP: Corrected metadata: Playing Time David Stockwell
2011-08-22 10:36 ` Johan Hedberg
2011-08-22 11:58 ` David Stockwell
2011-08-22 14:42 ` Lucas De Marchi [this message]
[not found] ` <165376978.336156.1314031379433.JavaMail.open-xchange@oxusltgw02.schlund.de>
2011-08-22 19:55 ` Lucas De Marchi
2011-08-23 3:02 ` David Stockwell
2011-08-22 14:38 ` Lucas De Marchi
2011-08-22 14:31 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMOw1v7U3p99h+WA8U-Hp_fb37jZDsv+i--TSKAViyB-stAZ7Q@mail.gmail.com \
--to=lucas.demarchi@profusion.mobi \
--cc=dstockwell@frequency-one.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.