All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Elijah Newren <newren@gmail.com>,
	Sverre Rabbelier <srabbelier@gmail.com>
Subject: Re: [PATCH 2/3] fast-export: add new --refspec option
Date: Thu, 16 May 2013 04:15:03 -0500	[thread overview]
Message-ID: <CAMP44s1G=SFJ-5J8UR=mnoO_JXmuY+CC1FaaY7yJNQGuCi0Naw@mail.gmail.com> (raw)
In-Reply-To: <7vk3n763is.fsf@alter.siamese.dyndns.org>

On Thu, May 9, 2013 at 8:13 PM, Junio C Hamano <gitster@pobox.com> wrote:

>    It is a very powerful concept that we can generate data once,
>    cast it in stone, and delay the decision on _how_ it is used
>    until the last minute, much better than mapping at export time.
>    So bundle does not need a similar refspec mechanism to map what
>    it exports.  I haven't thought things through to see if the same
>    logic applies to fast-export output (if so, it would mean it is
>    better to allow the consumer of the stream take the refspec
>    parameter and map the tips it finds in its input), though.

It's possible to delay the renaming of refspecs to leave that duty to
the remote-helper, however, each and every remote-helper would need
advertise a new capability, and then implement the renaming. I think
it makes much more sense to implement something that just works for
free in all remote-helpers.

But I wasn't even that interested in this patch, I implemented it
because while I was helping the emacs folks I had to explain to them
that old:new didn't work, and I thought it would be trivial to make it
work.

I'm dropping this series. Somebody should at least make it so a proper
error is displayed so that the users are not left in the dark
wondering what the hell is going on.

-- 
Felipe Contreras

  parent reply	other threads:[~2013-05-16  9:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09  1:31 [PATCH 0/3] Support for old:new remote-helper push Felipe Contreras
2013-05-09  1:31 ` [PATCH 1/3] fast-export: improve argument parsing Felipe Contreras
2013-05-09 22:17   ` Junio C Hamano
2013-05-09 23:02     ` Felipe Contreras
2013-05-09 23:27       ` Junio C Hamano
2013-05-09 23:33         ` Felipe Contreras
2013-05-10  4:49           ` Junio C Hamano
2013-05-09  1:31 ` [PATCH 2/3] fast-export: add new --refspec option Felipe Contreras
2013-05-09 22:32   ` Junio C Hamano
2013-05-09 22:53     ` Felipe Contreras
2013-05-09 23:23       ` Junio C Hamano
2013-05-09 23:32         ` Felipe Contreras
2013-05-10  0:21           ` Junio C Hamano
2013-05-10  0:44             ` Felipe Contreras
2013-05-10  1:13             ` Junio C Hamano
2013-05-10  6:42               ` Johannes Sixt
2013-05-16  9:15               ` Felipe Contreras [this message]
2013-05-09  1:31 ` [PATCH 3/3] transport-helper: add support for old:new refspec Felipe Contreras
2013-05-16  9:15 ` [PATCH 0/3] Support for old:new remote-helper push Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMP44s1G=SFJ-5J8UR=mnoO_JXmuY+CC1FaaY7yJNQGuCi0Naw@mail.gmail.com' \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.