From: Felipe Contreras <felipe.contreras@gmail.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>,
Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [PATCH] Add project-wide .vimrc configuration
Date: Wed, 9 Dec 2020 00:20:20 -0600 [thread overview]
Message-ID: <CAMP44s1fNwC+AfnPJxhG=24Zt5NFE5SoZZXpGEb-jcc+3QSg9A@mail.gmail.com> (raw)
In-Reply-To: <X9ApG0jUxJrPDK9d@generichostname>
On Tue, Dec 8, 2020 at 7:32 PM Denton Liu <liu.denton@gmail.com> wrote:
> On Tue, Dec 08, 2020 at 06:26:19PM -0600, Felipe Contreras wrote:
> > diff --git a/.vimrc b/.vimrc
> > new file mode 100644
> > index 0000000000..d250ab26e0
> > --- /dev/null
> > +++ b/.vimrc
> > @@ -0,0 +1,9 @@
> > +augroup git
> > + au!
> > + au BufRead,BufNewFile */t/*.sh set ft=sharness.sh
> > + au BufRead,BufNewFile */Documentation/*.txt set ft=asciidoc
> > +
> > + au FileType c setl noet ts=8 sw=0 cino=(s,:0,l1,t0
> > + au FileType sh setl noet ts=8 sw=0
> > + au FileType asciidoc setl noet ts=8 sw=0 autoindent
> > +augroup END
>
> A couple of nits. We should tab-indent this file since the rest of the
> project uses tabs everywhere. Also, perhaps use the full name for the
> option names so that it's immediately obvious what each setting does?
All right, makes sense to me.
--
Felipe Contreras
next prev parent reply other threads:[~2020-12-09 6:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 0:26 [PATCH] Add project-wide .vimrc configuration Felipe Contreras
2020-12-09 1:08 ` Junio C Hamano
2020-12-09 2:32 ` Felipe Contreras
2020-12-09 1:18 ` Aaron Schrab
2020-12-09 3:15 ` Junio C Hamano
2020-12-09 6:28 ` Felipe Contreras
2020-12-09 1:32 ` Denton Liu
2020-12-09 6:20 ` Felipe Contreras [this message]
2020-12-09 2:23 ` brian m. carlson
2020-12-09 6:36 ` Felipe Contreras
2020-12-09 6:54 ` Junio C Hamano
2020-12-09 7:16 ` Felipe Contreras
2020-12-09 8:13 ` Junio C Hamano
2020-12-09 8:52 ` Felipe Contreras
2020-12-09 16:18 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s1fNwC+AfnPJxhG=24Zt5NFE5SoZZXpGEb-jcc+3QSg9A@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.