From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751640AbdJXSgv (ORCPT ); Tue, 24 Oct 2017 14:36:51 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:46359 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbdJXSgu (ORCPT ); Tue, 24 Oct 2017 14:36:50 -0400 X-Google-Smtp-Source: ABhQp+QKjvoSzdUJt/m4FyMBMdXFpqiW8s5p7lyUZJDBl4+tvVYJjKKYqvXT3r8AE6HNXFLsx8t0IPpouur0BPZJ2Uc= MIME-Version: 1.0 In-Reply-To: <20171024072847.GA6034@kroah.com> References: <20171021005902.59586-1-sherryy@android.com> <20171021005902.59586-2-sherryy@android.com> <20171021081513.GA19354@kroah.com> <20171024072847.GA6034@kroah.com> From: =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= Date: Tue, 24 Oct 2017 11:36:48 -0700 Message-ID: Subject: Re: [PATCH v2 1/4] android: binder: Don't get mm from task To: Greg Kroah-Hartman Cc: "open list:ANDROID DRIVERS" , Sherry Yang , LKML , Riley Andrews , Martijn Coenen , Todd Kjos Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9OIause015997 On Tue, Oct 24, 2017 at 12:28 AM, Greg Kroah-Hartman wrote: > On Mon, Oct 23, 2017 at 11:18:52AM -0700, Arve Hjønnevåg wrote: >> On Sat, Oct 21, 2017 at 1:15 AM, Greg Kroah-Hartman >> wrote: >> > On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote: >> >> Use binder_alloc struct's mm_struct rather than getting >> >> a reference to the mm struct through get_task_mm to >> >> avoid a potential deadlock between lru lock, task lock and >> >> dentry lock, since a thread can be holding the task lock >> >> and the dentry lock while trying to acquire the lru lock. >> >> >> >> Acked-by: Arve Hjønnevåg >> >> Signed-off-by: Sherry Yang >> >> --- >> >> drivers/android/binder_alloc.c | 22 +++++++++------------- >> >> drivers/android/binder_alloc.h | 1 - >> >> 2 files changed, 9 insertions(+), 14 deletions(-) >> > >> > I've applied these first 2 patches, but patches 3 and 4 I have already >> > applied to my char-misc-next tree, right? >> > >> > thanks, >> > >> > greg k-h >> >> I would expect you got a merge conflict from one of those. Using patch >> 3 and 4 in from this patchset should avoid that conflict if your >> eventual 4.15 branch is not based on your current char-misc-next >> branch. > > I've resolved the merge conflict so my char-misc-next branch should be > all caught up now. It would be wonderful if you could verify this. > > thanks, > > greg k-h I have not tested your branch directly, but the relevant code in char-misc-next is now identical to the code I tested. -- Arve Hjønnevåg