From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932350AbdJWSSz (ORCPT ); Mon, 23 Oct 2017 14:18:55 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:44430 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932329AbdJWSSy (ORCPT ); Mon, 23 Oct 2017 14:18:54 -0400 X-Google-Smtp-Source: ABhQp+QNDIXQNe2a3CaWWcw0Mt08xveTUP6a64GDXP7HsvrbA5Tc8nxpVbeFSoAwKAmioF88ecWQJ7HfTl/m7Y/PfIA= MIME-Version: 1.0 In-Reply-To: <20171021081513.GA19354@kroah.com> References: <20171021005902.59586-1-sherryy@android.com> <20171021005902.59586-2-sherryy@android.com> <20171021081513.GA19354@kroah.com> From: =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= Date: Mon, 23 Oct 2017 11:18:52 -0700 Message-ID: Subject: Re: [PATCH v2 1/4] android: binder: Don't get mm from task To: Greg Kroah-Hartman Cc: Sherry Yang , LKML , "open list:ANDROID DRIVERS" , Riley Andrews , Martijn Coenen , Todd Kjos Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9NIJ1DT022574 On Sat, Oct 21, 2017 at 1:15 AM, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote: >> Use binder_alloc struct's mm_struct rather than getting >> a reference to the mm struct through get_task_mm to >> avoid a potential deadlock between lru lock, task lock and >> dentry lock, since a thread can be holding the task lock >> and the dentry lock while trying to acquire the lru lock. >> >> Acked-by: Arve Hjønnevåg >> Signed-off-by: Sherry Yang >> --- >> drivers/android/binder_alloc.c | 22 +++++++++------------- >> drivers/android/binder_alloc.h | 1 - >> 2 files changed, 9 insertions(+), 14 deletions(-) > > I've applied these first 2 patches, but patches 3 and 4 I have already > applied to my char-misc-next tree, right? > > thanks, > > greg k-h I would expect you got a merge conflict from one of those. Using patch 3 and 4 in from this patchset should avoid that conflict if your eventual 4.15 branch is not based on your current char-misc-next branch. -- Arve Hjønnevåg