From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759405Ab2CGECB (ORCPT ); Tue, 6 Mar 2012 23:02:01 -0500 Received: from mail-gx0-f174.google.com ([209.85.161.174]:44335 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759062Ab2CGEB7 convert rfc822-to-8bit (ORCPT ); Tue, 6 Mar 2012 23:01:59 -0500 MIME-Version: 1.0 In-Reply-To: <1331087818-9942-2-git-send-email-ruan.zhengwang@gmail.com> References: <1331087818-9942-1-git-send-email-ruan.zhengwang@gmail.com> <1331087818-9942-2-git-send-email-ruan.zhengwang@gmail.com> Date: Tue, 6 Mar 2012 20:01:58 -0800 Message-ID: Subject: Re: [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Zhengwang Ruan Cc: gregkh@linuxfoundation.org, chris+android@zenthought.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 6, 2012 at 6:36 PM, Zhengwang Ruan wrote: > GCC warns 'buffer' and 'buffer_size' are used with being uninitialized, and > 'buffer' is used as returned value, and 'buffer_size' is initialized using > uninitialized_var to clear warning. Why do you clear the warning on buffer_size with uninitialized_var() but not on buffer? Neither variable is used before being initialized. -- Arve Hjønnevåg From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= Date: Wed, 07 Mar 2012 04:01:58 +0000 Subject: Re: [PATCH 2/2 v2] Staging:android: Initialise buffer and buffer_size before used Message-Id: List-Id: References: <1331087818-9942-1-git-send-email-ruan.zhengwang@gmail.com> <1331087818-9942-2-git-send-email-ruan.zhengwang@gmail.com> In-Reply-To: <1331087818-9942-2-git-send-email-ruan.zhengwang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Zhengwang Ruan Cc: gregkh@linuxfoundation.org, chris+android@zenthought.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Mar 6, 2012 at 6:36 PM, Zhengwang Ruan w= rote: > GCC warns 'buffer' and 'buffer_size' are used with being uninitialized, a= nd > 'buffer' is used as returned value, and 'buffer_size' is initialized using > uninitialized_var to clear warning. Why do you clear the warning on buffer_size with uninitialized_var() but not on buffer? Neither variable is used before being initialized. --=20 Arve Hj=F8nnev=E5g -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html