All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Miao <eric.y.miao@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pwm: pxa: Remove PWM_ID_BASE macro
Date: Mon, 1 Apr 2013 17:09:51 +0800	[thread overview]
Message-ID: <CAMPhdO9H3PzYczEYELuTk+uz5mKd8RoQiZEAQBoQTqumLWtCVA@mail.gmail.com> (raw)
In-Reply-To: <1364802082.6252.1.camel@phoenix>

On Mon, Apr 1, 2013 at 3:41 PM, Axel Lin <axel.lin@ingics.com> wrote:
> PWM_ID_BASE() is not used after convert to PWM framework, remove it.
> Also update driver_data field of struct platform_device_id accordingly.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> This is v2 of [PATCH] pwm: pxa: Use driver_data field to store pwm_nr.
> I change the subject line to meet the change in v2.
>
>  drivers/pwm/pwm-pxa.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
> index b789882..dee6ab55 100644
> --- a/drivers/pwm/pwm-pxa.c
> +++ b/drivers/pwm/pwm-pxa.c
> @@ -23,14 +23,13 @@
>  #include <asm/div64.h>
>
>  #define HAS_SECONDARY_PWM      0x10
> -#define PWM_ID_BASE(d)         ((d) & 0xf)
>
>  static const struct platform_device_id pwm_id_table[] = {
>         /*   PWM    has_secondary_pwm? */
>         { "pxa25x-pwm", 0 },
> -       { "pxa27x-pwm", 0 | HAS_SECONDARY_PWM },
> -       { "pxa168-pwm", 1 },
> -       { "pxa910-pwm", 1 },
> +       { "pxa27x-pwm", HAS_SECONDARY_PWM },
> +       { "pxa168-pwm", 0 },
> +       { "pxa910-pwm", 0 },
>         { },
>  };
>  MODULE_DEVICE_TABLE(platform, pwm_id_table);

Looks good to me, Acked-by: Eric Miao <eric.y.miao@gmail.com>

  reply	other threads:[~2013-04-01  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01  7:41 [PATCH] pwm: pxa: Remove PWM_ID_BASE macro Axel Lin
2013-04-01  9:09 ` Eric Miao [this message]
2013-04-02  9:38 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMPhdO9H3PzYczEYELuTk+uz5mKd8RoQiZEAQBoQTqumLWtCVA@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=axel.lin@ingics.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.