From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AAEDC433F5 for ; Tue, 11 Jan 2022 09:27:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ACEA6B0072; Tue, 11 Jan 2022 04:27:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95D426B0073; Tue, 11 Jan 2022 04:27:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 825666B0074; Tue, 11 Jan 2022 04:27:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 732536B0072 for ; Tue, 11 Jan 2022 04:27:18 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1C944181D1306 for ; Tue, 11 Jan 2022 09:27:18 +0000 (UTC) X-FDA: 79017477756.20.FFB0C18 Received: from mail.archlinux.org (mail.archlinux.org [95.216.189.61]) by imf29.hostedemail.com (Postfix) with ESMTP id 4E93712000D for ; Tue, 11 Jan 2022 09:27:17 +0000 (UTC) X-Gm-Message-State: AOAM533TrCsvyoTO/lNWl6ljAr9FbZ8T7Zjdoiewk6f4WfT00uNGluUX TzkZtPKiBjp3HKIuAC6KC6uOR/ox+pS3/4JPQtI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=archlinux.org; s=dkim-rsa; t=1641893235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A2z9ULSlPqzgpvlSxaZcM9SLKKokanMKIf4ivHKCzRc=; b=aCs0qvaxOxDffkHBWDzTvoTUyaDLMpVN7ym1H+8Wftv1tj5pTGDAExOzllGIGuev98aSbl 6A9wayYNHTwgmQzH9HffVhvC0ObChfK+uI8bJjt3+yOP2fMijEtuDZAfA08O9dlMZXJtbB oCckAgVEJI2QdT6Jn52Okq5mImgFIuLacE0OgQHWy66sbgry4LF+RBhlY5WpQc+LHzuFGM TXorj9PN3PF02deVQ3Hc27NCuQlPqxbAuVMk/Ne3OoHw8FBh2QeyIpZxrljR3m7kY2Igu0 Tuua1rjWtjFk/4AXMNvU7kQlK6cHFTzqfTHQFbUrNbcXLG+GeGx6Y44CoWbjjra1Mp2Ir4 wDyuIklKNxgHfL9lX6MyVTqzof2vfjrEjitG6SbBL69gMB9C5/HGioNe6BQeHtd6TFoxHh pDZ52hUKn4nE0NQpLNA1KHuBEBT/UveAEU7VLRGR0tfxn3FgLcpSyHQCmJudnw57ZFlQ8+ l7mORXCGqxwm1UsGEgzIcsdPjQTcemwK+Til2Cq9UwXco3ZBnv/Y8a4gwsLuBc+ZInaolk GqaGKwiXupLZk61ZxEXoY/MCrslSILjtZ7WsqTMIus8pcxe/FutWnG+Mqr7z15lIqz909U EkFbp79FqbhLfeBGu9qY3ozS12pWgmy3y0rzzULjMHVHoyl7fyAcs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=archlinux.org; s=dkim-ed25519; t=1641893235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A2z9ULSlPqzgpvlSxaZcM9SLKKokanMKIf4ivHKCzRc=; b=4Z+nVwdD02i5mps5D2A/9juQ/G//F/ysOfOf2siLQXrxMwg5JPo79tgHp9JS5CajaroRyz ZV9DPNbfr0EqvlDw== X-Google-Smtp-Source: ABdhPJx0bZMPYajcwmbWcx5Z9xNGE5aBKOUf6+/FenxinSlLSzMV2NnOI8/54Gn7HYY6RrEm3BIsreaU2FO+LkiNhA8= X-Received: by 2002:a17:907:94ce:: with SMTP id dn14mr2822773ejc.85.1641893224260; Tue, 11 Jan 2022 01:27:04 -0800 (PST) MIME-Version: 1.0 References: <20220104202227.2903605-1-yuzhao@google.com> In-Reply-To: From: "Jan Alexander Steffens (heftig)" Date: Tue, 11 Jan 2022 10:26:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework To: Yu Zhao Cc: Alexandre Frade , Brian Geffon , Daniel Byrne , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Jan Alexander Steffens , Shuang Zhai , Sofia Trinh , Steven Barrett , Suleiman Souhlal , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Andrew Morton , Linus Torvalds Content-Type: multipart/alternative; boundary="0000000000006429c105d54b0e5f" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4E93712000D X-Stat-Signature: i3oq9c7eo878k997rocsts8tzj95ran9 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=archlinux.org header.s=dkim-rsa header.b=aCs0qvax; dkim=pass header.d=archlinux.org header.s=dkim-ed25519 header.b=4Z+nVwdD; dmarc=pass (policy=none) header.from=archlinux.org; spf=pass (imf29.hostedemail.com: domain of heftig@archlinux.org designates 95.216.189.61 as permitted sender) smtp.mailfrom=heftig@archlinux.org X-HE-Tag: 1641893237-461732 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000006429c105d54b0e5f Content-Type: text/plain; charset="UTF-8" On Tue, Jan 11, 2022 at 9:41 AM Yu Zhao wrote: > On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote: > > > TLDR > > > ==== > > > The current page reclaim is too expensive in terms of CPU usage and it > > > often makes poor choices about what to evict. This patchset offers an > > > alternative solution that is performant, versatile and > > > straightforward. > > > > > > > > > Summery > > > ======= > > > The facts are: > > > 1. The independent lab results and the real-world applications > > > indicate substantial improvements; there are no known regressions. > > > 2. Thrashing prevention, working set estimation and proactive reclaim > > > work out of the box; there are no equivalent solutions. > > > 3. There is a lot of new code; nobody has demonstrated smaller changes > > > with similar effects. > > > > > > Our options, accordingly, are: > > > 1. Given the amount of evidence, the reported improvements will likely > > > materialize for a wide range of workloads. > > > 2. Gauging the interest from the past discussions [14][15][16], the > > > new features will likely be put to use for both personal computers > > > and data centers. > > > 3. Based on Google's track record, the new code will likely be well > > > maintained in the long term. It'd be more difficult if not > > > impossible to achieve similar effects on top of the existing > > > design. > > > > Hi Andrew, Linus, > > > > Can you please take a look at this patchset and let me know if it's > > 5.17 material? > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. > > Downstream kernel maintainers who have been carrying MGLRU for more than > 3 versions, can you please provide your Acked-by tags? > > Having this patchset in the mainline will make your job easier :) > > Alexandre - the XanMod Kernel maintainer > https://xanmod.org > > Brian - the Chrome OS kernel memory maintainer > https://www.chromium.org > > Jan - the Arch Linux Zen kernel maintainer > https://archlinux.org > > Steven - the Liquorix kernel maintainer > https://liquorix.net > > Suleiman - the ARCVM (Android downstream) kernel memory maintainer > > https://chromium.googlesource.com/chromiumos/third_party/kernel > > Also my gratitude to those who have helped test MGLRU: > > Daniel - researcher at Michigan Tech > benchmarked memcached > > Holger - who has been testing/patching/contributing to various > subsystems since ~2008 > > Shuang - researcher at University of Rochester > benchmarked fio and provided a report > > Sofia - EDI https://www.edi.works > benchmarked the top eight memory hogs and provided reports > > Can you please provide your Tested-by tags? This will ensure the credit > for your contributions. > > Thanks! > Sure. Thanks for your work! Once it hits mainline, MGLRU will also be enabled in the vanilla Arch kernel. Acked-by: Jan Alexander Steffens (heftig) --0000000000006429c105d54b0e5f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jan 11, 2022 at 9:41 AM Yu Zhao &= lt;yuzhao@google.com> wrote:
On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote:
> On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote:
> > TLDR
> > =3D=3D=3D=3D
> > The current page reclaim is too expensive in terms of CPU usage a= nd it
> > often makes poor choices about what to evict. This patchset offer= s an
> > alternative solution that is performant, versatile and
> > straightforward.
>
> <snipped>
>
> > Summery
> > =3D=3D=3D=3D=3D=3D=3D
> > The facts are:
> > 1. The independent lab results and the real-world applications > >=C2=A0 =C2=A0 indicate substantial improvements; there are no know= n regressions.
> > 2. Thrashing prevention, working set estimation and proactive rec= laim
> >=C2=A0 =C2=A0 work out of the box; there are no equivalent solutio= ns.
> > 3. There is a lot of new code; nobody has demonstrated smaller ch= anges
> >=C2=A0 =C2=A0 with similar effects.
> >
> > Our options, accordingly, are:
> > 1. Given the amount of evidence, the reported improvements will l= ikely
> >=C2=A0 =C2=A0 materialize for a wide range of workloads.
> > 2. Gauging the interest from the past discussions [14][15][16], t= he
> >=C2=A0 =C2=A0 new features will likely be put to use for both pers= onal computers
> >=C2=A0 =C2=A0 and data centers.
> > 3. Based on Google's track record, the new code will likely b= e well
> >=C2=A0 =C2=A0 maintained in the long term. It'd be more diffic= ult if not
> >=C2=A0 =C2=A0 impossible to achieve similar effects on top of the = existing
> >=C2=A0 =C2=A0 design.
>
> Hi Andrew, Linus,
>
> Can you please take a look at this patchset and let me know if it'= s
> 5.17 material?
>
> My goal is to get it merged asap so that users can reap the benefits > and I can push the sequels. Please examine the data provided -- I
> think the unprecedented coverage and the magnitude of the improvements=
> warrant a green light.

Downstream kernel maintainers who have been carrying MGLRU for more than 3 versions, can you please provide your Acked-by tags?

Having this patchset in the mainline will make your job easier :)

=C2=A0 =C2=A0Alexandre - the XanMod Kernel maintainer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://xanmod.org

=C2=A0 =C2=A0Brian=C2=A0 =C2=A0 =C2=A0- the Chrome OS kernel memory maintai= ner
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://www.chromium.= org

=C2=A0 =C2=A0Jan=C2=A0 =C2=A0 =C2=A0 =C2=A0- the Arch Linux Zen kernel main= tainer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://archlinux.org

=C2=A0 =C2=A0Steven=C2=A0 =C2=A0 - the Liquorix kernel maintainer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://liquorix.net<= br>
=C2=A0 =C2=A0Suleiman=C2=A0 - the ARCVM (Android downstream) kernel memory = maintainer
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://chromium.googlesource.com/chromiumos/third_party/= kernel

Also my gratitude to those who have helped test MGLRU:

=C2=A0 =C2=A0Daniel - researcher at Michigan Tech
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 benchmarked memcached

=C2=A0 =C2=A0Holger - who has been testing/patching/contributing to various=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 subsystems since ~2008

=C2=A0 =C2=A0Shuang - researcher at University of Rochester
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 benchmarked fio and provided a re= port

=C2=A0 =C2=A0Sofia=C2=A0 - EDI https://www.edi.works
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 benchmarked the top eight memory = hogs and provided reports

Can you please provide your Tested-by tags? This will ensure the credit
for your contributions.

Thanks!

Sure. Thanks for your work! Onc= e it hits mainline, MGLRU will also
be enabled in the vanilla Arc= h kernel.

Acked-by: Jan Alexander Steffens (he= ftig) <heftig@archlinux.org&= gt;

--0000000000006429c105d54b0e5f--