From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shilimkar, Santosh" Subject: Re: [PATCH] ARM: OMAP4: Fix array size for irq_target_cpu Date: Wed, 5 Sep 2012 10:28:45 +0530 Message-ID: References: <20120905000309.GW1303@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:60482 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897Ab2IEE7H (ORCPT ); Wed, 5 Sep 2012 00:59:07 -0400 Received: by ied7 with SMTP id 7so508025ied.1 for ; Tue, 04 Sep 2012 21:59:06 -0700 (PDT) In-Reply-To: <20120905000309.GW1303@atomide.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Cousson, Benoit" On Wed, Sep 5, 2012 at 5:33 AM, Tony Lindgren wrote: > > If NR_IRQS is less than MAX_IRQS, we end up writing past the > irq_target_cpu array in omap_wakeupgen_init(): > > /* Associate all the IRQs to boot CPU like GIC init does. */ > for (i = 0; i < max_irqs; i++) > irq_target_cpu[i] = boot_cpu; > > This can happen if SPARSE_IRQ is enabled as by default NR_IRQS is > set to 16. Without this patch we're overwriting other data during > the boot. > > Signed-off-by: Tony Lindgren > Looks good. Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Shilimkar, Santosh) Date: Wed, 5 Sep 2012 10:28:45 +0530 Subject: [PATCH] ARM: OMAP4: Fix array size for irq_target_cpu In-Reply-To: <20120905000309.GW1303@atomide.com> References: <20120905000309.GW1303@atomide.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 5, 2012 at 5:33 AM, Tony Lindgren wrote: > > If NR_IRQS is less than MAX_IRQS, we end up writing past the > irq_target_cpu array in omap_wakeupgen_init(): > > /* Associate all the IRQs to boot CPU like GIC init does. */ > for (i = 0; i < max_irqs; i++) > irq_target_cpu[i] = boot_cpu; > > This can happen if SPARSE_IRQ is enabled as by default NR_IRQS is > set to 16. Without this patch we're overwriting other data during > the boot. > > Signed-off-by: Tony Lindgren > Looks good. Acked-by: Santosh Shilimkar