From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755874Ab2D0GVW (ORCPT ); Fri, 27 Apr 2012 02:21:22 -0400 Received: from na3sys009aog114.obsmtp.com ([74.125.149.211]:59520 "EHLO na3sys009aog114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753491Ab2D0GVU convert rfc822-to-8bit (ORCPT ); Fri, 27 Apr 2012 02:21:20 -0400 MIME-Version: 1.0 In-Reply-To: <878vhi9qj8.fsf@ti.com> References: <20120425025637.7832.14013.stgit@notabene.brown> <20120425030524.7832.52047.stgit@notabene.brown> <878vhi9qj8.fsf@ti.com> From: "Shilimkar, Santosh" Date: Fri, 27 Apr 2012 11:50:58 +0530 Message-ID: Subject: Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. To: Kevin Hilman Cc: NeilBrown , Tony Lindgren , Russell King , Samuel Ortiz , Thomas Gleixner , "Rafael J. Wysocki" , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2012 at 2:09 AM, Kevin Hilman wrote: > NeilBrown writes: > [...] > > From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001 > From: NeilBrown > Date: Wed, 25 Apr 2012 13:05:24 +1000 > Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. > > Without an ->irq_set_wake() method in an irq_chip, calls to > enable_irq_wake() will fail.  This also causes these interrupts to not > be able to abort suspend (via check_wakeup_irqs() in late suspend.) > > Currently, we don't implement ->irq_set_wake() for INTC interrupts > because they default to be wakeup enabled by setting the GRPSEL bits > in PM init.  Even though there is no ->irq_set_wake(), we want > enable_irq_wake() to succeed so these interrupts can abort suspend > when necessary. > > To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC > interrupts which avoids trying to check irq_chip->irq_set_wake() > and failing when it doesn't exist. > > Longer term, we need to implement ->irq_set_wake() for the INTC > which can manage the appropriate GRPSEL bits. > > Signed-off-by: NeilBrown > [khilman@ti.com: rework changelog] > Signed-off-by: Kevin Hilman > --- Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shilimkar, Santosh" Subject: Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. Date: Fri, 27 Apr 2012 11:50:58 +0530 Message-ID: References: <20120425025637.7832.14013.stgit@notabene.brown> <20120425030524.7832.52047.stgit@notabene.brown> <878vhi9qj8.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog131.obsmtp.com ([74.125.149.247]:43914 "EHLO na3sys009aog131.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753901Ab2D0GVU convert rfc822-to-8bit (ORCPT ); Fri, 27 Apr 2012 02:21:20 -0400 Received: by qcsk26 with SMTP id k26so216558qcs.40 for ; Thu, 26 Apr 2012 23:21:18 -0700 (PDT) In-Reply-To: <878vhi9qj8.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: NeilBrown , Tony Lindgren , Russell King , Samuel Ortiz , Thomas Gleixner , "Rafael J. Wysocki" , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org On Fri, Apr 27, 2012 at 2:09 AM, Kevin Hilman wrote: > NeilBrown writes: > [...] > > From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 200= 1 > From: NeilBrown > Date: Wed, 25 Apr 2012 13:05:24 +1000 > Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC inte= rrupts. > > Without an ->irq_set_wake() method in an irq_chip, calls to > enable_irq_wake() will fail. =A0This also causes these interrupts to = not > be able to abort suspend (via check_wakeup_irqs() in late suspend.) > > Currently, we don't implement ->irq_set_wake() for INTC interrupts > because they default to be wakeup enabled by setting the GRPSEL bits > in PM init. =A0Even though there is no ->irq_set_wake(), we want > enable_irq_wake() to succeed so these interrupts can abort suspend > when necessary. > > To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC > interrupts which avoids trying to check irq_chip->irq_set_wake() > and failing when it doesn't exist. > > Longer term, we need to implement ->irq_set_wake() for the INTC > which can manage the appropriate GRPSEL bits. > > Signed-off-by: NeilBrown > [khilman@ti.com: rework changelog] > Signed-off-by: Kevin Hilman > --- Acked-by: Santosh Shilimkar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Shilimkar, Santosh) Date: Fri, 27 Apr 2012 11:50:58 +0530 Subject: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. In-Reply-To: <878vhi9qj8.fsf@ti.com> References: <20120425025637.7832.14013.stgit@notabene.brown> <20120425030524.7832.52047.stgit@notabene.brown> <878vhi9qj8.fsf@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Apr 27, 2012 at 2:09 AM, Kevin Hilman wrote: > NeilBrown writes: > [...] > > From 644742ddae59731bc10aacde94645d7c49ca5ecd Mon Sep 17 00:00:00 2001 > From: NeilBrown > Date: Wed, 25 Apr 2012 13:05:24 +1000 > Subject: [PATCH] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. > > Without an ->irq_set_wake() method in an irq_chip, calls to > enable_irq_wake() will fail. ?This also causes these interrupts to not > be able to abort suspend (via check_wakeup_irqs() in late suspend.) > > Currently, we don't implement ->irq_set_wake() for INTC interrupts > because they default to be wakeup enabled by setting the GRPSEL bits > in PM init. ?Even though there is no ->irq_set_wake(), we want > enable_irq_wake() to succeed so these interrupts can abort suspend > when necessary. > > To fix, set IRQCHIP_SKIP_SET_WAKE flag for all the INTC > interrupts which avoids trying to check irq_chip->irq_set_wake() > and failing when it doesn't exist. > > Longer term, we need to implement ->irq_set_wake() for the INTC > which can manage the appropriate GRPSEL bits. > > Signed-off-by: NeilBrown > [khilman at ti.com: rework changelog] > Signed-off-by: Kevin Hilman > --- Acked-by: Santosh Shilimkar