From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 247B8C678D4 for ; Mon, 6 Mar 2023 09:59:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbjCFJ7n (ORCPT ); Mon, 6 Mar 2023 04:59:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbjCFJ7l (ORCPT ); Mon, 6 Mar 2023 04:59:41 -0500 Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F276311169 for ; Mon, 6 Mar 2023 01:59:33 -0800 (PST) Received: by mail-ua1-x934.google.com with SMTP id n4so5986595ual.13 for ; Mon, 06 Mar 2023 01:59:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; t=1678096773; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mYIx7+Ak5uvLBEiqCaz2EjTEv5YVga1eqk3WlIV6f4M=; b=zK2NCcCpt9UU5XWW7P556fwgVJnEZEkgL1VUMcs6Mj43IYOEvoEhfp8gfGUsPfLC9y rr++bTyCnBcdN2dngclReRJLaxoST8UztHhb1fDmgWvgza6vB+TGcRfhIZnGtRSmxWAH 1CVAD5hZIQVINYG5pgNlKMDawgjanCiHOlNjBOd0Fuk+W/0c+b4uiCC8Xb8KXBnI095x 8QLYEPPLxrfg3p8bJIMPf18V36pTcBfCfQstjYus6E0Iq0L5ShKu8Tzt04xYxOeI4YvW nDIag/4yGtMlZV2g1dzKtMLxiEvkUPlPuFxOlgkxt4MZrtxvdOozHO6rLF0cmXE46pon ntHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678096773; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mYIx7+Ak5uvLBEiqCaz2EjTEv5YVga1eqk3WlIV6f4M=; b=V7I8oDtfLNM2tatR5zcEqhiHMjB+6zA33xYOv29Tt04xQOzMw7ZsHhheUXjBm5vMjO E8h8iFVCLyDoVj5mDQ/RRRtNTkpdVsbsuEvC8AbcHVp1pPry3sA4ffNAtxQiuqon6h8A 4Q02NHibfrGgC0mqbd2GmwkMdZ9IWAvjWGbOaH+3x01t1xtg0e0UUd14Tw3LPyf+pJPI jQNVjyC3QbChmjr4qFXqL8kE2Vm7CmdCWUpKGo4e5km/eSFunV/sgEJ4hAJHzeQKN9xE iaXH6V2VwYw2M0AdgSC/o/rJvPgRXJIl+LOwhT6P61D6CoEJT1VGVAqgvAe94ZouQuDk BWJg== X-Gm-Message-State: AO0yUKUs6mycCqkJAf9eO0lLsuQU5T8LehNTsIZsVA35xLTKERpW4qva anTXG5Px2xoiPT2sBA26GtUkb8Ii4gNI0aPdxWLkLQ== X-Google-Smtp-Source: AK7set86O3qpveh/FrKfkd3g2XuLPEZoo2Pf5KYA5+piHq15fqYnN6m4NMoJVYTy0MLAeYsy8UJPiyEY5BxmJfkfHGE= X-Received: by 2002:a1f:2dcb:0:b0:401:42e5:6d2e with SMTP id t194-20020a1f2dcb000000b0040142e56d2emr6188621vkt.1.1678096773108; Mon, 06 Mar 2023 01:59:33 -0800 (PST) MIME-Version: 1.0 References: <20230222121453.91915-1-nick.alcock@oracle.com> <20230222121453.91915-28-nick.alcock@oracle.com> In-Reply-To: <20230222121453.91915-28-nick.alcock@oracle.com> From: Bartosz Golaszewski Date: Mon, 6 Mar 2023 10:59:22 +0100 Message-ID: Subject: Re: [PATCH 27/27] kbuild, gpio: gpio-aspeed-sgpio: remove MODULE_LICENSE in non-modules To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Linus Walleij , Joel Stanley , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: On Wed, Feb 22, 2023 at 1:17=E2=80=AFPM Nick Alcock wrote: > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > Applied, thanks! Bart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A436C678D4 for ; Mon, 6 Mar 2023 10:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nprxYNRqujm2LniUmp+xmCYlCkFsx1rm7OKMB4uY6tU=; b=oHaGbKyH8/uc8J jJGJCuEWXHe4553gCFgA0iCnJcqnZULy9X0lNMDvUIuk3n9ybRgqMRM0wJ2v1XZY35jauAyoy71J4 gxe/WWfeAbiJB4cuAB9zkNYGnoHJZVWhBf0CzubmxZNmg++Fr3BlNESffJ5CBwpl4yd7ehGz24zgv hchdx2y2R1Y+Mh/jj3Dj3TkvRxogbQb0izF4wglY7JO2hK/N8KlEhrnPD3HC+DSyAA9jDSBDCptJa /CejYowuaHJiv/S9gKl4TRmNOhQQS7RKpXVeznPrG0UQ7Y04C/miU+oHilN3nm7blxXuWZ8SIm9sf 4C7NqdHE/Aqlg0GhG4BQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ7d3-00CBtt-A1; Mon, 06 Mar 2023 09:59:37 +0000 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ7d0-00CBso-H7 for linux-arm-kernel@lists.infradead.org; Mon, 06 Mar 2023 09:59:35 +0000 Received: by mail-ua1-x92d.google.com with SMTP id g19so6013799ual.4 for ; Mon, 06 Mar 2023 01:59:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; t=1678096773; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mYIx7+Ak5uvLBEiqCaz2EjTEv5YVga1eqk3WlIV6f4M=; b=zK2NCcCpt9UU5XWW7P556fwgVJnEZEkgL1VUMcs6Mj43IYOEvoEhfp8gfGUsPfLC9y rr++bTyCnBcdN2dngclReRJLaxoST8UztHhb1fDmgWvgza6vB+TGcRfhIZnGtRSmxWAH 1CVAD5hZIQVINYG5pgNlKMDawgjanCiHOlNjBOd0Fuk+W/0c+b4uiCC8Xb8KXBnI095x 8QLYEPPLxrfg3p8bJIMPf18V36pTcBfCfQstjYus6E0Iq0L5ShKu8Tzt04xYxOeI4YvW nDIag/4yGtMlZV2g1dzKtMLxiEvkUPlPuFxOlgkxt4MZrtxvdOozHO6rLF0cmXE46pon ntHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678096773; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mYIx7+Ak5uvLBEiqCaz2EjTEv5YVga1eqk3WlIV6f4M=; b=we4sGrL34ZWKE+zThKbDOGeiwfNfhBWoLtOd3Ie9fLNf8FYpVUAzu8Sm3DJRqE534B fUbE4kyN0nNEvgB08K8kbg0zkBp+PR1JpJJ5Iu7P3r8xVkWrcIK/AkL8Y8foVgYwO8FZ yG9V8i4bDEqPmAQ02U0pUxYIaOfJorMe2zGOhcWwGYEmeS+JRc921e/dgRabHYo334eI gbXfWxxswERQLWsYx02653+RIUUfSgXHbLq9IhMt84i9Jm11TSu943g/EHS4K2DDYHJR Ow+mNFmpde+/BGXdAbx4wA6nXU8QRMjG6nJyq3qmm7N226JOcubbjZpZynATOoGTh8KC OQKg== X-Gm-Message-State: AO0yUKUfomtiWSAVviHL3jEZc74psmF94wsmfOXNi7SCgYC1S/gqOFja WBMldc9hFVq1rghzW4anspiLuPD0PApM1rPmcwcd7Q== X-Google-Smtp-Source: AK7set86O3qpveh/FrKfkd3g2XuLPEZoo2Pf5KYA5+piHq15fqYnN6m4NMoJVYTy0MLAeYsy8UJPiyEY5BxmJfkfHGE= X-Received: by 2002:a1f:2dcb:0:b0:401:42e5:6d2e with SMTP id t194-20020a1f2dcb000000b0040142e56d2emr6188621vkt.1.1678096773108; Mon, 06 Mar 2023 01:59:33 -0800 (PST) MIME-Version: 1.0 References: <20230222121453.91915-1-nick.alcock@oracle.com> <20230222121453.91915-28-nick.alcock@oracle.com> In-Reply-To: <20230222121453.91915-28-nick.alcock@oracle.com> From: Bartosz Golaszewski Date: Mon, 6 Mar 2023 10:59:22 +0100 Message-ID: Subject: Re: [PATCH 27/27] kbuild, gpio: gpio-aspeed-sgpio: remove MODULE_LICENSE in non-modules To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Linus Walleij , Joel Stanley , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230306_015934_597867_018193DF X-CRM114-Status: GOOD ( 10.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBGZWIgMjIsIDIwMjMgYXQgMToxN+KAr1BNIE5pY2sgQWxjb2NrIDxuaWNrLmFsY29j a0BvcmFjbGUuY29tPiB3cm90ZToKPgo+IFNpbmNlIGNvbW1pdCA4YjQxZmM0NDU0ZSAoImtidWls ZDogY3JlYXRlIG1vZHVsZXMuYnVpbHRpbiB3aXRob3V0Cj4gTWFrZWZpbGUubW9kYnVpbHRpbiBv ciB0cmlzdGF0ZS5jb25mIiksIE1PRFVMRV9MSUNFTlNFIGRlY2xhcmF0aW9ucwo+IGFyZSB1c2Vk IHRvIGlkZW50aWZ5IG1vZHVsZXMuIEFzIGEgY29uc2VxdWVuY2UsIHVzZXMgb2YgdGhlIG1hY3Jv Cj4gaW4gbm9uLW1vZHVsZXMgd2lsbCBjYXVzZSBtb2Rwcm9iZSB0byBtaXNpZGVudGlmeSB0aGVp ciBjb250YWluaW5nCj4gb2JqZWN0IGZpbGUgYXMgYSBtb2R1bGUgd2hlbiBpdCBpcyBub3QgKGZh bHNlIHBvc2l0aXZlcyksIGFuZCBtb2Rwcm9iZQo+IG1pZ2h0IHN1Y2NlZWQgcmF0aGVyIHRoYW4g ZmFpbGluZyB3aXRoIGEgc3VpdGFibGUgZXJyb3IgbWVzc2FnZS4KPgo+IFNvIHJlbW92ZSBpdCBp biB0aGUgZmlsZXMgaW4gdGhpcyBjb21taXQsIG5vbmUgb2Ygd2hpY2ggY2FuIGJlIGJ1aWx0IGFz Cj4gbW9kdWxlcy4KPgoKQXBwbGllZCwgdGhhbmtzIQoKQmFydAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=