From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF53EC54EBC for ; Thu, 12 Jan 2023 09:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239922AbjALJFW (ORCPT ); Thu, 12 Jan 2023 04:05:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239926AbjALJE1 (ORCPT ); Thu, 12 Jan 2023 04:04:27 -0500 Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A499C52C6A for ; Thu, 12 Jan 2023 01:00:03 -0800 (PST) Received: by mail-vs1-xe2e.google.com with SMTP id d66so5951729vsd.9 for ; Thu, 12 Jan 2023 01:00:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gJ23laUZs6KjNqXK2XFx5Pb9Rdas9/1BF4+iDdlfsBo=; b=potZArkto3X9RVVqwM4wpGy6V4Wa/PD0N5YvFlZlzTqb1a3taJrikQ15ozA6/uHamB Vo4ZBvDEKy02cf18Vumh3WYXWg00mb9FSEvPVXuzEurzirwgBOCPGNMk6DqKRBwF1lWM zJ2k4P6XKKj0AN40zWG56gc5r4zuvoClmK+VpPEUeWV11IsyTbjmVbF/bJitI0cq/reE oT9qbJG5WATueXzsj2n87o6/xsfwyRWdsXHK3NF8tEDvIMnogjB7gq++af8yeFqKUtvz 9cA+46rt+zbMaDw9dM3F6XT/Smi3H/DrHY1agDBAUJ3e18avqvyWnNHQts9ROiOQls74 nMkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gJ23laUZs6KjNqXK2XFx5Pb9Rdas9/1BF4+iDdlfsBo=; b=V3XubXlyyvQ26VoBJrie5FifND05mgf0/wzvUh/tsZ+aieuuNJ9f+2QqrjtlPXdCwg jfkBWl8D7Lhyqh2O/Z/enYjQiyZ1MHArAIT56P+9/998EbOwQjs2PnbfciyhzJFXmhTt FPhhDIjOVQT0wh7gz/Q/OhwtuoetGFNfixUdmdgCCYzOJsYTdGCK1K304Zqv1IR/xZBz 8ecDSipim7FZSRTPvqIEsIoyFPoFk4fkZx1Y7poGYFdZyUaGEknRwg6LLdqwGSgJalZ6 DWyyFM5vs5rrTOGni9Rn2V7hYHEW1PSLzAyzBWAIGmawF+/VvPtvqhtlirTgduF+ubJ0 3z0w== X-Gm-Message-State: AFqh2kqJEohk+KUR3NRimwg2fwu0IdbWT9GrMRnDsrzx+v7PJox+tagY NWw4WsV0jgyXZaNzlUw4IT1T8OJtXKSkgmhVWrXDaQ== X-Google-Smtp-Source: AMrXdXviWdXojdoV3bFd8Xvbc8Okp/bpO2EoZvp3ZRkSFSZoAkdlPpXJVnkL8JErHGCzjRR9Pyodq2a1TjuQy9hfXnw= X-Received: by 2002:a67:e111:0:b0:3ce:8fa9:1ec4 with SMTP id d17-20020a67e111000000b003ce8fa91ec4mr5712836vsl.73.1673514002505; Thu, 12 Jan 2023 01:00:02 -0800 (PST) MIME-Version: 1.0 References: <20221229155030.418800-1-brgl@bgdev.pl> In-Reply-To: <20221229155030.418800-1-brgl@bgdev.pl> From: Bartosz Golaszewski Date: Thu, 12 Jan 2023 09:59:51 +0100 Message-ID: Subject: Re: [PATCH v6 00/14] serial: qcom-geni-serial: implement support for SE DMA To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Srinivas Kandagatla , Vinod Koul , Alex Elder , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Dec 29, 2022 at 4:50 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > The goal of this series is to update the qcom-geni-serial driver to use > the DMA mode of the QUPv3 serial engine. This is accomplished by the last > patch in the series. The previous ones contain either various tweaks, > reworks and refactoring or prepare the driver for adding DMA support. > > More work will follow on the serial engine in order to reduce code > redundancy among its users and add support for SE DMA to the qcom GENI > SPI driver. > > v5 -> v6: > - move patch 12/14 to the front of the series and mark it as a fix > - rebase on top of v6.2-rc1 (there were some updates to the driver) > > v4 -> v5: > - split patch 8/13 into two: one for splitting out the chunk sending code > and one for refactoring it (for easier review) > - when stopping uart: disable the irq first before stopping transfers in > progress, otherwise we rist rescheduling additional transfers after > interrupt > - make types even nore consistent in qcom_geni_serial_send_chunk_fifo() > > v3 -> v4: > - don't assign NULL (even cast) to variables of type dma_addr_t > - refactor checking the SE_GENI_STATUS into two inline functions > - drop min_t() in favor of regular min() after adding some consistency to types > - check if the abort command was successful and emit a message if not when > stopping TX in DMA mode > > v2 -> v3: > - drop devres patches from the series > > v1 -> v2: > - turn to_dev_uport() macro into a static inline function > - use CIRC_CNT_TO_END() and uart_xmit_advance() where applicable and don't > handle xmit->tail directly > - drop sizeof() where BYTES_PER_FIFO_WORD can be used > - further refactor qcom_geni_serial_handle_tx_fifo() > - collect review tags > > Bartosz Golaszewski (14): > tty: serial: qcom-geni-serial: stop operations in progress at shutdown > tty: serial: qcom-geni-serial: drop unneeded forward definitions > tty: serial: qcom-geni-serial: remove unused symbols > tty: serial: qcom-geni-serial: align #define values > tty: serial: qcom-geni-serial: improve the to_dev_port() macro > tty: serial: qcom-geni-serial: remove stray newlines > tty: serial: qcom-geni-serial: refactor qcom_geni_serial_isr() > tty: serial: qcom-geni-serial: remove unneeded tabs > tty: serial: qcom-geni-serial: split out the FIFO tx code > tty: serial: qcom-geni-serial: refactor > qcom_geni_serial_send_chunk_fifo() > tty: serial: qcom-geni-serial: drop the return value from handle_rx > tty: serial: qcom-geni-serial: use of_device_id data > soc: qcom-geni-se: add more symbol definitions > tty: serial: qcom-geni-serial: add support for serial engine DMA > > drivers/tty/serial/qcom_geni_serial.c | 626 +++++++++++++++++--------- > include/linux/qcom-geni-se.h | 3 + > 2 files changed, 413 insertions(+), 216 deletions(-) > > -- > 2.37.2 > It's been two weeks without any further comments, can this be picked up now into the serial tree? Bart