From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B5DC433FE for ; Wed, 1 Dec 2021 14:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350474AbhLAOnn (ORCPT ); Wed, 1 Dec 2021 09:43:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350485AbhLAOll (ORCPT ); Wed, 1 Dec 2021 09:41:41 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCBA5C061A30 for ; Wed, 1 Dec 2021 06:36:41 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id y12so102638573eda.12 for ; Wed, 01 Dec 2021 06:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ChSebfqCj5wevOY8wZg+W9iuB4H9eQB3dOPbSDOcmPA=; b=EanfV/bSpiu1gCOTcYKKTYSiCLzgoyOskJdrxQJqP9sheWREwa1fxafaUhFV+ww+Xz TQ3g16zyAWG2ADnSpwVqyLuc/X9eXn8dus4RgPRsnTnezVD+1rU06eRH8CqTTjycpU6d qdGFxlb++klnpgAQ2+EA3cM+W0ahw3elD13wd+LaHPnmF39+nsmaFzAlN2McrOvxFMK6 uUNkA6OQYAkDZSr0o0iBeSgpgktwep30ayJCf5L94OFMW5b7ZNNPcl1FgduvRDHe9KIq R98BUUDubR+rQMuWr037huoees5fKNvXZQZLe2ovprtCJUOYwI9OORbgrU74R6LFX9fO iTuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ChSebfqCj5wevOY8wZg+W9iuB4H9eQB3dOPbSDOcmPA=; b=VHbTePcTXgCCXlVX4NNss8RwQ9pJLb/xG21Zt/CC5qqJiWHOXEk6I/XrX6Z6p8TClx g2npAXHWyII/CBJYTFiVJC+GOccoQs2RGI3JPXOyWG15mxUWFnbvipY2GRjYvKR2tRVG otrE70ClDoVKD9b1d0il8y4ZKY7LDfP39f+9Ry19fRcmHn89y1LrQlXJRRPEKgK46OUs t5swJmW8hc9bcUtcWIOAtvUHrop5mwUHMGJcgazpDPgx72XIhtWjao9MVSE1R0UTDRmj GiCYahN0NfVSNW1iK9onrIAJe7d2vLexs0Sp2YKrWlFvP2P5f4IIWQ3S+o7oycZlOi4j FUtA== X-Gm-Message-State: AOAM532mupI+MJkl+9aOu4Odo9aZob4OZLZsiONkBYv1palE1tXKM2e+ +iv7h7T8A/D93ptGGpAq9xv2cd26qdOYPp9+iEVQgQ== X-Google-Smtp-Source: ABdhPJwJmjDcpB9YHDENf4MntkqZ++v6jJAxzsj6jdE8tXSrKbb9kv8Ct01EthGBUvv8+gntL+vjD5cn4cuDLYUbki8= X-Received: by 2002:a05:6402:354e:: with SMTP id f14mr8934573edd.245.1638369399803; Wed, 01 Dec 2021 06:36:39 -0800 (PST) MIME-Version: 1.0 References: <20211130154127.12272-1-brgl@bgdev.pl> <20211130154127.12272-3-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 1 Dec 2021 15:36:29 +0100 Message-ID: Subject: Re: [PATCH v11 2/6] gpiolib: allow to specify the firmware node in struct gpio_chip To: Andy Shevchenko Cc: Kent Gibson , Linus Walleij , Shuah Khan , Geert Uytterhoeven , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Dec 1, 2021 at 3:34 PM Andy Shevchenko wrote: > > On Wed, Dec 01, 2021 at 04:28:19PM +0200, Andy Shevchenko wrote: > > On Wed, Dec 01, 2021 at 02:53:42PM +0100, Bartosz Golaszewski wrote: > > > On Wed, Dec 1, 2021 at 2:40 PM Andy Shevchenko > > > wrote: > > > > On Wed, Dec 01, 2021 at 02:11:28PM +0100, Bartosz Golaszewski wrote: > > > > > On Tue, Nov 30, 2021 at 10:04 PM Bartosz Golaszewski wrote: > > > > ... > > > > > > > Let me maybe rephrase the problem: currently, for GPIO devices > > > > > instantiating multiple banks created outside of the OF or ACPI > > > > > frameworks (e.g. instantiated manually and configured using a > > > > > hierarchy of software nodes with a single parent swnode and a number > > > > > of child swnodes representing the children), it is impossible to > > > > > assign firmware nodes other than the one representing the top GPIO > > > > > device to the gpiochip child devices. > > > > > > > > > > In fact if we want to drop the OF APIs entirely from gpiolib - this > > > > > would be the right first step as for gpio-sim it actually replaces the > > > > > gc->of_node = some_of_node; assignment that OF-based drivers do for > > > > > sub-nodes defining banks and it does work with device-tree (I verified > > > > > that too) thanks to the fwnode abstraction layer. > > > > > > > > I still don't see how you set up hierarchy of primary/secondary fwnodes. > > > > > > > > And I don't like this change. It seems it band-aids some issue with fwnode > > > > usage. What the easiest way to reproduce the issue with your series applied > > > > (without this change)? > > > > > > Drop this patch and drop the line where the fwnode is assigned in > > > gpio-sim.c. Then probe the device and print the addresses of the > > > parent and child swnodes. See how they are the same and don't match > > > the swnode hierarchy we created. You can then apply this patch and see > > > how it becomes correct. > > > > Thanks. I will give a spin. > > > > Note, it seems I have to revert your older code first... > > Okay, I have to postpone because simple revert doesn't work for me. > Can you clean up the next, please and I can use it starting from tomorrow? > > > $ git tag --contains 5065e08e4ef3 > DONT-USE-next-20211105 > next-20211101 > next-20211102 > next-20211103 > next-20211104 > next-20211105 > next-20211106 > next-20211108 > next-20211109 > next-20211110 > next-20211111 > next-20211112 > next-20211115 > next-20211116 > next-20211117 > next-20211118 > next-20211123 > next-20211124 > next-20211125 > next-20211126 > next-20211129 > next-20211130 > next-20211201 > > -- > With Best Regards, > Andy Shevchenko > > None of this is in next, please use: https://github.com/brgl/linux/tree/topic/gpio-sim-v12 if you want a branch. I just thought you were going to simply apply these patches. Bart