All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Kent Gibson <warthog618@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Jack Winch <sunt.un.morcov@gmail.com>,
	Helmut Grohne <helmut.grohne@intenta.de>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2] treewide: rework struct gpiod_line_bulk
Date: Wed, 28 Oct 2020 17:26:51 +0100	[thread overview]
Message-ID: <CAMRc=McvhpgKdyV4W8pN6cy5UyQi2jZWvaTPKBDumo0YsMefrA@mail.gmail.com> (raw)
In-Reply-To: <20201028150322.GA221014@sol>

On Wed, Oct 28, 2020 at 4:03 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> On Wed, Oct 28, 2020 at 02:19:05PM +0100, Bartosz Golaszewski wrote:
> > On Wed, Oct 28, 2020 at 10:39 AM Kent Gibson <warthog618@gmail.com> wrote:
> > >
> > > On Tue, Oct 27, 2020 at 10:17:15AM +0100, Bartosz Golaszewski wrote:
> > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > >
> > >
> > > Subject should be prefixed with [libgpiod] according to the README ;).
> > >
> >
> > Oh come on! :)
> >
> > [snip]
> >
> > >
> > > If you replace the gpiod_line_bulk_iter_foreach_line() here with
> > > manually looping over the bulk lines then everything from A to B above
> > > can be dropped.
> > >
> >
> > Something is telling me that dedicated iterators are more elegant. But
> > I guess we can do everything manually for now and see about that
> > later. Fair enough, I'll drop it.
> >
>
> Good thing I'm here to let you know that little voice is wrong :).
>
> I've got a couple of commits in my working tree[1] that apply to your
> patch and drop the iters as I've suggested if you'd like to compare.
>
> Cheers,
> Kent.
>
> [1] https://github.com/warthog618/libgpiod/commits/for-v2

Would you mind if I squashed those changes into my patch?

Bartosz

  reply	other threads:[~2020-10-28 21:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27  9:17 [PATCH v2] treewide: rework struct gpiod_line_bulk Bartosz Golaszewski
2020-10-28  9:39 ` Kent Gibson
2020-10-28 13:19   ` Bartosz Golaszewski
2020-10-28 15:03     ` Kent Gibson
2020-10-28 16:26       ` Bartosz Golaszewski [this message]
2020-10-28 23:07         ` Kent Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=McvhpgKdyV4W8pN6cy5UyQi2jZWvaTPKBDumo0YsMefrA@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=geert@linux-m68k.org \
    --cc=helmut.grohne@intenta.de \
    --cc=linux-gpio@vger.kernel.org \
    --cc=sunt.un.morcov@gmail.com \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.