From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C21C43461 for ; Tue, 15 Sep 2020 13:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90D9321655 for ; Tue, 15 Sep 2020 13:19:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="Ao6JMC6M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbgIONTe (ORCPT ); Tue, 15 Sep 2020 09:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbgIONRd (ORCPT ); Tue, 15 Sep 2020 09:17:33 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49D5C06178A for ; Tue, 15 Sep 2020 06:16:55 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id t13so2918032ile.9 for ; Tue, 15 Sep 2020 06:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v/HlO2pz67e4hxYirmZqk4ySGJecTpWx3uH4onJVbvU=; b=Ao6JMC6MHz4vIH5oPcx8XvXMXNBpuT6aZgdgvKvyHV/hNMlBoELCsvdTJFmmq14gbE wpEde/KfyVyFa+9WwWJkJYfVu6a0Q3aJcrFAORKIbcdpmNJ2v9vG5QLHqNVDqT2mL71e 0YXAHgkC4RSoeJ2fQ0H4LNQ5DhFhFDiAX6dY7pFYVOS7ENh31SSkeYZhK+Y+PZ8GXtni it5g8WftJxlJ6qHd3exqCyuQIyIaqVW0k8SqqAOp7WiqgFAbXPp2vkFA7GJeDXi7QWuN 4Y0cLMfUJtcUKC9g6CzlkkBxSrMKYD2mmLINKs5X/rS/b0CeqJhOTjO/+4aMQTc3iy6N nSow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v/HlO2pz67e4hxYirmZqk4ySGJecTpWx3uH4onJVbvU=; b=PgKE8P15L+Hydfx2GLkOOEBFNwKmPIiIegqTW1/IaS3Jc1MLEniWYirhTyjUzKj01n DRmXHqcArheg9M7xdmbamE3RF4mKUYjPPGz7KD/a+u5s5IF3hJo7vQpcfuu5vMOcfwM0 G9r6V0vTZccNeSS3b3A5Inry8jnWZ7Ew+44gcMPzXLawWPWSKaU8gglZYsdEe/y1qVje OwKOLU6xZCuUITOCCT5fVb7IuynVeGgIuDhiblNJWdMSzPfMu1NTHGTJkmCLcLWyn8FL og87kPFV1DmfAvIgs/BaENVg4FL17vwcHy0J5CBHkGjbisxvnGxG27bXH3EUQKW6E7yy Gj7w== X-Gm-Message-State: AOAM532Pths4LVy3N0NCYDN+o/LUEqUKjAfIhFF7BZbmrS6cui6io4X/ d/6o2AnG+on6M+zKSeQxL31v6djvAzgAknxkW398cZE3guQ= X-Google-Smtp-Source: ABdhPJzSPncGLKmwONqIrR5yKoPLvcW5c4OXIAKLZmbI58H8i0gsT7/X+baLgsqUByC1c10NX7cSCvumNCkKi81cKhE= X-Received: by 2002:a92:c8c4:: with SMTP id c4mr16457759ilq.287.1600175813496; Tue, 15 Sep 2020 06:16:53 -0700 (PDT) MIME-Version: 1.0 References: <20200908125813.8809-1-brgl@bgdev.pl> <20200915131228.GX3956970@smile.fi.intel.com> In-Reply-To: <20200915131228.GX3956970@smile.fi.intel.com> From: Bartosz Golaszewski Date: Tue, 15 Sep 2020 15:16:42 +0200 Message-ID: Subject: Re: [PATCH 0/3] gpiolib: generalize GPIO line names property To: Andy Shevchenko Cc: Anders Roxell , Linus Walleij , Mika Westerberg , Kent Gibson , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , ACPI Devel Maling List , Bartosz Golaszewski , lkft-triage@lists.linaro.org, Linux-Next Mailing List , Stephen Rothwell Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Sep 15, 2020 at 3:12 PM Andy Shevchenko wrote: > > On Tue, Sep 15, 2020 at 02:01:56PM +0200, Anders Roxell wrote: > > On Tue, 8 Sep 2020 at 18:40, Bartosz Golaszewski wrote: > > > > > > From: Bartosz Golaszewski > > > > > > I initially sent this as part of the gpio-mockup overhaul but since > > > these patches are indepentent and the work on gpio-mockup may become > > > more complicated - I'm sending these separately. > > > > > > The only change is adding additional property helpers to count strings > > > in array. > > > > > > Bartosz Golaszewski (3): > > > device: property: add helpers to count items in string arrays > > > gpiolib: generalize devprop_gpiochip_set_names() for device properties > > > gpiolib: unexport devprop_gpiochip_set_names() > > Ha-ha, OF unittest is of_node centric. definitely there is no backed device. > > Bart, it seems we are stuck with fwnode interface. > Wait what?! This means the implementation is wrong - the whole concept of device properties is to be generic and to hide the underlying fwnode or OF properties. If anything we should fix device/base/property.c to fall back to OF. What is happening exactly? If all fwnode code compiled out? I'll try to give it a spin and see what can be done but I don't like that device_property_* functions fail if you have OF but not fwnode. Bart