All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled
Date: Wed, 13 Dec 2017 15:59:15 +0100	[thread overview]
Message-ID: <CAMRc=MdM=G=AP5My4KQ-kP_2xEHM_UPNYqEfPUO7aTAo6cULaA@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VcNcx0C2-cPNSxABg+VB+UGrf+GfEEfVZO3tHPbmLGznA@mail.gmail.com>

2017-12-13 15:54 GMT+01:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Wed, Dec 13, 2017 at 11:28 AM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>> User space can initiate concurrent access to regmap over debugfs and,
>> if the locking is disabled, we can't protect it. Don't create the
>> debugfs entries at all in this case.
>>
>> Suggested-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
>
>> +               dev_dbg(map->dev, "locking disabled - not creating debugfs entries\n");
>
> I dunno about level (OK debug seems good because we are still talking
> about debug), though message might be slightly confusing (if driver
> itself is using debugfs for its own purposes), so, I would suggest to
> add
> "regmap: locking...".
>
> --
> With Best Regards,
> Andy Shevchenko

Good point, I think "regmap locking disabled..." would be even better
in this case.

Thanks,
Bartosz

  reply	other threads:[~2017-12-13 14:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  9:28 [PATCH 0/3] regmap: follow-up for ("regmap: allow to disable all locking mechanisms") Bartosz Golaszewski
2017-12-13  9:28 ` [PATCH 1/3] regmap: rename regmap_lock_unlock_empty() to regmap_lock_unlock_none() Bartosz Golaszewski
2017-12-13  9:28 ` [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled Bartosz Golaszewski
2017-12-13 14:54   ` Andy Shevchenko
2017-12-13 14:59     ` Bartosz Golaszewski [this message]
2017-12-13 15:39   ` Mark Brown
2017-12-13 15:46     ` Bartosz Golaszewski
2017-12-13 16:00       ` Mark Brown
2017-12-13  9:28 ` [PATCH 3/3] regmap: duplicate the name string stored in regmap Bartosz Golaszewski
2017-12-13  9:32   ` Lars-Peter Clausen
2017-12-13  9:56     ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=MdM=G=AP5My4KQ-kP_2xEHM_UPNYqEfPUO7aTAo6cULaA@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.