From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753463AbdLMPqM (ORCPT ); Wed, 13 Dec 2017 10:46:12 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:37236 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753305AbdLMPqL (ORCPT ); Wed, 13 Dec 2017 10:46:11 -0500 X-Google-Smtp-Source: ACJfBosaKi02COq3TUklT37WfuqtCiDBMpxOQK73UxIqtTSJk7NsiO27ZDhsMBJm9n2h1y1uwbRFSu22ATOZnnj5CL8= MIME-Version: 1.0 In-Reply-To: <20171213153958.GK6416@sirena.org.uk> References: <20171213092812.26472-1-brgl@bgdev.pl> <20171213092812.26472-3-brgl@bgdev.pl> <20171213153958.GK6416@sirena.org.uk> From: Bartosz Golaszewski Date: Wed, 13 Dec 2017 16:46:10 +0100 Message-ID: Subject: Re: [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled To: Mark Brown Cc: Greg Kroah-Hartman , Linux Kernel Mailing List , Lars-Peter Clausen , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-12-13 16:39 GMT+01:00 Mark Brown : > On Wed, Dec 13, 2017 at 10:28:11AM +0100, Bartosz Golaszewski wrote: >> User space can initiate concurrent access to regmap over debugfs and, >> if the locking is disabled, we can't protect it. Don't create the >> debugfs entries at all in this case. > > I (probably unsurprisingly) prefer my version that I posted yesterday as > it gives us the trivial memory saving of not having the flag if debugfs > is disabled but more importantly from my point of view keeps the > interface to debugfs as function calls in the core. It went into spam in my mailbox for some reason, that's why I didn't see it. Yes, it looks better. I'll drop it from the series. Thanks, Bartosz