From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: alanx.chiang@intel.com, linux-i2c <linux-i2c@vger.kernel.org>,
andy.yeh@intel.com, Sakari Ailus <sakari.ailus@linux.intel.com>,
rajmohan.mani@intel.com,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] Add a property in at24.c
Date: Tue, 26 Jun 2018 14:36:01 +0200 [thread overview]
Message-ID: <CAMRc=Me511S4Qw_-SPNkpPXcby7rZApbgm9g2=W=irmy9Gsu3g@mail.gmail.com> (raw)
In-Reply-To: <ff4c668d0807657940a4cddc6f7eb63d19be327c.camel@linux.intel.com>
2018-06-26 14:14 GMT+02:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Tue, 2018-06-26 at 09:41 +0200, Bartosz Golaszewski wrote:
>> 2018-06-26 8:22 GMT+02:00 <alanx.chiang@intel.com>:
>> > From: "alanx.chiang" <alanx.chiang@intel.com>
>> >
>> > In at24.c, it uses 8-bit addressing by default. In this patch,
>> > add a property address-width that provides a flexible method to
>> > pass the information to the driver.
>> >
>> > alanx.chiang (2):
>> > dt-bindings: at24: Add address-width property
>> > eeprom: at24: Add support for address-width property
>> >
>> > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
>> > drivers/misc/eeprom/at24.c | 16
>> > ++++++++++++++++
>> > 2 files changed, 18 insertions(+)
>> >
>> > --
>> > 2.7.4
>> >
>>
>> What is your use case exactly? Do you have an EEPROM model that's not
>> yet supported explicitly in the driver? Why would you need this
>> option?
>
> The current at24 driver has no address width support, thus, reusing same
> (allocated) IDs (non-DT case) is hard.
>
Every supported compatible has the width already specified in its
corresponding chip data.
Bart
next prev parent reply other threads:[~2018-06-26 12:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 6:22 [PATCH v2 0/2] Add a property in at24.c alanx.chiang
2018-06-26 6:22 ` [PATCH v2 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-06-26 6:49 ` Sakari Ailus
2018-06-26 16:44 ` Rob Herring
2018-06-26 6:22 ` [PATCH v2 2/2] eeprom: at24: Add support for " alanx.chiang
2018-06-26 6:47 ` Sakari Ailus
2018-06-26 7:11 ` Chiang, AlanX
2018-06-26 7:26 ` Sakari Ailus
2018-06-26 12:11 ` Andy Shevchenko
2018-06-26 7:41 ` [PATCH v2 0/2] Add a property in at24.c Bartosz Golaszewski
2018-06-26 12:14 ` Andy Shevchenko
2018-06-26 12:36 ` Bartosz Golaszewski [this message]
2018-06-26 13:23 ` Andy Shevchenko
2018-06-26 13:30 ` Bartosz Golaszewski
2018-06-26 15:48 ` Andy Shevchenko
2018-06-26 16:21 ` Yeh, Andy
2018-06-26 16:31 ` Mani, Rajmohan
2018-06-26 16:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Me511S4Qw_-SPNkpPXcby7rZApbgm9g2=W=irmy9Gsu3g@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=alanx.chiang@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy.yeh@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rajmohan.mani@intel.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.