From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6A1C10F0E for ; Fri, 12 Apr 2019 15:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB7E72171F for ; Fri, 12 Apr 2019 15:31:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="b3OWzac4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727429AbfDLPbY (ORCPT ); Fri, 12 Apr 2019 11:31:24 -0400 Received: from mail-it1-f193.google.com ([209.85.166.193]:38010 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726780AbfDLPbY (ORCPT ); Fri, 12 Apr 2019 11:31:24 -0400 Received: by mail-it1-f193.google.com with SMTP id f22so16192203ita.3 for ; Fri, 12 Apr 2019 08:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6qNz5Eb0sAHZK0rMj4FoBevon1ueumNJnBLLXCKm9Eg=; b=b3OWzac4ZfpvutCax0hKE9hzZiBKEhOypO2tNLYv29f3+gchpQgchpRPbksX4iWQoQ fD7uW2kotnAbkwgJqVNILpQGHUdX8indKazynzEl7Z4VKbmmexxg8DZdWBm5GKXOogyJ cinZz577vm1Wg/KvOajDd3dahVsQLoSnL7AYHcqANNZA/469PO9xYKtLdlvfTeDL47Rz axbo6bCELSTqP71Mnepf7WpnSCCCwGpFtc4lFU7+iHM4PQl5JLBNavSQ8RyPduiu7ehD UBmHj0kTAJ6SBTqA6IDvD0BGxK1UfRwMSkJPt+tFsQWhQuDSlbGYCp3BZTHDyBTbR4GM Z9xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6qNz5Eb0sAHZK0rMj4FoBevon1ueumNJnBLLXCKm9Eg=; b=F9evVJ4C6yC/byY4hS8eP2mjZ2L6CwGoJ0nj6VkicV6vEkK9CNGJ9VRxx0IJAskZY7 W49N8sMR74HyWa1zalIsJ+3hZgho4kAJx6crScGifTXRaykUi3kGpe80YigyXDymWsLb m+QOu1w3E/zN+2bREjSUel1Sw+Jr8LjrmBg3FfOb5AmsAdEiT3vnzcuHeB2+rqsEqVmM QFkASH50pYWitTSe1hKGKf9800ompoJ9vP5yadSEWaWgZOqkm0Wv2PQtPo/03cX1RhM9 ZRFmFdGBNqmuQ1RNWE6IHhggZ5dpq/5nJlPsSJs0zZ7Hz8mR17ydEhKbIE1bQ7e8ZSrK YeJg== X-Gm-Message-State: APjAAAUXvlPP0RaVfqke812oXUf0yrdTLyHbZpPlFccJL+mBFeYB+6re mk7DNBlR3KKDV0L5BZBYwcS3jpaV8aRTMLAx/X/F+w== X-Google-Smtp-Source: APXvYqz6lj8DwqaP9tDqwZnZ7cBTM2PGLmSHEp+M+qm795bQ8vs3hxrFv5Wk/VP8h5H8iRGOOMkutPRe5pAqItXbLrg= X-Received: by 2002:a24:ad2:: with SMTP id 201mr13045636itw.26.1555083083575; Fri, 12 Apr 2019 08:31:23 -0700 (PDT) MIME-Version: 1.0 References: <20190408075924.2284-1-brgl@bgdev.pl> <20190408075924.2284-2-brgl@bgdev.pl> <5f72a26b-428a-c50e-cb6a-7c888ea22329@ti.com> <3f6c906b-53b0-8284-bf4d-9b404f341e7b@ti.com> In-Reply-To: <3f6c906b-53b0-8284-bf4d-9b404f341e7b@ti.com> From: Bartosz Golaszewski Date: Fri, 12 Apr 2019 17:31:12 +0200 Message-ID: Subject: Re: [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT To: Sekhar Nori Cc: Kevin Hilman , Rob Herring , Mark Rutland , David Lechner , Adam Ford , Linux ARM , devicetree , Linux Kernel Mailing List , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pt., 12 kwi 2019 o 15:53 Sekhar Nori napisa=C5=82(a): > > On 12/04/19 5:41 PM, Bartosz Golaszewski wrote: > > pt., 12 kwi 2019 o 13:26 Sekhar Nori napisa=C5=82(a): > >> > >> Hi Bartosz, > >> > >> On 08/04/19 1:29 PM, Bartosz Golaszewski wrote: > >>> From: David Lechner > >>> > >>> This adds a cpu node and operating points to the common da850.dtsi fi= le. > >>> > >>> Additionally, a regulator is added to the LEGO EV3 board along with > >>> some board-specific CPU configuration. > >>> > >>> Regulators need to be hooked up on other boards to get them working. > >>> > >>> Signed-off-by: David Lechner > >>> Signed-off-by: Bartosz Golaszewski > >> > >> I remember you mentioning about some problems using OCHI and cpufreq > >> together. Are those resolved now? CPU PLL on DA850 can affect other > >> peripheral clock frequencies too. So enabling it should really be a > >> per-board decision. > >> > > > > The problems are still there. I've never been able to find the > > culprit, but it also occurs on TI BSP in the same way (a couple > > cpufreq transitions will make the controller unresponsive). > > Is that on LCDK as well? As I recall cpufreq was never enabled on LCDK > in TI BSP. > Yes, I just verified that the bug occurs on LCDK with patches from this ser= ies. > If the OHCI problem is present on LCDK, then there is a user visible > regression on mainline after this patch. Lets enable cpufreq in LCDK > only if all working peripherals keep working afterwards. > The OHCI driver doesn't register any cpufreq transition notifier callbacks. I can't really find anything in the datasheet, but I'm wondering if we shouldn't do something similar to what the driver for davinci i2c controller does. I'll try a couple things tomorrow. Bart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CE8C10F0E for ; Fri, 12 Apr 2019 15:31:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 708C221872 for ; Fri, 12 Apr 2019 15:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SoMCwKj5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="b3OWzac4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 708C221872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=knFPcNNc3qDWRLhGlz6CG0y7f8HkqpQROYR7X5+7i3Y=; b=SoMCwKj5WeA4Dy 88I1z/A3AxHyXZtKlx9OhJilYPnuSPF0rIpPc+WJDFSegs4CiBUTzwlBn4GgKVM55Kn5564yeHk+7 QDj1+jlFPeyPXF9gvvDGO9/jPHECzRLb6Rm8Nf7yzKdXwKs+vE4+x1K1gXvFliEykSlZBkOzeBUD/ zxneXiej+s/wodQXbcYAifmtEWDPfjL6z274VJK8sYlEfiTnQMJ1ejNkDHjwKo0Hvo8d0Ch/ErOiG /QVOvAuGmUHmoGMv3vi07PclvDd6L9sXqx8wwpu/jn95barq/U6Ef0tElkwimJV5xGotOh5sdVIi1 Ey++O4F/8ByzdI6WBWGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEy9L-0002RT-6y; Fri, 12 Apr 2019 15:31:31 +0000 Received: from mail-it1-x143.google.com ([2607:f8b0:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEy9G-0002NE-Kn for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2019 15:31:28 +0000 Received: by mail-it1-x143.google.com with SMTP id z17so750294itc.1 for ; Fri, 12 Apr 2019 08:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6qNz5Eb0sAHZK0rMj4FoBevon1ueumNJnBLLXCKm9Eg=; b=b3OWzac4ZfpvutCax0hKE9hzZiBKEhOypO2tNLYv29f3+gchpQgchpRPbksX4iWQoQ fD7uW2kotnAbkwgJqVNILpQGHUdX8indKazynzEl7Z4VKbmmexxg8DZdWBm5GKXOogyJ cinZz577vm1Wg/KvOajDd3dahVsQLoSnL7AYHcqANNZA/469PO9xYKtLdlvfTeDL47Rz axbo6bCELSTqP71Mnepf7WpnSCCCwGpFtc4lFU7+iHM4PQl5JLBNavSQ8RyPduiu7ehD UBmHj0kTAJ6SBTqA6IDvD0BGxK1UfRwMSkJPt+tFsQWhQuDSlbGYCp3BZTHDyBTbR4GM Z9xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6qNz5Eb0sAHZK0rMj4FoBevon1ueumNJnBLLXCKm9Eg=; b=aOa4cD8PHRzi7y9MjZTiYU5a5UThfr2xd4xpNENOd7xlySuBo+VpK1w6bEe5nxsgpM enCYdMbzCcFloDt3jdcLXTVT8CHLc6FrU4YYCk5L1NFFhNsSWXgZHlHyJhT6BKzZsj+r E3ocZ83HpZg2ElT0uRcVs7Je6b4/GmUsU1QPC/WRY7kw0ztxQu5STO72bgpSjn2p8/1c 7RXqEwSRW7khrE4Bu7jHlL1D+zqDz0iLkdAIxJTHOKbjDc/gS4dk7YiK98GSSVSowq3x WOzHc30oQ4hy10Tg/OBQ16Fl2vG+wcRR1J6s5gP8peNQDOyTu25MNo7Wkngel5Z2qHFH MNlQ== X-Gm-Message-State: APjAAAWv4Web9J1OoFWOojccpD/IYeBVV0Q1LYgCeIhmwOeSCtHtUgMb 2/6lEGxhKHkFBEpEiERGj7xnNHTj35jy9RgSc/X6zA== X-Google-Smtp-Source: APXvYqz6lj8DwqaP9tDqwZnZ7cBTM2PGLmSHEp+M+qm795bQ8vs3hxrFv5Wk/VP8h5H8iRGOOMkutPRe5pAqItXbLrg= X-Received: by 2002:a24:ad2:: with SMTP id 201mr13045636itw.26.1555083083575; Fri, 12 Apr 2019 08:31:23 -0700 (PDT) MIME-Version: 1.0 References: <20190408075924.2284-1-brgl@bgdev.pl> <20190408075924.2284-2-brgl@bgdev.pl> <5f72a26b-428a-c50e-cb6a-7c888ea22329@ti.com> <3f6c906b-53b0-8284-bf4d-9b404f341e7b@ti.com> In-Reply-To: <3f6c906b-53b0-8284-bf4d-9b404f341e7b@ti.com> From: Bartosz Golaszewski Date: Fri, 12 Apr 2019 17:31:12 +0200 Message-ID: Subject: Re: [PATCH v3 1/3] ARM: dts: da850: add cpu node and operating points to DT To: Sekhar Nori X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_083126_733388_E5A86B1F X-CRM114-Status: GOOD ( 19.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , David Lechner , Kevin Hilman , Linux Kernel Mailing List , Bartosz Golaszewski , Rob Herring , Adam Ford , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org cHQuLCAxMiBrd2kgMjAxOSBvIDE1OjUzIFNla2hhciBOb3JpIDxuc2VraGFyQHRpLmNvbT4gbmFw aXNhxYIoYSk6Cj4KPiBPbiAxMi8wNC8xOSA1OjQxIFBNLCBCYXJ0b3N6IEdvbGFzemV3c2tpIHdy b3RlOgo+ID4gcHQuLCAxMiBrd2kgMjAxOSBvIDEzOjI2IFNla2hhciBOb3JpIDxuc2VraGFyQHRp LmNvbT4gbmFwaXNhxYIoYSk6Cj4gPj4KPiA+PiBIaSBCYXJ0b3N6LAo+ID4+Cj4gPj4gT24gMDgv MDQvMTkgMToyOSBQTSwgQmFydG9zeiBHb2xhc3pld3NraSB3cm90ZToKPiA+Pj4gRnJvbTogRGF2 aWQgTGVjaG5lciA8ZGF2aWRAbGVjaG5vbG9neS5jb20+Cj4gPj4+Cj4gPj4+IFRoaXMgYWRkcyBh IGNwdSBub2RlIGFuZCBvcGVyYXRpbmcgcG9pbnRzIHRvIHRoZSBjb21tb24gZGE4NTAuZHRzaSBm aWxlLgo+ID4+Pgo+ID4+PiBBZGRpdGlvbmFsbHksIGEgcmVndWxhdG9yIGlzIGFkZGVkIHRvIHRo ZSBMRUdPIEVWMyBib2FyZCBhbG9uZyB3aXRoCj4gPj4+IHNvbWUgYm9hcmQtc3BlY2lmaWMgQ1BV IGNvbmZpZ3VyYXRpb24uCj4gPj4+Cj4gPj4+IFJlZ3VsYXRvcnMgbmVlZCB0byBiZSBob29rZWQg dXAgb24gb3RoZXIgYm9hcmRzIHRvIGdldCB0aGVtIHdvcmtpbmcuCj4gPj4+Cj4gPj4+IFNpZ25l ZC1vZmYtYnk6IERhdmlkIExlY2huZXIgPGRhdmlkQGxlY2hub2xvZ3kuY29tPgo+ID4+PiBTaWdu ZWQtb2ZmLWJ5OiBCYXJ0b3N6IEdvbGFzemV3c2tpIDxiZ29sYXN6ZXdza2lAYmF5bGlicmUuY29t Pgo+ID4+Cj4gPj4gSSByZW1lbWJlciB5b3UgbWVudGlvbmluZyBhYm91dCBzb21lIHByb2JsZW1z IHVzaW5nIE9DSEkgYW5kIGNwdWZyZXEKPiA+PiB0b2dldGhlci4gQXJlIHRob3NlIHJlc29sdmVk IG5vdz8gQ1BVIFBMTCBvbiBEQTg1MCBjYW4gYWZmZWN0IG90aGVyCj4gPj4gcGVyaXBoZXJhbCBj bG9jayBmcmVxdWVuY2llcyB0b28uIFNvIGVuYWJsaW5nIGl0IHNob3VsZCByZWFsbHkgYmUgYQo+ ID4+IHBlci1ib2FyZCBkZWNpc2lvbi4KPiA+Pgo+ID4KPiA+IFRoZSBwcm9ibGVtcyBhcmUgc3Rp bGwgdGhlcmUuIEkndmUgbmV2ZXIgYmVlbiBhYmxlIHRvIGZpbmQgdGhlCj4gPiBjdWxwcml0LCBi dXQgaXQgYWxzbyBvY2N1cnMgb24gVEkgQlNQIGluIHRoZSBzYW1lIHdheSAoYSBjb3VwbGUKPiA+ IGNwdWZyZXEgdHJhbnNpdGlvbnMgd2lsbCBtYWtlIHRoZSBjb250cm9sbGVyIHVucmVzcG9uc2l2 ZSkuCj4KPiBJcyB0aGF0IG9uIExDREsgYXMgd2VsbD8gQXMgSSByZWNhbGwgY3B1ZnJlcSB3YXMg bmV2ZXIgZW5hYmxlZCBvbiBMQ0RLCj4gaW4gVEkgQlNQLgo+CgpZZXMsIEkganVzdCB2ZXJpZmll ZCB0aGF0IHRoZSBidWcgb2NjdXJzIG9uIExDREsgd2l0aCBwYXRjaGVzIGZyb20gdGhpcyBzZXJp ZXMuCgo+IElmIHRoZSBPSENJIHByb2JsZW0gaXMgcHJlc2VudCBvbiBMQ0RLLCB0aGVuIHRoZXJl IGlzIGEgdXNlciB2aXNpYmxlCj4gcmVncmVzc2lvbiBvbiBtYWlubGluZSBhZnRlciB0aGlzIHBh dGNoLiBMZXRzIGVuYWJsZSBjcHVmcmVxIGluIExDREsKPiBvbmx5IGlmIGFsbCB3b3JraW5nIHBl cmlwaGVyYWxzIGtlZXAgd29ya2luZyBhZnRlcndhcmRzLgo+CgpUaGUgT0hDSSBkcml2ZXIgZG9l c24ndCByZWdpc3RlciBhbnkgY3B1ZnJlcSB0cmFuc2l0aW9uIG5vdGlmaWVyCmNhbGxiYWNrcy4g SSBjYW4ndCByZWFsbHkgZmluZCBhbnl0aGluZyBpbiB0aGUgZGF0YXNoZWV0LCBidXQgSSdtCndv bmRlcmluZyBpZiB3ZSBzaG91bGRuJ3QgZG8gc29tZXRoaW5nIHNpbWlsYXIgdG8gd2hhdCB0aGUg ZHJpdmVyIGZvcgpkYXZpbmNpIGkyYyBjb250cm9sbGVyIGRvZXMuIEknbGwgdHJ5IGEgY291cGxl IHRoaW5ncyB0b21vcnJvdy4KCkJhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK