All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Cixi Geng <cixi.geng@linux.dev>
Cc: linus.walleij@linaro.org, orsonzhai@gmail.com,
	baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	cixi.geng1@unisoc.com
Subject: Re: [PATCH V4 0/3] Make the irqchip immutable
Date: Fri, 30 Dec 2022 16:59:40 +0100	[thread overview]
Message-ID: <CAMRc=MeCCT09umHQ+T6Z6OXMedBh3UXzmQ=1PCyo1zEMr34TCw@mail.gmail.com> (raw)
In-Reply-To: <20221229145545.14055-1-cixi.geng@linux.dev>

On Thu, Dec 29, 2022 at 3:56 PM Cixi Geng <cixi.geng@linux.dev> wrote:
>
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Kernel warns about mutable irq_chips:
>     "not an immutable chip, please consider fixing!"
>
> Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the
> new helper functions, and call the appropriate gpiolib functions.
>
> v2 changes:
> Split the patch by each driver. and other comment by baolin in[1]
>
> v3 changes:
> Fix cocci warnings test by lkp[2].
>
> v4 changes:
> Change the irq name.
> Keep the same coding style by using offset for irqd_to_hwirq(data)
> Add Reviewed-by tag.
>
> [1]:https://lore.kernel.org/all/97e244d4-6b5c-31c9-7329-b8deef615645@linux.alibaba.com/
> [2]:https://lore.kernel.org/all/202212240406.9Nm190P8-lkp@intel.com/
>
> Cixi Geng (3):
>   gpio: eic-sprd: Make the irqchip immutable
>   gpio: gpio-pmic-eic-sprd: Make the irqchip immutable
>   gpio: gpio-sprd: Make the irqchip immutable
>
>  drivers/gpio/gpio-eic-sprd.c      | 23 ++++++++++++++---------
>  drivers/gpio/gpio-pmic-eic-sprd.c | 29 ++++++++++++++++++-----------
>  drivers/gpio/gpio-sprd.c          |  9 ++++++---
>  3 files changed, 38 insertions(+), 23 deletions(-)
>
>
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> --
> 2.34.1
>

Series queued for fixes, thanks!

Bart

      parent reply	other threads:[~2022-12-30 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 14:55 [PATCH V4 0/3] Make the irqchip immutable Cixi Geng
2022-12-29 14:55 ` [PATCH V4 1/3] gpio: eic-sprd: " Cixi Geng
2022-12-29 14:55 ` [PATCH V4 2/3] gpio: gpio-pmic-eic-sprd: " Cixi Geng
2022-12-29 14:55 ` [PATCH V4 3/3] gpio: gpio-sprd: " Cixi Geng
2022-12-30 15:59 ` Bartosz Golaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=MeCCT09umHQ+T6Z6OXMedBh3UXzmQ=1PCyo1zEMr34TCw@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=cixi.geng1@unisoc.com \
    --cc=cixi.geng@linux.dev \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.