From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CD77C433E2 for ; Mon, 7 Sep 2020 17:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15B4E2080A for ; Mon, 7 Sep 2020 17:53:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="W4qYrlMq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729562AbgIGRxG (ORCPT ); Mon, 7 Sep 2020 13:53:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728916AbgIGLW4 (ORCPT ); Mon, 7 Sep 2020 07:22:56 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4216CC06179F for ; Mon, 7 Sep 2020 04:04:40 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id u20so3308080ilk.6 for ; Mon, 07 Sep 2020 04:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1B/HAY7CQ2kgdOMuMSUPk6pREpiLHnIcgbAxblH2K1Y=; b=W4qYrlMqsiKUO1IXIqKFB92tdgLj8OvcoC6QiZjOrJumIILg6kwYVZQVhMcjZZme8+ uTxaZ4A44RW2FvoscbbPCukSKqOxq4PhOFmeSKlRJA51HjdobE7qutUP6wAhawWJEOaY NPRFM8tEqU1F7a1gwDoCcd+HxlFuRvxhsguq2aBVeoSm8Cz62KuDe09VU44giiaq+mQz 217j2HZ87eJjd2a5Cjyq6IOjXBJjAfmfyIao982fWhcLfXj4u7ouDub5WWTQrUPkNmZQ sMkVEIqJp66qcey3Uy6vD5BmwWa2mQpn6BpQaryGEIBdxF2680B8qvfL8SPXXQfj9Ka3 r/Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1B/HAY7CQ2kgdOMuMSUPk6pREpiLHnIcgbAxblH2K1Y=; b=eJvcgFdn6ErCebMfYARp7mgie4gdYFlsOHSy1nDz0JjjJZBoCj9/zoZM6bQTGBA4xW HmeEn7lBCI3r1SnLz63DrS8iw4cp/vSEISWzaa+AXcjyX5sFziiTMdedSs+eAXjDugGr w4LwVPkgMWfB2T0H3IkMKSvNtdO1gZ9iCzkuCk1osxyvOv4B0AVv4KfciClqPwPARcsM ic10qvjviEkykwbVDJ2EXcpDiwMhXFl/6Nvg96Pw0fCjHDFcwyz8bJPhejF6uN+5REZF XB7E/5jNoi49cu7qEHux1XY0b68IIpLrp+GiUMs/J3n/tHJGN8PsZua46IeM2BoJLQlX mOMQ== X-Gm-Message-State: AOAM533Nytr9W6sfHJMcerOP7+nlY+baQUWcGW/htxa2dhbuSH73tjk5 LySVxhgMNbqa6PSvYK7Bn6iaRUXB/imrM/MDAQMhhw== X-Google-Smtp-Source: ABdhPJxCu1C6pdXbMZCPQ4I9idYD52QAe4Fl37C5i5Jt6npBXcV7EAl+4xXCL5VdCSbk4I7Fs4CQRXJ907+af8oRRr4= X-Received: by 2002:a92:cb4d:: with SMTP id f13mr15703244ilq.189.1599476679896; Mon, 07 Sep 2020 04:04:39 -0700 (PDT) MIME-Version: 1.0 References: <20200904154547.3836-1-brgl@bgdev.pl> <20200904154547.3836-16-brgl@bgdev.pl> <20200904164917.GC1891694@smile.fi.intel.com> In-Reply-To: <20200904164917.GC1891694@smile.fi.intel.com> From: Bartosz Golaszewski Date: Mon, 7 Sep 2020 13:04:29 +0200 Message-ID: Subject: Re: [PATCH 15/23] gpio: mockup: use dynamic device IDs To: Andy Shevchenko Cc: Linus Walleij , Jonathan Corbet , Mika Westerberg , Kent Gibson , "open list:GPIO SUBSYSTEM" , linux-doc , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Sep 4, 2020 at 6:49 PM Andy Shevchenko wrote: > > On Fri, Sep 04, 2020 at 05:45:39PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > We're currently creating chips at module init time only so using a > > static index for dummy devices is fine. We want to support dynamically > > created chips however so we need to switch to dynamic device IDs. > > It misses ida_destroy(). > No, we always call ida_free() for separate IDs when removing devices and we remove all devices at module exit so no need to call ida_destroy(). > What about XArray API? > Answered that somewhere - xarray is already used internally by IDA. Bart