All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 1/2] gpiolib: Provide to_gpio_device() helper
Date: Tue, 29 Nov 2022 14:52:03 +0100	[thread overview]
Message-ID: <CAMRc=MeLnuxoiUrKqRvUkcL0trsvauLwDEXva3pJuqcRN2Qa=g@mail.gmail.com> (raw)
In-Reply-To: <Y4YNOd0pBUfqxvmC@smile.fi.intel.com>

On Tue, Nov 29, 2022 at 2:46 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Nov 29, 2022 at 01:50:51PM +0100, Bartosz Golaszewski wrote:
> > On Mon, Nov 28, 2022 at 8:00 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
>
> ...
>
> > > While at it, make sure it becomes no-op at compilation time.
>
> ^^^
>
> > > -       int                     id;
> >
> > Sorry I didn't notice it before but why the churn? This is not needed
> > for container_of to work.
>
> > > +       int                     id;
>
> I hope this explains and can be accepted.
>

Ah, alright makes sense. Applying.

Bart

      reply	other threads:[~2022-11-29 13:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 19:00 [PATCH v2 1/2] gpiolib: Provide to_gpio_device() helper Andy Shevchenko
2022-11-28 19:00 ` [PATCH v2 2/2] gpiolib: Introduce gpio_device_get() and gpio_device_put() Andy Shevchenko
2022-11-28 20:40 ` [PATCH v2 1/2] gpiolib: Provide to_gpio_device() helper Linus Walleij
2022-11-29 12:50 ` Bartosz Golaszewski
2022-11-29 13:46   ` Andy Shevchenko
2022-11-29 13:52     ` Bartosz Golaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=MeLnuxoiUrKqRvUkcL0trsvauLwDEXva3pJuqcRN2Qa=g@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.