From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1923C433E2 for ; Mon, 7 Sep 2020 10:50:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B419A21473 for ; Mon, 7 Sep 2020 10:50:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="DXXW4y3J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728870AbgIGKuS (ORCPT ); Mon, 7 Sep 2020 06:50:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728786AbgIGKuO (ORCPT ); Mon, 7 Sep 2020 06:50:14 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A80C061755 for ; Mon, 7 Sep 2020 03:50:13 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id w5so4194251ilo.5 for ; Mon, 07 Sep 2020 03:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y2WbMMlWb+6LVnmTJRKV9M4FUT+m4Yhxko6TEmzZawo=; b=DXXW4y3JIc13ePP4dZs0HPbsWLHy9Mn1p6wfUdlMGf8aqElDxpEmWg3aw+DqpO5ss5 foGGRIcNDCa/FPVCbUcEvaCUzHTCxoAMw2WYzPuFIY2s9jAQPmONVbR3BKFfH8sYdnsC dHQf8ZVmgZZ09vKY3G2gGhvUFZaA4X2zKkdKWKuGjV37gNKiWVSYvcoCZ2xcdpqymaI2 Ki/4qC6smG9C5a2s0+BXm2TuolTZRs+pubuGVOK46JNqbGNqgWBJVxjQBZuuL0Z2NlQq nl1YC4vskdLtvxYJFDRk+G0y4qVL0DYvBbgeYpKCAWy2NhWNlpqcEhF3cdA1L7D1mzrB Rgqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y2WbMMlWb+6LVnmTJRKV9M4FUT+m4Yhxko6TEmzZawo=; b=KJU9RDXO3qd8FVfi2IvFLqaiPGvC4nlhLMIhFvWxScGvjS8R0nUMLr5a/CGrda8uNw /HjirKayTnPir1IDgCqJNMztovW5OZCb3bqUOWw4LUx4d/w6A1blkB4w5EqGxx8HdQ5T pwU9bWd7Uj4EW6eXH0XwX8NIBDP6+DRPrkMrEteFQuU7qybGUoKT5Gnv4JhPRGf7SdQu 3IgICjtW8pBHGCSZruBUjiQvBrq8r0iHFNbff5tM4n/vota5R8B4Q4vcuGjRoYjSdcG9 jla8nHzMy6iaf2G9Lo2REg94S9bCt3mDUf111SkFDehI1QDH6qYIg+03iJIkCho266lz t3UA== X-Gm-Message-State: AOAM532EDFgWAQo6Jd44+crYP12MXScKdTwvpyavQWYY42FE+qDc5txD h35ffstRJyvrBsqq57jGyxXDu0ESj0GaUjkxaGZQUA== X-Google-Smtp-Source: ABdhPJynrTfkvCINR4dH6XcXpfLrT9viB5CqRNVONJhEUV5jYmiptH6QUEy6gzaqRlgTPWh+SDbiNtD7xbF8ZAG72hU= X-Received: by 2002:a92:189:: with SMTP id 131mr19144027ilb.40.1599475813063; Mon, 07 Sep 2020 03:50:13 -0700 (PDT) MIME-Version: 1.0 References: <20200904154547.3836-1-brgl@bgdev.pl> <20200904154547.3836-7-brgl@bgdev.pl> <20200904164128.GZ1891694@smile.fi.intel.com> In-Reply-To: <20200904164128.GZ1891694@smile.fi.intel.com> From: Bartosz Golaszewski Date: Mon, 7 Sep 2020 12:50:01 +0200 Message-ID: Subject: Re: [PATCH 06/23] gpiolib: switch to simpler IDA interface To: Andy Shevchenko Cc: Linus Walleij , Jonathan Corbet , Mika Westerberg , Kent Gibson , "open list:GPIO SUBSYSTEM" , linux-doc , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Sep 4, 2020 at 6:41 PM Andy Shevchenko wrote: > > On Fri, Sep 04, 2020 at 05:45:30PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > We don't need to specify any ranges when allocating IDs so we can switch > > to ida_alloc() and ida_free() instead of the ida_simple_ counterparts. > > > > ida_simple_get(ida, 0, 0, gfp) is equivalent to > > ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to > > ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID > > larger than INT_MAX. > > Have you considered switching to XArray API? > IDA uses an xarray internally but wraps it in a more straightforward API. No need to use the low-level API IMO. Bart