From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755002AbdLTMl4 (ORCPT ); Wed, 20 Dec 2017 07:41:56 -0500 Received: from mail-ot0-f179.google.com ([74.125.82.179]:42199 "EHLO mail-ot0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754649AbdLTMlx (ORCPT ); Wed, 20 Dec 2017 07:41:53 -0500 X-Google-Smtp-Source: ACJfBosB5w+wXDIlUALKAEeBd1yIy1JtYx5+Xc/0BZt9gRSw4uv+ryfGE7wRCmziwJgL7SI513VOlY9EaTg5m7Icvz0= MIME-Version: 1.0 In-Reply-To: References: <20171220082633.32237-1-brgl@bgdev.pl> From: Bartosz Golaszewski Date: Wed, 20 Dec 2017 13:41:51 +0100 Message-ID: Subject: Re: [PATCH v2 0/2] eeprom: at24: write-protect pin support To: Andy Shevchenko Cc: Rob Herring , Mark Rutland , Linus Walleij , Peter Rosin , linux-i2c , devicetree , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-12-20 11:21 GMT+01:00 Andy Shevchenko : > On Wed, Dec 20, 2017 at 10:26 AM, Bartosz Golaszewski wrote: >> AT24 EEPROMs have a write-protect pin, which - when pulled high - >> inhibits writes to the upper quadrant of memory (although it has been >> observed that on some chips it disables writing to the entire memory >> range). >> >> On some boards, this pin is connected to a GPIO and pulled high by >> default, which forces the user to manually change its state before >> writing. On linux this means that we either need to hog the line all >> the time, or set the GPIO value before writing from outside of the >> at24 driver. >> >> This series adds support for the write-protect pin split into two >> parts. The first patch extends the relevant binding document, while >> the second modifies the at24 code to pull the write-protect GPIO >> low (if present) during write operations. >> > > Reviewed-by: Andy Shevchenko > > A one totally minor nit: if it possible now to have one line where > devm_gpiod_get_optional() is called? > You may ignore this nit anyway. > Hi Andy, I'm afraid I don't understand what you mean here. I do use devm_gpiod_get_optional() in patch 2/2. Thanks, Bartosz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartosz Golaszewski Subject: Re: [PATCH v2 0/2] eeprom: at24: write-protect pin support Date: Wed, 20 Dec 2017 13:41:51 +0100 Message-ID: References: <20171220082633.32237-1-brgl@bgdev.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Shevchenko Cc: Rob Herring , Mark Rutland , Linus Walleij , Peter Rosin , linux-i2c , devicetree , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org 2017-12-20 11:21 GMT+01:00 Andy Shevchenko : > On Wed, Dec 20, 2017 at 10:26 AM, Bartosz Golaszewski wrote: >> AT24 EEPROMs have a write-protect pin, which - when pulled high - >> inhibits writes to the upper quadrant of memory (although it has been >> observed that on some chips it disables writing to the entire memory >> range). >> >> On some boards, this pin is connected to a GPIO and pulled high by >> default, which forces the user to manually change its state before >> writing. On linux this means that we either need to hog the line all >> the time, or set the GPIO value before writing from outside of the >> at24 driver. >> >> This series adds support for the write-protect pin split into two >> parts. The first patch extends the relevant binding document, while >> the second modifies the at24 code to pull the write-protect GPIO >> low (if present) during write operations. >> > > Reviewed-by: Andy Shevchenko > > A one totally minor nit: if it possible now to have one line where > devm_gpiod_get_optional() is called? > You may ignore this nit anyway. > Hi Andy, I'm afraid I don't understand what you mean here. I do use devm_gpiod_get_optional() in patch 2/2. Thanks, Bartosz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html