From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] regulator: max77650: add of_match table
Date: Tue, 10 Dec 2019 14:10:15 +0100 [thread overview]
Message-ID: <CAMRc=MenTgffszv4NsbCKRhH0TcRPSTLbeP3BttW9fmFBjLdCA@mail.gmail.com> (raw)
In-Reply-To: <20191210130244.GE6110@sirena.org.uk>
wt., 10 gru 2019 o 14:02 Mark Brown <broonie@kernel.org> napisał(a):
>
> On Tue, Dec 10, 2019 at 01:51:38PM +0100, Bartosz Golaszewski wrote:
> > wt., 10 gru 2019 o 13:12 Mark Brown <broonie@kernel.org> napisał(a):
>
> > > Why would we need to use a compatible string in a child node to load the
> > > regulator driver, surely we can just register a platform device in the
> > > MFD?
>
> > The device is registered all right from MFD code, but the module won't
> > be loaded automatically from user-space even with the right
> > MODULE_ALIAS() for sub-nodes unless we define the
> > MODULE_DEVICE_TABLE().
>
> This seems to work fine for other drivers and the platform bus has to be
> usable on systems that don't use DT so that doesn't sound right. Which
> MODULE_ALIAS() are you using exactly?
>
MODULE_ALIAS("platform:max77650-regulator");
> > Besides: the DT bindings define the compatible for sub-nodes already.
> > We should probably conform to that.
>
> I would say that's a mistake and should be fixed, this particular way of
> loading the regulators is a Linux implementation detail.
Fixed by removing this from the bindings?
Bartosz
next prev parent reply other threads:[~2019-12-10 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 10:07 [PATCH] regulator: max77650: add of_match table Bartosz Golaszewski
2019-12-10 12:12 ` Mark Brown
2019-12-10 12:51 ` Bartosz Golaszewski
2019-12-10 13:02 ` Mark Brown
2019-12-10 13:10 ` Bartosz Golaszewski [this message]
2019-12-10 13:21 ` Mark Brown
2019-12-10 16:53 ` Bartosz Golaszewski
2019-12-10 17:37 ` Mark Brown
2019-12-11 16:55 ` Applied "regulator: max77650: add of_match table" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MenTgffszv4NsbCKRhH0TcRPSTLbeP3BttW9fmFBjLdCA@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.