From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E931CC43381 for ; Mon, 8 Mar 2021 15:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B88026522C for ; Mon, 8 Mar 2021 15:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229459AbhCHPhs (ORCPT ); Mon, 8 Mar 2021 10:37:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbhCHPhX (ORCPT ); Mon, 8 Mar 2021 10:37:23 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1DA0C06174A for ; Mon, 8 Mar 2021 07:37:22 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id jt13so21293442ejb.0 for ; Mon, 08 Mar 2021 07:37:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gjHfcAXY88yF8tNbjJtkmDUGnU+swDxc27GpD7p9UQA=; b=Iub5yJdpOGm9mEiEIh1q9/Q+9Bs8dvvUxWsQHTo29W+sAERu2/clpPH5quQvPUcJQ9 ha7uoMf4Ehox4DQgT2c4M1GtX2bHxm8RfUQcas4mFrbs8Ungu3/4Hc/r1ANJ/P8vD1VJ ySwh0SiPaFSfYmAITK8jfrP7rYjhvndQa8Kq/sJOJ6td69GgFhRwZ7JcVYaN2niDcGf+ P3JJft2jubop/zBjHLb0uL0A3jG9JYCJXIrBjMOF/hoxcjgchCH5PjrIqLfpbmTeHV1k EtsuqFLy5awWOxakAjXyTZ9MqPuUo2OI9pvrSTtKlqMMewnrze9GXSKTWqQ6KawaBJy2 SC2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gjHfcAXY88yF8tNbjJtkmDUGnU+swDxc27GpD7p9UQA=; b=lbRiCipiO0Uy8wBaCB/UfgwTx2fHcYa2/VyYnou7xiVG7zrTzNAQIB4Z3rrT0DqmyA NMir/6I70qZVqAD5DB4EikhsxpbFibyq19de1uvkGgCN4MFix2k4n/sQS4NQlpmHlogM MMBvUsYQnniSOIH3faQiXdIImGujJfhNuwtPQVw/M16sHNuI17+IMEjaVY8M0Uc2GZ4L L3XS/ROXCxE87kz5YurhvzFtygGxn1Z+eSHoTNFL3e31wTW2W4iURtrj4QMEX4Ir6r9U TxNFvV385knF8pwygRXM7c50/IqGONCO1Y2Xwj+VpfmO0V5npZ/vIVMg0OFqH3lMdtP3 OFMA== X-Gm-Message-State: AOAM533XEIAme/FRVesA5Ysr+z1MsB/9nUKTplhVv9CJWoCvjOI9EMAl tqPba3TFbUPSw9OaTmSsCXP22++gHy08ENgJrSo2dg== X-Google-Smtp-Source: ABdhPJxkgaHYtZwgo6uZK1AWumBj4Oo/xv5tOsU4La0Q6aOKgoDqhl6nK8SA2fSAJNoy/gDoIQRjsb49U0G9eESJcio= X-Received: by 2002:a17:906:d938:: with SMTP id rn24mr16289501ejb.87.1615217841387; Mon, 08 Mar 2021 07:37:21 -0800 (PST) MIME-Version: 1.0 References: <20210304102452.21726-1-brgl@bgdev.pl> <20210304102452.21726-10-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Mon, 8 Mar 2021 16:37:10 +0100 Message-ID: Subject: Re: [PATCH v2 09/12] gpio: sim: new testing module To: Andy Shevchenko Cc: Bartosz Golaszewski , Joel Becker , Christoph Hellwig , Shuah Khan , Linus Walleij , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-doc Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote: > > On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko > > wrote: > > > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote: > > ... > > > > I have strong opinion not to open code "yet another parser". > > > > > > So, grepping on 'strsep(.*, ",")' shows a lot of code that wants something like > > > this. Interesting are the net/9p cases. This in particular pointed out to > > > lib/parser.c which in turn shows promising match_strlcpy() / match_strdup(). I > > > haven't looked deeply though. > > > > > > That said, I agree that next_arg() is not the best here. > > > > Shall we revisit this once it's upstream with a generalization for > > separating comma separated strings? > > How can we guarantee it won't be forgotten? > I will add a REVISIT comment, so *obviously* it ***will*** be revisited. :) Bartosz