From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Pierluigi Passaro <pierluigi.p@variscite.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eran Matityahu <eran.m@variscite.com>,
Nate Drude <Nate.D@variscite.com>,
Francesco Ferraro <francesco.f@variscite.com>,
"pierluigi.passaro@gmail.com" <pierluigi.passaro@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] gpiolib: fix linker errors when GPIOLIB is disabled
Date: Wed, 18 Jan 2023 15:21:51 +0100 [thread overview]
Message-ID: <CAMRc=MfN5o32AminWbjHVh_OBy-uAOJZyvb-1zhn7zs6EVyhMw@mail.gmail.com> (raw)
In-Reply-To: <AM6PR08MB437640AB4B959DD356162F2BFFC69@AM6PR08MB4376.eurprd08.prod.outlook.com>
On Tue, Jan 17, 2023 at 11:17 AM Pierluigi Passaro
<pierluigi.p@variscite.com> wrote:
>
> On Tue, Jan 17, 2023 at 10:36 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > On Mon, Jan 16, 2023 at 3:08 PM Pierluigi Passaro
> > <pierluigi.p@variscite.com> wrote:
> > >
> > > Both the functions gpiochip_request_own_desc and
> > > gpiochip_free_own_desc are exported from
> > > drivers/gpio/gpiolib.c
> > > but this file is compiled only when CONFIG_GPIOLIB is enabled.
> > > Move the protototypes under "#ifdef CONFIG_GPIOLIB" and provide
> > > reasonable definitions in the "#else" branch.
> > >
> > > Signed-off-by: Pierluigi Passaro <pierluigi.p@variscite.com>
> > > Reported-by: kernel test robot <lkp@intel.com>
> >
> > Please add a Fixes tag.
> >
> I beg your pardon for the question: how can I "add a Fixes tag" ?
> Can you point me to any reference documentation / instructions ?
> Thanks
> >
Look at the output of `git blame` on the file in question and see who
added the changes that introduced the problem. Then, before your
Sign-off in the git message add: Fixes: <12 chars of the commit hash>
("<commit subject>"). See Existing commits with fixes for reference.
Bart
next prev parent reply other threads:[~2023-01-18 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 14:08 [PATCH] gpiolib: fix linker errors when GPIOLIB is disabled Pierluigi Passaro
2023-01-17 6:23 ` Alexander Stein
2023-01-17 7:44 ` Pierluigi Passaro
2023-01-17 9:34 ` Bartosz Golaszewski
2023-01-17 9:36 ` Bartosz Golaszewski
2023-01-17 10:17 ` Pierluigi Passaro
2023-01-18 14:21 ` Bartosz Golaszewski [this message]
2023-01-21 0:29 ` Pierluigi Passaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MfN5o32AminWbjHVh_OBy-uAOJZyvb-1zhn7zs6EVyhMw@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=Nate.D@variscite.com \
--cc=eran.m@variscite.com \
--cc=francesco.f@variscite.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pierluigi.p@variscite.com \
--cc=pierluigi.passaro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.