From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2119C433EF for ; Mon, 18 Apr 2022 19:47:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235584AbiDRTug (ORCPT ); Mon, 18 Apr 2022 15:50:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231756AbiDRTuf (ORCPT ); Mon, 18 Apr 2022 15:50:35 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CED526549 for ; Mon, 18 Apr 2022 12:47:55 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id s25so18146664edi.13 for ; Mon, 18 Apr 2022 12:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NXg16T5RHzmRSU7fzbqLl5dRDSsIh5leaaKIVXJix2Y=; b=n6TH58tO6Jf+8u5wbFfxZZ1rGSt9UpKEMo4zwn5SrzJg5kBLgAnwKPjEFKGOn1AsVS BlTUiehQ1Zjs+vmeVNX+gknbYOIT7noOyWXV3+LClR4fl7XiIIaS/9Cc1rxU22dCtuaK pQ/b93oy/yreNJvMQcrLjfcxDGUaFW/7+1GLVBne6lfgv+anTs0MIp60sRbuPxKfMUTS mAdwxkPpboKUwwoyDwxwYgC5LimvdLfbqffeEt/evWZRKSDezMKAsw3qP4hQgLnBorKX ND5e4C+abAw+VaSHw4ACJGqoi5sIyB7YGM8tQwYQ2tdzkxbJwnwNtfd2/1CkMBa6U87y 8F9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXg16T5RHzmRSU7fzbqLl5dRDSsIh5leaaKIVXJix2Y=; b=me1oqCc2LpHw8rj7Uxq+12rdIUUFp9d0GTCmo++ze9/9ySR7FOUrcCKvLBIbkuv9bi w/sqAotA55cJZucuojraaaAWo/v5bTD0MoLSmkxF8NXV6pblNJuoF2vHUBEEuPS2L8ud X/mlwIYzmYn9Yi72c8aDun3sM64eDd6OZZhRZBsTzoI8YR6ghP38lYXUQtZa/diJFGP9 7by/lXfgDUZvwySu4IY5PkYsRtoWoAKi+BmCtdaaX9NVHrf8VfQZdqYS8XIFQjmcvHNA o8tc89QsrClqqi8D/xjuNy6ocKfLPYiIp/reNcQCZN5FMiKkedl+UQHfkejSrefq/JJM txXg== X-Gm-Message-State: AOAM530QLFks4uKGOCBvKGo637TNgjvgFg8QU2+WaqJZhd8KhVRmUXuB Naj8nHvbIhFcB6sySuMJ9mVxQ8vVUo9heTEZf6/blA== X-Google-Smtp-Source: ABdhPJwvoJ8S2SQnY/koE4FsNKMAxVbvlxW9QX5pT4ZaYsnS74IHedJObRxq4/ya8URo4hGKRxRf5E8Bb0WAjXdhtak= X-Received: by 2002:a05:6402:128f:b0:41d:7e85:8421 with SMTP id w15-20020a056402128f00b0041d7e858421mr13502922edv.352.1650311273941; Mon, 18 Apr 2022 12:47:53 -0700 (PDT) MIME-Version: 1.0 References: <20220328005005.72492-1-kc@postmarketos.org> <20220328005005.72492-4-kc@postmarketos.org> In-Reply-To: <20220328005005.72492-4-kc@postmarketos.org> From: Bartosz Golaszewski Date: Mon, 18 Apr 2022 21:47:43 +0200 Message-ID: Subject: Re: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs To: Caleb Connolly Cc: Rob Herring , Heiko Stuebner , Linus Walleij , devicetree , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , ~postmarketos/upstreaming@lists.sr.ht, martijn@brixit.nl, Arnaud Ferraris Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly wrote: > > Add support for deferred PIN_CONFIG_INPUT_ENABLE handling. > > Signed-off-by: Caleb Connolly > --- > drivers/gpio/gpio-rockchip.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c > index bcf5214e3586..e342a6dc4c6c 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev) > dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin, > cfg->arg); > break; > + case PIN_CONFIG_INPUT_ENABLE: > + ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin); > + if (ret) > + dev_warn(dev, "setting input pin %u failed\n", cfg->pin); > + break; > default: > dev_warn(dev, "unknown deferred config param %d\n", cfg->param); > break; > -- > 2.35.1 > Does this depend on patches 1 & 2 or does patch 4 depend on this one? If so: Acked-by: Bartosz Golaszewski Otherwise I can take it through the GPIO tree. Bart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21CCBC433EF for ; Mon, 18 Apr 2022 19:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X8TK522vUTjJozRuqr5XVk+F8f1ofHDf+6vJofQp9YU=; b=Q5PPwkMvky1krI iXSJlqoX8AnOKTYgUbNbrSDhGyiJemKtF5FY+GUyQKGa2I2a059a0nRVVk+mDvMmHGdxLglge5Hkk 3HVVm0/MLqtGFmWV3Av326ClmfoCwqbDV3Gm/frFEBV5cRV0+qAiXmNSojlzeKD1+vec4ou1xNuoq IMkGEsz17ChXpdFPm4X90pJhKyILPLDZ8WBUIS+XfNz8tByOJGBQQGesad+u4Y/lAHhOGhkZt8n57 OYLbz+u1mLwwFxeZPYT039RxAUdAusUEgg7edgy4yksLtrqc9Dc05+0kWOCCuHb9GGgDNI74jrr98 ibLMjSZSPLzZlMEdME8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngXM1-000Uu8-QC; Mon, 18 Apr 2022 19:48:09 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngXLq-000UqX-9l for linux-rockchip@lists.infradead.org; Mon, 18 Apr 2022 19:48:00 +0000 Received: by mail-ed1-x532.google.com with SMTP id b24so18588462edu.10 for ; Mon, 18 Apr 2022 12:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NXg16T5RHzmRSU7fzbqLl5dRDSsIh5leaaKIVXJix2Y=; b=n6TH58tO6Jf+8u5wbFfxZZ1rGSt9UpKEMo4zwn5SrzJg5kBLgAnwKPjEFKGOn1AsVS BlTUiehQ1Zjs+vmeVNX+gknbYOIT7noOyWXV3+LClR4fl7XiIIaS/9Cc1rxU22dCtuaK pQ/b93oy/yreNJvMQcrLjfcxDGUaFW/7+1GLVBne6lfgv+anTs0MIp60sRbuPxKfMUTS mAdwxkPpboKUwwoyDwxwYgC5LimvdLfbqffeEt/evWZRKSDezMKAsw3qP4hQgLnBorKX ND5e4C+abAw+VaSHw4ACJGqoi5sIyB7YGM8tQwYQ2tdzkxbJwnwNtfd2/1CkMBa6U87y 8F9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXg16T5RHzmRSU7fzbqLl5dRDSsIh5leaaKIVXJix2Y=; b=1aXUpBUoTUwL+eAOa1nDutHXx3PmNHf2xyPipgx1zmpTC22azi52fV/7Kiolh8xuV7 xEBHHj6MJQgqiVcJzuh4iQudocPBAaC2Ka6aZdz9ho/H3hpFde3Z+RbAkdAoDRmGPwKe lZelmwZGsILTSmyTMo6Qh0tehgRH2BBxCRIgNVgoP0+xWH9ayp1V+kFasHRh6z4XMn68 8IeOg8XlDRGMTaKjUFJgBUzhKujXQu5VZkaPaXSBmb7NRLg4ummwd76OG007zMjzUGDd x81LKN8dD/v8jqJesI9MlA9T1Wsa61wBYz5rCMzQROceWLN5eTkq2Tmv0JcZ71Pzui+X 3L6w== X-Gm-Message-State: AOAM532p9oQyBTVca0XXowxPW3lUs8gf9ytm9v5gKWrl9BJtyrQiweqy EHHAvpKX7aCAJsIfvUR8MCp5Ty9jG74HV3u2B1socg== X-Google-Smtp-Source: ABdhPJwvoJ8S2SQnY/koE4FsNKMAxVbvlxW9QX5pT4ZaYsnS74IHedJObRxq4/ya8URo4hGKRxRf5E8Bb0WAjXdhtak= X-Received: by 2002:a05:6402:128f:b0:41d:7e85:8421 with SMTP id w15-20020a056402128f00b0041d7e858421mr13502922edv.352.1650311273941; Mon, 18 Apr 2022 12:47:53 -0700 (PDT) MIME-Version: 1.0 References: <20220328005005.72492-1-kc@postmarketos.org> <20220328005005.72492-4-kc@postmarketos.org> In-Reply-To: <20220328005005.72492-4-kc@postmarketos.org> From: Bartosz Golaszewski Date: Mon, 18 Apr 2022 21:47:43 +0200 Message-ID: Subject: Re: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs To: Caleb Connolly Cc: Rob Herring , Heiko Stuebner , Linus Walleij , devicetree , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , ~postmarketos/upstreaming@lists.sr.ht, martijn@brixit.nl, Arnaud Ferraris X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_124758_362776_FDB238E3 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly wrote: > > Add support for deferred PIN_CONFIG_INPUT_ENABLE handling. > > Signed-off-by: Caleb Connolly > --- > drivers/gpio/gpio-rockchip.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c > index bcf5214e3586..e342a6dc4c6c 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev) > dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin, > cfg->arg); > break; > + case PIN_CONFIG_INPUT_ENABLE: > + ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin); > + if (ret) > + dev_warn(dev, "setting input pin %u failed\n", cfg->pin); > + break; > default: > dev_warn(dev, "unknown deferred config param %d\n", cfg->param); > break; > -- > 2.35.1 > Does this depend on patches 1 & 2 or does patch 4 depend on this one? If so: Acked-by: Bartosz Golaszewski Otherwise I can take it through the GPIO tree. Bart _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05D07C433EF for ; Mon, 18 Apr 2022 19:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a5xEmcmrAL+fTzdD1A0r27GmJDArEnxbFJVgoucydqQ=; b=T6tcxSPseb+r9S NVy309ZCXHnIvRAwE3/DgIRg674e6BNQMlDy7T9vuYGtKx3rmI18PBuDojZZ/e6U82iWnkuc+KYWR u7V4m2bv7+7lY7iPec5krUIdCPbKKthszF9pLlSfVR+3fGyxXHIptYPq55MwXkDvryyQUllkqgTYr aGEKTSsgMp7IeRSIabAXrEh/qC8EZ8Wf/Dj0NdylDqMlyzD50llGtTIJK0yje0pNTKV1hzV54hOlj xCOCRiN/b1tiOLYpeQhwip1QFqiGNN01bBAi6TaWEIbw3AlPf4DxbtJqG5XeN2MvkQEjWdanvhb6M K7uwTSmTI7YOD0iAdDvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngXLt-000UsL-H6; Mon, 18 Apr 2022 19:48:01 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngXLp-000UqW-Oi for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 19:47:59 +0000 Received: by mail-ed1-x531.google.com with SMTP id g20so18602811edw.6 for ; Mon, 18 Apr 2022 12:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NXg16T5RHzmRSU7fzbqLl5dRDSsIh5leaaKIVXJix2Y=; b=n6TH58tO6Jf+8u5wbFfxZZ1rGSt9UpKEMo4zwn5SrzJg5kBLgAnwKPjEFKGOn1AsVS BlTUiehQ1Zjs+vmeVNX+gknbYOIT7noOyWXV3+LClR4fl7XiIIaS/9Cc1rxU22dCtuaK pQ/b93oy/yreNJvMQcrLjfcxDGUaFW/7+1GLVBne6lfgv+anTs0MIp60sRbuPxKfMUTS mAdwxkPpboKUwwoyDwxwYgC5LimvdLfbqffeEt/evWZRKSDezMKAsw3qP4hQgLnBorKX ND5e4C+abAw+VaSHw4ACJGqoi5sIyB7YGM8tQwYQ2tdzkxbJwnwNtfd2/1CkMBa6U87y 8F9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXg16T5RHzmRSU7fzbqLl5dRDSsIh5leaaKIVXJix2Y=; b=X4iuIov5NaErKupcm8Vw2WzKrFLqshoS/25H8Ueikq1bWrEJcO+Sgz5HAOZSTtBEQa qT7EXtAI+1KNxG4houwLfqWLzWQHOSTSmE3sTc8dE5IcaITY3orS9WDWygvKdP2B3GMd ARUcd7i6/TFykBdxFp1HDSN7717S7XTxldq30RzBm2IYJy6VT1yTTUcXTGPtwJB6a+JV Q4JIAwf1eTy+NhLZ0LPrOF4AQuO2ToUCsbnKzOAQkLxPoSy3BwfqcqorXJBQxw0+5SK0 asJghcAtu1VAA8Y8Ul/+fsO6XD3W+cWNQc8KONVTTvzuJUZTfi1757KZ7HtnQCw+fGQ8 GO8g== X-Gm-Message-State: AOAM530pRVPN3IKu+z28CfDqfD4LyMu2C1+x39NOR81tO9JeI0F7I3xa 1O3aFV82nhaZ8gaqjXzjslXn9dHmjB6e0FpgyJbTkCb8I4CPRnDN X-Google-Smtp-Source: ABdhPJwvoJ8S2SQnY/koE4FsNKMAxVbvlxW9QX5pT4ZaYsnS74IHedJObRxq4/ya8URo4hGKRxRf5E8Bb0WAjXdhtak= X-Received: by 2002:a05:6402:128f:b0:41d:7e85:8421 with SMTP id w15-20020a056402128f00b0041d7e858421mr13502922edv.352.1650311273941; Mon, 18 Apr 2022 12:47:53 -0700 (PDT) MIME-Version: 1.0 References: <20220328005005.72492-1-kc@postmarketos.org> <20220328005005.72492-4-kc@postmarketos.org> In-Reply-To: <20220328005005.72492-4-kc@postmarketos.org> From: Bartosz Golaszewski Date: Mon, 18 Apr 2022 21:47:43 +0200 Message-ID: Subject: Re: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs To: Caleb Connolly Cc: Rob Herring , Heiko Stuebner , Linus Walleij , devicetree , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , ~postmarketos/upstreaming@lists.sr.ht, martijn@brixit.nl, Arnaud Ferraris X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_124757_845260_0A3E74C8 X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly wrote: > > Add support for deferred PIN_CONFIG_INPUT_ENABLE handling. > > Signed-off-by: Caleb Connolly > --- > drivers/gpio/gpio-rockchip.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c > index bcf5214e3586..e342a6dc4c6c 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev) > dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin, > cfg->arg); > break; > + case PIN_CONFIG_INPUT_ENABLE: > + ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin); > + if (ret) > + dev_warn(dev, "setting input pin %u failed\n", cfg->pin); > + break; > default: > dev_warn(dev, "unknown deferred config param %d\n", cfg->param); > break; > -- > 2.35.1 > Does this depend on patches 1 & 2 or does patch 4 depend on this one? If so: Acked-by: Bartosz Golaszewski Otherwise I can take it through the GPIO tree. Bart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel