From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5ECAC4332F for ; Wed, 23 Nov 2022 15:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237585AbiKWPuI (ORCPT ); Wed, 23 Nov 2022 10:50:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238796AbiKWPtk (ORCPT ); Wed, 23 Nov 2022 10:49:40 -0500 Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A6B1C6899 for ; Wed, 23 Nov 2022 07:49:17 -0800 (PST) Received: by mail-vk1-xa2c.google.com with SMTP id v81so8914062vkv.5 for ; Wed, 23 Nov 2022 07:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Jivc45dTXvLm1YRXWATZxQPSyvJMgufwFq3xGWuqv3M=; b=HhGGX95JXkc8p/cmrwB5sqv/RmAgSIe6Y1pIc6pBWtss4VPKEWpXS5pYXhmooshnuM rcTc1CheQ5j1WJBjffdRCu8xo7NIx/+fg90KRf35VV2y45j14D8dcDy9Nxy6HSeMqpnI vw8Bj8w5QAnm7jbG345EfuyFaELsS/TqhxRxtD7+Inj3LuI1wNwYCp4rsksYzFpniw3O kYwVPAfVhwbbGP/Wpll/QJK5hsohJ88WWafxcQRsVQthMkA6/oKK4qQK3FtOsJtZWK6V AN1bYOHyr0OnYpouDiUWTbMLFtpsksrU//fePasFTt1AHx/qfO9FLNoN8US8gPDAORAQ /5HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jivc45dTXvLm1YRXWATZxQPSyvJMgufwFq3xGWuqv3M=; b=Wp/LcfgKT0qZls9D07KpDxzMb3izXtfIbOGhnxII8LfWgWQ6j6GGo0f2TeM6lRDfOI SHiHFmsNFT85JuV3F/ew8WB6EoaJDQ0Vac/Wm9J5xk+tf0qUiYYAQcMBkQyiUHVD52oU mqw5bam2jPrfD34me6CEfK/3vgCxkFPOWniZ5PSmj6rUT1Wk3U2aRlRJYUoSOETWvgQ4 4+BWDLKUDu1LwNGnVUR9k8KNiFV732jSEg8Z+7SPCBLzokpJwc6EWrd1zy1e4XCOKfHu xQrpMgvxwgnpMV7E9oWTkziQ3NJyl6/BrfWDEqQU14t90K3DADpLY7FxqDYFSHqjoJIn dMCg== X-Gm-Message-State: ANoB5pmWIUrDXK2rM9i9sKYeKSjv+P3U6jwauUY8ExXRLrQb8O8WvS2W j6WRKI7sFIMgkswI4vV3O75KpFp65JGB/4NFU9n5LA== X-Google-Smtp-Source: AA0mqf4OTkJmqH0nX+bnMDHlcETQbnZux4XMI/LgC9yc/Mif5H9e9AKyW0o+PZg050EBQBNhpu0Aadhu7D6IO6KKtHE= X-Received: by 2002:a1f:54c1:0:b0:3b7:65cc:8ebc with SMTP id i184-20020a1f54c1000000b003b765cc8ebcmr10691674vkb.5.1669218556496; Wed, 23 Nov 2022 07:49:16 -0800 (PST) MIME-Version: 1.0 References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-12-uwe@kleine-koenig.org> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 23 Nov 2022 16:49:05 +0100 Message-ID: Subject: Re: [PATCH 011/606] gpio: max732x: Convert to i2c's .probe_new() To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Linus Walleij , linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Nov 23, 2022 at 10:47 AM Bartosz Golaszewski wrote: > > On Fri, Nov 18, 2022 at 11:46 PM Uwe Kleine-K=C3=B6nig wrote: > > > > From: Uwe Kleine-K=C3=B6nig > > > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > > that explicitly in the probe function. > > > > Signed-off-by: Uwe Kleine-K=C3=B6nig > > --- > > drivers/gpio/gpio-max732x.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c > > index da6972117030..68e982cdee73 100644 > > --- a/drivers/gpio/gpio-max732x.c > > +++ b/drivers/gpio/gpio-max732x.c > > @@ -608,9 +608,9 @@ static struct max732x_platform_data *of_gpio_max732= x(struct device *dev) > > return pdata; > > } > > > > -static int max732x_probe(struct i2c_client *client, > > - const struct i2c_device_id *id) > > +static int max732x_probe(struct i2c_client *client) > > { > > + const struct i2c_device_id *id =3D i2c_client_get_device_id(cli= ent); > > struct max732x_platform_data *pdata; > > struct device_node *node; > > struct max732x_chip *chip; > > @@ -707,7 +707,7 @@ static struct i2c_driver max732x_driver =3D { > > .name =3D "max732x", > > .of_match_table =3D of_match_ptr(max732x_of_table), > > }, > > - .probe =3D max732x_probe, > > + .probe_new =3D max732x_probe, > > .id_table =3D max732x_id, > > }; > > > > -- > > 2.38.1 > > > > Applied, thanks! > > Bartosz Ugh, backing it out, I thought these patches were independent. In that case: Acked-by: Bartosz Golaszewski