From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16B717461 for ; Wed, 2 Nov 2022 16:26:04 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id l8so14803965ljh.13 for ; Wed, 02 Nov 2022 09:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i9lzFBitnyAp6ipWpwtICbzA7hqqgUYQcinpTzvMvYI=; b=pE3B01zFCVw+bIUAPWnhHJVI4HcUniogBqFng7orjWDucp24hEY7aCrqjDuO6GV6hM YSu5meS5CRBEILfG0g6tdvKOR9x44wyXJAXK/wQ0VHKqUkLclJeEZX8tEklUhNyRClvC tkaWHlt2A5zuihz51DFhN6Jwlrtrkglb8YvMFNw9Q2LyLwSUpkLRmkO9Yd4vIFLeercb pHdVDYN32QXUIfuydzeuJ2zCpen7H8ise2cmH1/CEXU3af7Bky29LQAha/r4RpKRXz3C TL/nArGGa58sBE/P2nuzY7qUCjG/V+HRkVZZyoIXbguWohQuZnynAiIQ6cwVMrsjaUf1 V7CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i9lzFBitnyAp6ipWpwtICbzA7hqqgUYQcinpTzvMvYI=; b=BocCwYuqnPJc4yZZegdUL9+1TZpRN5NWWToevnsyrzeuBJ0X3gQBXBUe3JhEcFQ7r1 bCcUePQHCI7uOMLmnwCIyZmytt6MC6ht6X+V9eT03yyQJbZtEiqbpD68QSabJr6Jq/FC NATrCbtBaE2t0OUG9lkVnGZw6fSDFy72RYJBCDVMXI/5zv2N2bbZzD1stLS11S0RkBO/ z4zG08wZLpWkC6cYC5k+Txj/ZIUOCpSQKDwvyvhLR10DSu/jwSFM8uM7Sbzw15aYxUc3 NeZOMtCWTNUocmQGWaVyowkG5LMh4eigaqhq55XAF5wiD147Eoy1YA3QMGtXMEUs9fBZ ikPw== X-Gm-Message-State: ACrzQf2jmiF5QIh3INAf9Wk/gkqzcEbVVfJZyQx8jglNApcCrWFqmgUF DVe5hok7ufalIaBI3L4mzHLpHPQJmZWCSRyrdFc= X-Google-Smtp-Source: AMsMyM6IbNesFItHd+WCfCAtu+r/QS5DLwm2t+DZtQmi2xg5qQZv8LtFV2vCfxx4R8Q8SmpZvAFp2FCTROx9tNrxDFk= X-Received: by 2002:a05:651c:33c:b0:277:e2b:de4a with SMTP id b28-20020a05651c033c00b002770e2bde4amr9519495ljp.55.1667406362096; Wed, 02 Nov 2022 09:26:02 -0700 (PDT) Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20221102141513.49289-1-fnkl.kernel@gmail.com> <20221102141513.49289-3-fnkl.kernel@gmail.com> In-Reply-To: From: Sasha Finkelstein Date: Wed, 2 Nov 2022 19:25:50 +0300 Message-ID: Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller To: Biju Das Cc: "thierry.reding@gmail.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "marcan@marcan.st" , "sven@svenpeter.dev" , "alyssa@rosenzweig.io" , "asahi@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-pwm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" On Wed, 2 Nov 2022 at 19:02, Biju Das wrote: > I just asked, because you are unnecessarily turning on the clock or increasing the usage > Count, even if it is not used by anyone during probe. It is used to get the clock rate so it can be used to convert between seconds and pwm ticks, and the pwm uses that clock, so it is kept enabled while the pwm is active. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63D2FC4332F for ; Wed, 2 Nov 2022 16:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vF4HlNBYiHyMdwXnsdOZgxPWpbIdioeaNP4ubVWPidQ=; b=TWj2GNGPaMUmgs /sgr5qPdbzQk3LAZ/EKuKy9de/4qBYz67EGaQafa9q4Fp8gB+mv/rl/sSEESLiwUGUOqeADvp8g8S qz2Un2DiZDZHVo7TtUa7+H6irGVTB/KM0Nmhsl3m8NXKZ0KZc8LCbGBg6WnguegvyVHCEmLEn3yaw 2LbqtOsyiSDrEGlTNLAOpRfYpKVziy0RY6bq7QMEIujbeKpPmHufjSw0xzVAWKdoVLGyn+4a9olQo AX+thvvJC7a9am4ioT0jXzPyzuW66LATStXnif75RvMi5AM1ZzDb7OAcjf6Au2BcO8vUu/Qfw5xbK D+Hc0O6HjX9NahodpwXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqGZ5-00C7Tp-NJ; Wed, 02 Nov 2022 16:26:07 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqGZ1-00C7Rn-T9 for linux-arm-kernel@lists.infradead.org; Wed, 02 Nov 2022 16:26:05 +0000 Received: by mail-lj1-x231.google.com with SMTP id s24so25706822ljs.11 for ; Wed, 02 Nov 2022 09:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i9lzFBitnyAp6ipWpwtICbzA7hqqgUYQcinpTzvMvYI=; b=pE3B01zFCVw+bIUAPWnhHJVI4HcUniogBqFng7orjWDucp24hEY7aCrqjDuO6GV6hM YSu5meS5CRBEILfG0g6tdvKOR9x44wyXJAXK/wQ0VHKqUkLclJeEZX8tEklUhNyRClvC tkaWHlt2A5zuihz51DFhN6Jwlrtrkglb8YvMFNw9Q2LyLwSUpkLRmkO9Yd4vIFLeercb pHdVDYN32QXUIfuydzeuJ2zCpen7H8ise2cmH1/CEXU3af7Bky29LQAha/r4RpKRXz3C TL/nArGGa58sBE/P2nuzY7qUCjG/V+HRkVZZyoIXbguWohQuZnynAiIQ6cwVMrsjaUf1 V7CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i9lzFBitnyAp6ipWpwtICbzA7hqqgUYQcinpTzvMvYI=; b=bTUMIUchCw3MZVDLG5XOprRKA1mIHEUUFmQDdyaV/2uw+v2RRycJjJSEou+jvbJTei UHJ8968zQTEDfBlLT2rsf3yt48vXKZdWZVIOF5F0vYaeHVlvb48RNVRImU88/ciSYR3Q mbSmMeTNNQlfakDcMI0qDHjDRukeWWv7E1Nnvw4wCHSLKly3r21wnF5JsNFF3a+fHaC4 JdEKp752hQUtWC6yb+jbb0ewFt4C/AVeW+BERmiAWqYWFYFsdspxbs4eGYe4/I2JQIuk TX1aQBeJIh57WH1vVsbyQ97j9QN2f99zinx7CLPgd2zrWTKh0A740B7TC5k8TWcjocTm 3m+w== X-Gm-Message-State: ACrzQf2xz6HEqYmrkEp1BBkFolzMRMw8QEXroPW4aRyQ2Uz+h4QYWSG6 oxlN4bG/qVtLURvuAVwr9pbTrQYwB93KESmAU3E= X-Google-Smtp-Source: AMsMyM6IbNesFItHd+WCfCAtu+r/QS5DLwm2t+DZtQmi2xg5qQZv8LtFV2vCfxx4R8Q8SmpZvAFp2FCTROx9tNrxDFk= X-Received: by 2002:a05:651c:33c:b0:277:e2b:de4a with SMTP id b28-20020a05651c033c00b002770e2bde4amr9519495ljp.55.1667406362096; Wed, 02 Nov 2022 09:26:02 -0700 (PDT) MIME-Version: 1.0 References: <20221102141513.49289-1-fnkl.kernel@gmail.com> <20221102141513.49289-3-fnkl.kernel@gmail.com> In-Reply-To: From: Sasha Finkelstein Date: Wed, 2 Nov 2022 19:25:50 +0300 Message-ID: Subject: Re: [PATCH v2 2/4] pwm: Add Apple PWM controller To: Biju Das Cc: "thierry.reding@gmail.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "marcan@marcan.st" , "sven@svenpeter.dev" , "alyssa@rosenzweig.io" , "asahi@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-pwm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_092603_958087_8B7B14CD X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2 Nov 2022 at 19:02, Biju Das wrote: > I just asked, because you are unnecessarily turning on the clock or increasing the usage > Count, even if it is not used by anyone during probe. It is used to get the clock rate so it can be used to convert between seconds and pwm ticks, and the pwm uses that clock, so it is kept enabled while the pwm is active. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel