[PATCH] mips: delete duplication of BUILTIN_DTB selection

[PATCH] mips: delete duplication of BUILTIN_DTB selection

[Maksym Kokhan]

CONFIG_BUILTIN_DTB selection is duplicated in menu
"Machine selection" under MIPS_MALTA.

Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
---
 arch/mips/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 3551199..71d6549 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -539,7 +539,6 @@ config MIPS_MALTA
 	select USE_OF
 	select LIBFDT
 	select ZONE_DMA32 if 64BIT
-	select BUILTIN_DTB
 	select LIBFDT
 	help
 	  This enables support for the MIPS Technologies Malta evaluation
-- 
2.7.4

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

[Sergei Shtylyov]

Hello!

On 10/3/2018 8:23 PM, Maksym Kokhan wrote:

> CONFIG_BUILTIN_DTB selection is duplicated in menu
> "Machine selection" under MIPS_MALTA.
> 
> Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> ---
>   arch/mips/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 3551199..71d6549 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -539,7 +539,6 @@ config MIPS_MALTA
>   	select USE_OF
>   	select LIBFDT
>   	select ZONE_DMA32 if 64BIT
> -	select BUILTIN_DTB
>   	select LIBFDT

    LIBFDT seems duplicated too.

[...]

MBR, Sergei

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

[Geert Uytterhoeven]

On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> > CONFIG_BUILTIN_DTB selection is duplicated in menu
> > "Machine selection" under MIPS_MALTA.
> >
> > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> > Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> > ---
> >   arch/mips/Kconfig | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 3551199..71d6549 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -539,7 +539,6 @@ config MIPS_MALTA
> >       select USE_OF
> >       select LIBFDT
> >       select ZONE_DMA32 if 64BIT
> > -     select BUILTIN_DTB
> >       select LIBFDT
>
>     LIBFDT seems duplicated too.

Using random sort order doesn't help. Keep them sorted, please?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

[Maksym Kokhan]

On Thu, Oct 4, 2018 at 12:14 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> > > CONFIG_BUILTIN_DTB selection is duplicated in menu
> > > "Machine selection" under MIPS_MALTA.
> > >
> > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > > Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> > > Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> > > ---
> > >   arch/mips/Kconfig | 1 -
> > >   1 file changed, 1 deletion(-)
> > >
> > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > index 3551199..71d6549 100644
> > > --- a/arch/mips/Kconfig
> > > +++ b/arch/mips/Kconfig
> > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > >       select USE_OF
> > >       select LIBFDT
> > >       select ZONE_DMA32 if 64BIT
> > > -     select BUILTIN_DTB
> > >       select LIBFDT
> >
> >     LIBFDT seems duplicated too.
>
> Using random sort order doesn't help. Keep them sorted, please?

We are going to deal with it in the separate patch.

---
Regards,
Maksym Kokhan

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

[Maksym Kokhan]

On Thu, Oct 4, 2018 at 3:06 PM Maksym Kokhan
<maksym.kokhan@globallogic.com> wrote:
>
> On Thu, Oct 4, 2018 at 12:14 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > > On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> > > > CONFIG_BUILTIN_DTB selection is duplicated in menu
> > > > "Machine selection" under MIPS_MALTA.
> > > >
> > > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > > > Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> > > > Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> > > > ---
> > > >   arch/mips/Kconfig | 1 -
> > > >   1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > index 3551199..71d6549 100644
> > > > --- a/arch/mips/Kconfig
> > > > +++ b/arch/mips/Kconfig
> > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > >       select USE_OF
> > > >       select LIBFDT
> > > >       select ZONE_DMA32 if 64BIT
> > > > -     select BUILTIN_DTB
> > > >       select LIBFDT
> > >
> > >     LIBFDT seems duplicated too.
> >
> > Using random sort order doesn't help. Keep them sorted, please?
>
> We are going to deal with it in the separate patch.

Is it OK to leave this patch as it is and make another patch/patches
for other changes or it would be better to modify it to remove
duplication of LIBFDT too and sort this list of configs?

--
Regards,
Maksym Kokhan

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

[Paul Burton]

Hi Maksym,

On Tue, Nov 06, 2018 at 05:29:40PM +0200, Maksym Kokhan wrote:
> > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > > index 3551199..71d6549 100644
> > > > > --- a/arch/mips/Kconfig
> > > > > +++ b/arch/mips/Kconfig
> > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > > >       select USE_OF
> > > > >       select LIBFDT
> > > > >       select ZONE_DMA32 if 64BIT
> > > > > -     select BUILTIN_DTB
> > > > >       select LIBFDT
> > > >
> > > >     LIBFDT seems duplicated too.
> > >
> > > Using random sort order doesn't help. Keep them sorted, please?
> >
> > We are going to deal with it in the separate patch.
> 
> Is it OK to leave this patch as it is and make another patch/patches
> for other changes or it would be better to modify it to remove
> duplication of LIBFDT too and sort this list of configs?

My preference would be that you remove all the duplicates as one patch,
then sort the selects alphabetically in a second patch. That should be
granular enough to make it easy to review, but not so fine-grained that
it becomes annoying.

Thanks,
    Paul

Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

[Paul Burton]

Hi Maksym,

On Tue, Nov 06, 2018 at 05:29:40PM +0200, Maksym Kokhan wrote:
> > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > > index 3551199..71d6549 100644
> > > > > --- a/arch/mips/Kconfig
> > > > > +++ b/arch/mips/Kconfig
> > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > > >       select USE_OF
> > > > >       select LIBFDT
> > > > >       select ZONE_DMA32 if 64BIT
> > > > > -     select BUILTIN_DTB
> > > > >       select LIBFDT
> > > >
> > > >     LIBFDT seems duplicated too.
> > >
> > > Using random sort order doesn't help. Keep them sorted, please?
> >
> > We are going to deal with it in the separate patch.
> 
> Is it OK to leave this patch as it is and make another patch/patches
> for other changes or it would be better to modify it to remove
> duplication of LIBFDT too and sort this list of configs?

My preference would be that you remove all the duplicates as one patch,
then sort the selects alphabetically in a second patch. That should be
granular enough to make it easy to review, but not so fine-grained that
it becomes annoying.

Thanks,
    Paul