All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU devel list <qemu-devel@nongnu.org>
Subject: Re: Picture missing in About dialog on cocoa ui
Date: Thu, 8 Jul 2021 14:37:51 +0900	[thread overview]
Message-ID: <CAMVc7JXgn5ttSEjPB_=rS9CsYiQOFS48hcAbr3NQnom-qk75VA@mail.gmail.com> (raw)
In-Reply-To: <797ADA26-0366-447F-85F0-5E27DC534479@gmail.com>

Hi,

My installation correctly shows the picture. Please make sure you
install it and run the installed binary (not the binary located in the
build directory). The new code should work reliably once you install
it while the old code may or may not work depending on how you execute
the binary.

Regards,
Akihiko Odaki

On Thu, Jul 8, 2021 at 2:00 AM Programmingkid <programmingkidx@gmail.com> wrote:
>
> Hello, now that the code to add the icon to QEMU has been restored for Mac OS, I think it is time to revert patch e31746ecf8dd2f25f687c94ac14016a3ba5debfc. This patch was made to fix the missing icon in the About dialog but it doesn't seem to work any more. I do not see a picture in the About dialog on Mac OS 11.1. The easiest fix for this issue is to revert the mentioned patch. When I ran
> 'git revert e31746ecf8dd2f25f687c94ac14016a3ba5debfc' the picture in the About dialog appeared again.


  reply	other threads:[~2021-07-08  5:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 17:00 Picture missing in About dialog on cocoa ui Programmingkid
2021-07-08  5:37 ` Akihiko Odaki [this message]
2021-07-08  8:58   ` Peter Maydell
2021-07-08 16:23     ` Programmingkid
2021-07-08 16:27   ` Programmingkid
2021-07-08 17:50     ` Peter Maydell
2021-07-08 18:38       ` Programmingkid
2021-08-16 20:55         ` Programmingkid
2021-08-17  8:59           ` Peter Maydell
2021-07-09  0:15       ` Akihiko Odaki
2021-07-10  2:43         ` Programmingkid
2021-07-10  3:30           ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMVc7JXgn5ttSEjPB_=rS9CsYiQOFS48hcAbr3NQnom-qk75VA@mail.gmail.com' \
    --to=akihiko.odaki@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.