From: rob.lee@linaro.org (Rob Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: IRQ and FIQ disabling during sleep states.
Date: Wed, 18 Jul 2012 11:19:02 -0500 [thread overview]
Message-ID: <CAMXH7KG_Q50AEkwm1B7YuhN2iy287BbMg8PB1EvBgNmBFCEvOw@mail.gmail.com> (raw)
In-Reply-To: <4FFEF5DA.8000505@linaro.org>
Hello Peter and Daniel,
On Thu, Jul 12, 2012 at 11:05 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> On 07/11/2012 02:30 PM, Peter De Schrijver wrote:
>> Hi,
>>
>> I noticed several platforms exhibit different behaviour wrt disabling IRQ or
>> FIQ when entering a CPU idle state. Tegra for example disables both FIQ and
>> IRQ when entering CPU clockstop, but OMAP seems to only disable FIQs? Also
>> the generic cpuidle_wrap_enter() function, enables IRQs after return from
>> the idle state, but doesn't disable them.
>>
>> Some questions:
>>
>> 1) I assume we need to disable IRQ/FIQ to not confuse the cpuidle code due to
>> late interrupts?
Part of the a cpuidle irq and time keeping consolidation and cleanup
patch that went in a while back removed all the irq disable calls from
arm platform code as they are they are already disabled at the
arch/arm level in kernel/process.c before calling cpu_idle_call. I
meant to remove these redundant platform calls for all ARM platforms
but it's possible I missed one for Tegra if its platform irq disable
still exists.
>> 2) What prevents us from unifying this?
It may be good to also disable the FIQ's at the same time as IRQ's in
arch/arm/kernel/process.c. I had made some mention of also global
disabling FIQs in my initial RFC submission and you can see the
responses here:
http://lists.infradead.org/pipermail/linux-arm-kernel/2011-December/076036.html
Given the response, I didn't pursue making any changes to FIQ
disabling. But if would have suggested doing so at same location as
irq's are being disabled for ARM, perhaps it would have been better
received. Now that many arm systems are using FIQs for handling
interrupts in the secure trust zone world, that may change things as
well.
Rob
>
>
> AFAIR, Rob Lee discussed about this point already. Maybe he has a
> pointer to the discussion.
>
>
>
> --
> <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
next prev parent reply other threads:[~2012-07-18 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 12:30 IRQ and FIQ disabling during sleep states Peter De Schrijver
2012-07-12 16:05 ` Daniel Lezcano
2012-07-18 16:19 ` Rob Lee [this message]
2012-07-18 16:31 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMXH7KG_Q50AEkwm1B7YuhN2iy287BbMg8PB1EvBgNmBFCEvOw@mail.gmail.com \
--to=rob.lee@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.