From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can: bittiming: fix two grammar mistakes in documentation for struct can_tdc
Date: Thu, 17 Jun 2021 01:18:00 +0900 [thread overview]
Message-ID: <CAMZ6RqKF=TkE9099ip2Ac_t+kcC1Ztba6+hzAuTi3-_qLk+Aaw@mail.gmail.com> (raw)
In-Reply-To: <20210616133304.txu6tt7v3ezfgvvi@pengutronix.de>
On Wed. 16 Jun 2021 at 22:33, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> On 16.06.2021 21:40:57, Vincent Mailhol wrote:
> > This patch fixes two grammar errors in the documentation for struct
> > can_tdc.
> >
> > First grammar error: add a missing third person 's'.
> >
> > Second grammar error: replace "such as" by "such that". The intent is
> > to give a condition, not an example.
> >
> > Fixes: 289ea9e4ae59 ("can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)")
> > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> > ---
> > Hi Marc,
> >
> > If that makes sense to you, feel free to squash this in your other
> > patch.
>
> Makes sense. I've added you as Co-developed-by:
Great, thank you!
> | can: bittiming: fix documentation for struct can_tdc::tdcv
One nitpick: the title should become
| can: bittiming: fix documentation for struct can_tdc
(without the ::tdcv) because the last fix is on tdco.
> | This patch fixes a typo in the documentation for struct can_tdc::tdcv.
> | The number "0" refers to automatic mode not the letter "O".
> |
> | Further two grammar errors in the documentation for struct can_tdc are
> | fixed.
> |
> | First grammar error: add a missing third person 's'.
> |
> | Second grammar error: replace "such as" by "such that". The intent is
> | to give a condition, not an example.
> |
> | Fixes: 289ea9e4ae59 ("can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)")
> | Link: https://lore.kernel.org/r/20210616095922.2430415-1-mkl@pengutronix.de
> | Link: https://lore.kernel.org/r/20210616124057.60723-1-mailhol.vincent@wanadoo.fr
> | Co-developed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> | Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> | Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> | Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> regards,
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-06-16 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 12:40 [PATCH] can: bittiming: fix two grammar mistakes in documentation for struct can_tdc Vincent Mailhol
2021-06-16 13:33 ` Marc Kleine-Budde
2021-06-16 16:18 ` Vincent MAILHOL [this message]
2021-06-17 10:56 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZ6RqKF=TkE9099ip2Ac_t+kcC1Ztba6+hzAuTi3-_qLk+Aaw@mail.gmail.com' \
--to=mailhol.vincent@wanadoo.fr \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.