From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 989BDC433EF for ; Mon, 10 Jan 2022 07:09:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACE556B00A1; Mon, 10 Jan 2022 02:09:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7F356B00A2; Mon, 10 Jan 2022 02:09:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96CE36B00A3; Mon, 10 Jan 2022 02:09:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id 8792B6B00A1 for ; Mon, 10 Jan 2022 02:09:42 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 443A9824C421 for ; Mon, 10 Jan 2022 07:09:42 +0000 (UTC) X-FDA: 79013502204.31.79A1B81 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf16.hostedemail.com (Postfix) with ESMTP id D653C180006 for ; Mon, 10 Jan 2022 07:09:41 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id p5so28208196ybd.13 for ; Sun, 09 Jan 2022 23:09:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y3OGHIn/YfmzbOCEnUx+tpkxW1t9w9sIw/y6pwSGj5Q=; b=qksllrz5UxrzO6jLkSoUZUgEaLAaHVq8EbmlsoySWDcoxLGSiBrUx0MCnaCiOLBgQj xqyFimPf2c5RNRkBlPYsrJiES1ShhtSM94PLV2CpOBJlfwGj30T2mneeehOdkDJcKT/3 kxbYm3zvpl2z/loDYafYv/+A3aJsMdRO7IpCzLrvSVm/5kXADu1VfkpRcngIc8VlDxCD 1Z/3VyLfZXxDo9VDP/iF842TRfAipUIgK+14AAYkEBgSzmarlZ1Z1IeAo3fA7Vl3PLw+ vqctXB3diimSS1nFqiI8MgvmS1YfxtsjfsMbs8232rXMkDdbYJFwjvHgTX0Nux9fgm1m OlaQ== X-Gm-Message-State: AOAM531a6FMEFSJMW1JRTdNeapLxl/YM4GJoqNd1pO6ddZzkSCcEysyN K1dNovwE43CeUeKZ1IpmNaakxEtGpGhR11suskw= X-Google-Smtp-Source: ABdhPJwr0zcJ4b/rhsT7T4hs+O/4m82XxujtijODdT61BhP5nQf7fGEFIuS7rvXqpFXRouCPMZM+mffFPgAEsFcvHVc= X-Received: by 2002:a25:ba01:: with SMTP id t1mr14557743ybg.474.1641798581052; Sun, 09 Jan 2022 23:09:41 -0800 (PST) MIME-Version: 1.0 References: <202201081910.06vbmqbD-lkp@intel.com> In-Reply-To: <202201081910.06vbmqbD-lkp@intel.com> From: Vincent MAILHOL Date: Mon, 10 Jan 2022 16:09:30 +0900 Message-ID: Subject: Re: [linux-next:master 10650/11475] drivers/net/can/janz-ican3.c:1303 ican3_get_echo_skb() error: uninitialized symbol 'dlc'. To: Dan Carpenter Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Marc Kleine-Budde , Tom Rix Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: c33tczmdsqiiodtyynqr1uar4wmgqjfg X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D653C180006 Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of vincent.mailhol@gmail.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vincent.mailhol@gmail.com; dmarc=none X-HE-Tag: 1641798581-90297 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon. 10 Jan 2022 at 15:49, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: b8170452cd5121b11a5726e3ea8dbdfc2d74e771 > commit: cc4b08c31b5c51352f258032cc65e884b3e61e6a [10650/11475] can: do not increase tx_bytes statistics for RTR frames > config: i386-randconfig-m021-20220107 (https://download.01.org/0day-ci/archive/20220108/202201081910.06vbmqbD-lkp@intel.com/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > New smatch warnings: > drivers/net/can/janz-ican3.c:1303 ican3_get_echo_skb() error: uninitialized symbol 'dlc'. > > vim +/dlc +1303 drivers/net/can/janz-ican3.c > > 83702f69272e45 Ira W. Snyder 2012-07-19 1284 static unsigned int ican3_get_echo_skb(struct ican3_dev *mod) > 83702f69272e45 Ira W. Snyder 2012-07-19 1285 { > 83702f69272e45 Ira W. Snyder 2012-07-19 1286 struct sk_buff *skb = skb_dequeue(&mod->echoq); > 83702f69272e45 Ira W. Snyder 2012-07-19 1287 struct can_frame *cf; > 83702f69272e45 Ira W. Snyder 2012-07-19 1288 u8 dlc; > 83702f69272e45 Ira W. Snyder 2012-07-19 1289 > 83702f69272e45 Ira W. Snyder 2012-07-19 1290 /* this should never trigger unless there is a driver bug */ > 83702f69272e45 Ira W. Snyder 2012-07-19 1291 if (!skb) { > 83702f69272e45 Ira W. Snyder 2012-07-19 1292 netdev_err(mod->ndev, "BUG: echo skb not occupied\n"); > 83702f69272e45 Ira W. Snyder 2012-07-19 1293 return 0; > 83702f69272e45 Ira W. Snyder 2012-07-19 1294 } > 83702f69272e45 Ira W. Snyder 2012-07-19 1295 > 83702f69272e45 Ira W. Snyder 2012-07-19 1296 cf = (struct can_frame *)skb->data; > cc4b08c31b5c51 Vincent Mailhol 2021-12-07 1297 if (!(cf->can_id & CAN_RTR_FLAG)) > c7b74967799b1a Oliver Hartkopp 2020-11-20 1298 dlc = cf->len; > > "dlc" not initialized on else path. > > 83702f69272e45 Ira W. Snyder 2012-07-19 1299 > 83702f69272e45 Ira W. Snyder 2012-07-19 1300 /* check flag whether this packet has to be looped back */ > 83702f69272e45 Ira W. Snyder 2012-07-19 1301 if (skb->pkt_type != PACKET_LOOPBACK) { > 83702f69272e45 Ira W. Snyder 2012-07-19 1302 kfree_skb(skb); > 83702f69272e45 Ira W. Snyder 2012-07-19 @1303 return dlc; > 83702f69272e45 Ira W. Snyder 2012-07-19 1304 } > 83702f69272e45 Ira W. Snyder 2012-07-19 1305 > 83702f69272e45 Ira W. Snyder 2012-07-19 1306 skb->protocol = htons(ETH_P_CAN); > 83702f69272e45 Ira W. Snyder 2012-07-19 1307 skb->pkt_type = PACKET_BROADCAST; > 83702f69272e45 Ira W. Snyder 2012-07-19 1308 skb->ip_summed = CHECKSUM_UNNECESSARY; > 83702f69272e45 Ira W. Snyder 2012-07-19 1309 skb->dev = mod->ndev; > 83702f69272e45 Ira W. Snyder 2012-07-19 1310 netif_receive_skb(skb); > 83702f69272e45 Ira W. Snyder 2012-07-19 1311 return dlc; > 83702f69272e45 Ira W. Snyder 2012-07-19 1312 } > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org This issue has already been fixed in net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=c579792562837ec2e64b006cfc9423e4177a4d26 Yours sincerely, Vincent Mailhol From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2830436648860403672==" MIME-Version: 1.0 From: Vincent MAILHOL To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 10650/11475] drivers/net/can/janz-ican3.c:1303 ican3_get_echo_skb() error: uninitialized symbol 'dlc'. Date: Mon, 10 Jan 2022 16:09:30 +0900 Message-ID: In-Reply-To: <202201081910.06vbmqbD-lkp@intel.com> List-Id: --===============2830436648860403672== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon. 10 Jan 2022 at 15:49, Dan Carpenter wr= ote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: b8170452cd5121b11a5726e3ea8dbdfc2d74e771 > commit: cc4b08c31b5c51352f258032cc65e884b3e61e6a [10650/11475] can: do no= t increase tx_bytes statistics for RTR frames > config: i386-randconfig-m021-20220107 (https://download.01.org/0day-ci/ar= chive/20220108/202201081910.06vbmqbD-lkp(a)intel.com/config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > New smatch warnings: > drivers/net/can/janz-ican3.c:1303 ican3_get_echo_skb() error: uninitializ= ed symbol 'dlc'. > > vim +/dlc +1303 drivers/net/can/janz-ican3.c > > 83702f69272e45 Ira W. Snyder 2012-07-19 1284 static unsigned int ican= 3_get_echo_skb(struct ican3_dev *mod) > 83702f69272e45 Ira W. Snyder 2012-07-19 1285 { > 83702f69272e45 Ira W. Snyder 2012-07-19 1286 struct sk_buff *s= kb =3D skb_dequeue(&mod->echoq); > 83702f69272e45 Ira W. Snyder 2012-07-19 1287 struct can_frame = *cf; > 83702f69272e45 Ira W. Snyder 2012-07-19 1288 u8 dlc; > 83702f69272e45 Ira W. Snyder 2012-07-19 1289 > 83702f69272e45 Ira W. Snyder 2012-07-19 1290 /* this should ne= ver trigger unless there is a driver bug */ > 83702f69272e45 Ira W. Snyder 2012-07-19 1291 if (!skb) { > 83702f69272e45 Ira W. Snyder 2012-07-19 1292 netdev_er= r(mod->ndev, "BUG: echo skb not occupied\n"); > 83702f69272e45 Ira W. Snyder 2012-07-19 1293 return 0; > 83702f69272e45 Ira W. Snyder 2012-07-19 1294 } > 83702f69272e45 Ira W. Snyder 2012-07-19 1295 > 83702f69272e45 Ira W. Snyder 2012-07-19 1296 cf =3D (struct ca= n_frame *)skb->data; > cc4b08c31b5c51 Vincent Mailhol 2021-12-07 1297 if (!(cf->can_id = & CAN_RTR_FLAG)) > c7b74967799b1a Oliver Hartkopp 2020-11-20 1298 dlc =3D c= f->len; > > "dlc" not initialized on else path. > > 83702f69272e45 Ira W. Snyder 2012-07-19 1299 > 83702f69272e45 Ira W. Snyder 2012-07-19 1300 /* check flag whe= ther this packet has to be looped back */ > 83702f69272e45 Ira W. Snyder 2012-07-19 1301 if (skb->pkt_type= !=3D PACKET_LOOPBACK) { > 83702f69272e45 Ira W. Snyder 2012-07-19 1302 kfree_skb= (skb); > 83702f69272e45 Ira W. Snyder 2012-07-19 @1303 return dl= c; > 83702f69272e45 Ira W. Snyder 2012-07-19 1304 } > 83702f69272e45 Ira W. Snyder 2012-07-19 1305 > 83702f69272e45 Ira W. Snyder 2012-07-19 1306 skb->protocol =3D= htons(ETH_P_CAN); > 83702f69272e45 Ira W. Snyder 2012-07-19 1307 skb->pkt_type =3D= PACKET_BROADCAST; > 83702f69272e45 Ira W. Snyder 2012-07-19 1308 skb->ip_summed = =3D CHECKSUM_UNNECESSARY; > 83702f69272e45 Ira W. Snyder 2012-07-19 1309 skb->dev =3D mod-= >ndev; > 83702f69272e45 Ira W. Snyder 2012-07-19 1310 netif_receive_skb= (skb); > 83702f69272e45 Ira W. Snyder 2012-07-19 1311 return dlc; > 83702f69272e45 Ira W. Snyder 2012-07-19 1312 } > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org This issue has already been fixed in net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/= ?id=3Dc579792562837ec2e64b006cfc9423e4177a4d26 Yours sincerely, Vincent Mailhol --===============2830436648860403672==--