From: Vincent Mailhol <vincent.mailhol@gmail.com>
To: Harald Mommer <Harald.Mommer@opensynergy.com>
Cc: virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dariusz Stojaczyk <Dariusz.Stojaczyk@opensynergy.com>
Subject: Re: [RFC PATCH v2 2/2] can: virtio: Add virtio_can to MAINTAINERS file.
Date: Sat, 5 Nov 2022 19:14:54 +0900 [thread overview]
Message-ID: <CAMZ6RqLUCs0W8ZP2jAUsFMUXgHTjce649Gu+jnz_S1x_0ER6YQ@mail.gmail.com> (raw)
In-Reply-To: <20221104172421.8271-3-Harald.Mommer@opensynergy.com>
On Sat. 5 Nov. 2022 at 02:29, Harald Mommer
<Harald.Mommer@opensynergy.com> wrote:
> From: Harald Mommer <harald.mommer@opensynergy.com>
>
> Signed-off-by: Harald Mommer <Harald.Mommer@opensynergy.com>
> ---
> MAINTAINERS | 7 +++++++
> drivers/net/can/virtio_can.c | 6 ++----
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 379945f82a64..01b2738b7c16 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21692,6 +21692,13 @@ F: drivers/vhost/scsi.c
> F: include/uapi/linux/virtio_blk.h
> F: include/uapi/linux/virtio_scsi.h
>
> +VIRTIO CAN DRIVER
> +M: "Harald Mommer" <harald.mommer@opensynergy.com>
> +L: linux-can@vger.kernel.org
> +S: Maintained
> +F: drivers/net/can/virtio_can.c
> +F: include/uapi/linux/virtio_can.h
> +
> VIRTIO CONSOLE DRIVER
> M: Amit Shah <amit@kernel.org>
> L: virtualization@lists.linux-foundation.org
> diff --git a/drivers/net/can/virtio_can.c b/drivers/net/can/virtio_can.c
> index 43cf1c9e4afd..0e87172bbddf 100644
> --- a/drivers/net/can/virtio_can.c
> +++ b/drivers/net/can/virtio_can.c
> @@ -1,7 +1,7 @@
> -// SPDX-License-Identifier: GPL-2.0+
> +// SPDX-License-Identifier: GPL-2.0-only
Please squash this in the previous patch.
> /*
> * CAN bus driver for the Virtio CAN controller
> - * Copyright (C) 2021 OpenSynergy GmbH
> + * Copyright (C) 2021-2022 OpenSynergy GmbH
Same.
> */
>
> #include <linux/atomic.h>
> @@ -793,8 +793,6 @@ static void virtio_can_populate_vqs(struct virtio_device *vdev)
> unsigned int idx;
> int ret;
>
> - // TODO: Think again a moment if here locks already may be needed!
Same.
> /* Fill RX queue */
> vq = priv->vqs[VIRTIO_CAN_QUEUE_RX];
> for (idx = 0u; idx < ARRAY_SIZE(priv->rpkt); idx++) {
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-11-05 10:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 17:24 [RFC PATCH v2 0/2] can: virtio: virtio-can driver Harald Mommer
2022-11-04 17:24 ` [virtio-dev] " Harald Mommer
2022-11-04 17:24 ` [RFC PATCH v2 1/2] can: virtio: Initial virtio CAN driver Harald Mommer
2022-11-04 17:24 ` [virtio-dev] " Harald Mommer
2022-11-05 9:11 ` Vincent Mailhol
2022-11-05 10:11 ` Vincent Mailhol
2022-11-07 7:09 ` Alexander Stein
2022-11-07 7:35 ` Vincent Mailhol
2023-05-17 11:43 ` Harald Mommer
2023-05-17 11:43 ` [virtio-dev] " Harald Mommer
2022-11-04 17:24 ` [RFC PATCH v2 2/2] can: virtio: Add virtio_can to MAINTAINERS file Harald Mommer
2022-11-04 17:24 ` [virtio-dev] " Harald Mommer
2022-11-05 10:14 ` Vincent Mailhol [this message]
2022-11-08 19:13 ` Harald Mommer
2022-11-08 19:13 ` [virtio-dev] " Harald Mommer
2022-11-08 19:22 ` Harald Mommer
2022-11-08 19:22 ` [virtio-dev] " Harald Mommer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZ6RqLUCs0W8ZP2jAUsFMUXgHTjce649Gu+jnz_S1x_0ER6YQ@mail.gmail.com \
--to=vincent.mailhol@gmail.com \
--cc=Dariusz.Stojaczyk@opensynergy.com \
--cc=Harald.Mommer@opensynergy.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.